[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user priteshm commented on the issue: https://github.com/apache/drill/pull/976 @dprofeta will you be able to address the issues before the release? ---

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/976 Drill follows SQL rules and is case insensitive. If case sensitivity has snuck in somewhere (perhaps due to the use of `equals()` rather than `equalsIgnorCase()` or the use of a case-sensitive

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/976 Looking at the stack trace: - The code definitely is initializing a column of type REPEATABLE - The Fast Reader didn't expect this scenario so it used a default container (NullableVarBinary)

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/976 @dprofeta, tried to commit this PR, but ran into multiple functional test failures: ``` Execution Failures:

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/976 +1 looks good! ---

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user priteshm commented on the issue: https://github.com/apache/drill/pull/976 @sachouche can you please take a final look? If it looks good, maybe one of the committers can include this for the 1.12 release. @arina-ielchiieva ? ---

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user dprofeta commented on the issue: https://github.com/apache/drill/pull/976 I updated the javadoc with Paul remarks. ---

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user dprofeta commented on the issue: https://github.com/apache/drill/pull/976 here is the updated PR. Yes, I also wanted to add group without repetition. It is only a matter of naming so it should not be hard but when I tested, the fast reader was not able to handle it.

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/976 Sure! Regards, Salim From: dprofeta Sent: Friday, October 6, 2017 8:52:51 AM To: apache/drill

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user dprofeta commented on the issue: https://github.com/apache/drill/pull/976 @sachouche Can you review it? ---