Github user parthchandra commented on the pull request:
https://github.com/apache/drill/pull/396#issuecomment-193864509
Merged in df0f0af3d963c1b65eb01c3141fe84532c53f5a5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user parthchandra closed the pull request at:
https://github.com/apache/drill/pull/396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hnfgns commented on the pull request:
https://github.com/apache/drill/pull/396#issuecomment-193499159
+1 once comments above are addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/396#discussion_r55290473
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -1392,6 +1390,206 @@ void DrillClientQueryResult::clearAndDestroy(){
}
}
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/396#discussion_r55286410
--- Diff: contrib/native/client/example/querySubmitter.cpp ---
@@ -317,16 +320,20 @@ int main(int argc, char* argv[]) {
Github user paul-rogers commented on the pull request:
https://github.com/apache/drill/pull/396#issuecomment-193489132
Thanks for addressing the review comments!
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user parthchandra commented on the pull request:
https://github.com/apache/drill/pull/396#issuecomment-192797744
Updated the PR to address review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/396#discussion_r55117740
--- Diff: contrib/native/client/example/pooledConnections.cpp ---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/396#discussion_r55117425
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -1392,6 +1387,198 @@ void DrillClientQueryResult::clearAndDestroy(){
}
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/396#discussion_r55117339
--- Diff: contrib/native/client/example/pooledConnections.cpp ---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/396#discussion_r55117302
--- Diff: contrib/native/client/example/pooledConnections.cpp ---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/396#discussion_r55112200
--- Diff: contrib/native/client/example/pooledConnections.cpp ---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/396#discussion_r55112202
--- Diff: contrib/native/client/example/pooledConnections.cpp ---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/396#discussion_r55112213
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -1392,6 +1387,198 @@ void DrillClientQueryResult::clearAndDestroy(){
}
GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/396
DRILL-4313: Improve method of picking a random drillbit from the C++ client
Submitting as multiple commits to make review easier
Changes -
1) Made the logging thread safe.
2) Use
15 matches
Mail list logo
