[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495422 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -237,71 +281,81 @@ * DEFAULT: 64 MB * MAXIMUM: 2048

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495374 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -146,89 +158,121 @@ *|-bar -

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82485277 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -33,110 +33,122 @@ import

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495511 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java --- @@ -46,40 +46,83 @@ // max off heap memory

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82485619 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -33,110 +33,122 @@ import

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82485491 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -33,110 +33,122 @@ import

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495327 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -146,89 +158,121 @@ *|-bar -

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82485322 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -33,110 +33,122 @@ import

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495479 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/QueryClassLoader.java --- @@ -42,7 +42,17 @@ private static final

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495346 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -146,89 +158,121 @@ *|-bar -

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495464 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -237,71 +281,81 @@ * DEFAULT: 64 MB * MAXIMUM: 2048

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495404 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -237,71 +281,81 @@ * DEFAULT: 64 MB * MAXIMUM: 2048

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495353 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -146,89 +158,121 @@ *|-bar -

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-10-07 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/536#discussion_r82495497 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java --- @@ -46,40 +46,83 @@ // max off heap memory

[GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...

2016-06-28 Thread sudheeshkatkam
GitHub user sudheeshkatkam opened a pull request: https://github.com/apache/drill/pull/536 DRILL-4699: Add description column to sys.options table + Add new constructor for each validator in TypeValidators with description field; deprecate old constructors + Add