Github user paul-rogers closed the pull request at:
https://github.com/apache/drill/pull/704
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r109051708
--- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java
---
@@ -374,6 +374,19 @@ public void copyFromSafe(int fromIndex, int thisIndex,
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r109051934
--- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java
---
@@ -374,6 +374,19 @@ public void copyFromSafe(int fromIndex, int thisIndex,
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r109058076
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -281,6 +282,11 @@ public void copyFromSafe(int fromIndex, int thisIndex,
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r109051237
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -281,6 +282,11 @@ public void copyFromSafe(int fromIndex, int thisIndex,
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r109052570
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -281,6 +282,11 @@ public void copyFromSafe(int fromIndex, int thisIndex,
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r107219761
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/svremover/TestSVRemover.java
---
@@ -34,4 +38,33 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r106790613
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/svremover/TestSVRemover.java
---
@@ -34,4 +38,33 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r106789976
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/GenericSV4Copier.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r106789982
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/GenericSV2Copier.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r98299585
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/svremover/TestSVRemover.java
---
@@ -34,4 +38,33 @@ public void
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r97992610
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/GenericSV4Copier.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/704
DRILL-5125: Provide option to use generic code for sv remover
Performance tests showed that, for queries with a large number of
columns, it is faster to use a âgenericâ implementation of
13 matches
Mail list logo
