[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-09-25 Thread weijietong
Github user weijietong commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r140756869 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdMaxRowCount.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-09-21 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r140160556 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdMaxRowCount.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-09-21 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r140161176 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -203,32 +203,23 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-09-06 Thread weijietong
Github user weijietong commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r137424972 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -203,35 +203,27 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-09-06 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r137295692 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -203,35 +203,27 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-09-06 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r137291711 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -203,35 +203,27 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-25 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135292416 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -231,6 +236,12 @@ public static boolean

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-25 Thread weijietong
Github user weijietong commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135254275 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -231,6 +236,12 @@ public static boolean

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-25 Thread weijietong
Github user weijietong commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135249441 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -204,24 +205,28 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-25 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135196236 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -204,24 +205,28 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-25 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r135199961 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -231,6 +236,12 @@ public static boolean

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-22 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r134424551 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -231,6 +236,12 @@ public static boolean

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r131871360 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -231,6 +236,12 @@ public static boolean

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r131871292 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -231,6 +236,12 @@ public static boolean

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r131871049 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -204,24 +205,28 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r131870863 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -204,24 +205,28 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r131871224 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -204,24 +205,28 @@ public static void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r131871578 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java --- @@ -325,4 +325,5 @@ public void

[GitHub] drill pull request #889: DRILL-5691: enhance scalar sub queries checking for...

2017-08-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/889#discussion_r131870970 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java --- @@ -204,24 +205,28 @@ public static void

[GitHub] drill pull request #889: Drill 5691 enhance scalar sub queries checking for ...

2017-07-27 Thread weijietong
GitHub user weijietong opened a pull request: https://github.com/apache/drill/pull/889 Drill 5691 enhance scalar sub queries checking for the cartesian join You can merge this pull request into a Git repository by running: $ git pull https://github.com/weijietong/drill