[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-29 Thread GitBox
vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-40105 If logging needs to be enabled just for QA purposes, I still don't see why it needs to be enabled per query or be dynamic an

[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401234061 @sachouche I refer to your following comment: >User should be able to control batch statistics behavior within a client s

[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401230944 I am not convinced that a user should be able to change the amount of logging from a client session. A user may cause an exc