Re: Travis CI improvements

2019-02-11 Thread Kunal Khatua
Thanks for the clarification, Vova ! With the Maven (M2) cache, if your numbers have dropped that low.. it should be fine. I was concerned because TravisCI gets kicked off almost instantaneously when a commit gets pushed to my private repo, and I didn't want to increase the burden on the CI

Re: Travis CI improvements

2019-02-11 Thread Vova Vysotskyi
Thanks for the proposal, but I think enabling build only when changes in .proto files wouldn't help, since changes may be accidentally done in the corresponding java or c++ classes. Adding check for changes in the specific list of java/c++ files also may not help, since in future may be added new

Re: Travis CI improvements

2019-02-08 Thread Kunal Khatua
Very useful, Vova! Thanks. Does the protobuf regeneration run always or is it conditional to detecting changes in the protobuf files? It might be worth testing for changes to .proto files before attempting to regenerate the Java and C++ protobuf files. Otherwise, you'd be increasing the

Re: Travis CI improvements

2019-02-08 Thread Arina Yelchiyeva
Great improvements. Thanks, Vova! Kind regards, Arina > On Feb 8, 2019, at 1:35 PM, Vova Vysotskyi wrote: > > Hi all, > > Recently there are more PRs which require changes in protobuf files, but > sometimes contributors may forget to regenerate them. It was the reason for > creating

Travis CI improvements

2019-02-08 Thread Vova Vysotskyi
Hi all, Recently there are more PRs which require changes in protobuf files, but sometimes contributors may forget to regenerate them. It was the reason for creating DRILL-7031 . Before the fix for this Jira, there was a single job which builds