[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201892300 ## File path: indexing-service/src/main/java/io/druid/indexing/overlord/RemoteTaskRunner.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201892018 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/TaskMonitor.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891941 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201892027 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/TaskMonitor.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891972 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891892 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891935 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891918 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/PushedSegmentsReport.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891941 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891798 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/ParallelIndexSubTask.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891847 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/ParallelIndexSubTask.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891822 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/ParallelIndexSubTask.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891862 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891892 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891785 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/ParallelIndexSubTask.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891803 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/ParallelIndexSubTask.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891856 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891827 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/ParallelIndexSubTask.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891749 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891665 ## File path: indexing-service/src/main/java/io/druid/indexing/common/IndexTaskClient.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891629 ## File path: indexing-service/src/main/java/io/druid/indexing/common/Counters.java ## @@

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891657 ## File path: indexing-service/src/main/java/io/druid/indexing/common/IndexTaskClient.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891707 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891619 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891640 ## File path: indexing-service/src/main/java/io/druid/indexing/common/IndexTaskClient.java

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891627 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891613 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891602 ## File path:

[GitHub] asdf2014 commented on a change in pull request #5996: Fix NPE while handling CheckpointNotice in KafkaSupervisor

asdf2014 commented on a change in pull request #5996: Fix NPE while handling CheckpointNotice in KafkaSupervisor URL: https://github.com/apache/incubator-druid/pull/5996#discussion_r201891545 ## File path:

[GitHub] jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle

jihoonson commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891581 ## File path:

[GitHub] asdf2014 commented on a change in pull request #5996: Fix NPE while handling CheckpointNotice in KafkaSupervisor

asdf2014 commented on a change in pull request #5996: Fix NPE while handling CheckpointNotice in KafkaSupervisor URL: https://github.com/apache/incubator-druid/pull/5996#discussion_r201890785 ## File path:

[GitHub] jihoonson commented on a change in pull request #5996: Fix NPE while handling CheckpointNotice in KafkaSupervisor

jihoonson commented on a change in pull request #5996: Fix NPE while handling CheckpointNotice in KafkaSupervisor URL: https://github.com/apache/incubator-druid/pull/5996#discussion_r201887446 ## File path:

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-404354126 @leventov You are welcome. The amount of code is large and very troublesome. May have to trouble you. :+1:

[GitHub] jihoonson commented on issue #5980: Various changes about a few coding specifications

jihoonson commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-404353255 @asdf2014 thanks. I'll take another look. This is an

[GitHub] jihoonson edited a comment on issue #5492: Native parallel batch indexing without shuffle

jihoonson edited a comment on issue #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#issuecomment-403671944 > sorry for the slow review, was moving last week No worries about the review speed. It's always better late than

[incubator-druid] branch master updated: show that flatten will also work with avro extension (#5874)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 5f78a33 show that flatten will also work

[GitHub] fjy closed pull request #5874: show that flatten will also work with avro extension

fjy closed pull request #5874: show that flatten will also work with avro extension URL: https://github.com/apache/incubator-druid/pull/5874 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jon-wei closed pull request #5988: Coordinator fix exception caused by additional logging

jon-wei closed pull request #5988: Coordinator fix exception caused by additional logging URL: https://github.com/apache/incubator-druid/pull/5988 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jihoonson closed pull request #5995: fix link to query-context in broker config doc

jihoonson closed pull request #5995: fix link to query-context in broker config doc URL: https://github.com/apache/incubator-druid/pull/5995 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

Re: License headers and NOTICE file

Do your best with the NOTICE file. We will scrutinize it during the release process. I know it seems impolite not to mention contributors and copied code in the NOTICE, but there is a good reason to keep its contents absolutely minimal. Downstream projects are required to reproduce the NOTICE

[GitHub] Caroline1000 opened a new pull request #5995: fix link to query-context in broker config doc

Caroline1000 opened a new pull request #5995: fix link to query-context in broker config doc URL: https://github.com/apache/incubator-druid/pull/5995 This is an automated message from the Apache Git Service. To respond to

Re: Druid 0.12.2-rc1 vote

Well, it's never good if a WTH?! message actually gets logged. They are usually meant to be things that should "never" happen. I am ok with holding off 0.12.2-rc1 until this fix is in. On Wed, Jul 11, 2018 at 1:04 PM Jihoon Son wrote: > Thanks everyone for voting. > > Unfortunately, I found

[GitHub] jihoonson commented on issue #5994: Automatic cleanup druid_tasks table of metastore

jihoonson commented on issue #5994: Automatic cleanup druid_tasks table of metastore URL: https://github.com/apache/incubator-druid/issues/5994#issuecomment-404289731 Related to https://github.com/apache/incubator-druid/issues/5979#issuecomment-404050959.

[GitHub] jihoonson commented on issue #5979: Kafka Indexing Service lagging every hour

jihoonson commented on issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979#issuecomment-404289501 @erankor thanks! I raised https://github.com/apache/incubator-druid/issues/5994.

[GitHub] jihoonson opened a new issue #5994: Automatic cleanup druid_tasks table of metastore

jihoonson opened a new issue #5994: Automatic cleanup druid_tasks table of metastore URL: https://github.com/apache/incubator-druid/issues/5994 `druid_tasks` table stores all submitted tasks to overlords. Since this is never cleaned up automatically, it always grows as more tasks are

[GitHub] erankor commented on issue #5979: Kafka Indexing Service lagging every hour

erankor commented on issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979#issuecomment-404285477 Thanks @jihoonson, regarding 2, as you wrote - I just went over all tables, and looked deeper into the ones with a non-negligible

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201777132 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201773312 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201773728 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201763005 ## File path: indexing-service/src/main/java/io/druid/indexing/common/Counters.java ## @@

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201762816 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201760102 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201761280 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201767065 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201774505 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/PushedSegmentsReport.java

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201767683 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201761921 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201767881 ## File path:

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201781345 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/TaskMonitor.java

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201782258 ## File path: indexing-service/src/main/java/io/druid/indexing/overlord/RemoteTaskRunner.java

[GitHub] drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle

drcrallen commented on a change in pull request #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201780850 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/TaskMonitor.java

Re: Gitbox notifications

As it happens, all 3 of Druid's mentors (including myself) are ASF members. Their names are bold in https://people.apache.org/phonebook.html?podling=druid. I am busy, I will try to get to it today. On Wed, Jul 11, 2018 at 10:20 AM, Roman Leventov wrote: > It writes "Access restricted to ASF

Re: Gitbox notifications

It writes "Access restricted to ASF members and PMC chairs only!" to me. "ASF members" != any Apache project committers, this is a special title, little people have it. On Wed, 11 Jul 2018 at 11:50, Gian Merlino wrote: > Infra wrote back asking us to add a comm...@druid.apache.org list via >

[GitHub] gianm commented on issue #5976: Update license headers.

gianm commented on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-404239472 Thanks for reviewing, everyone -- I will merge this. This is an automated message from

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-404224485 [job-402722329](https://travis-ci.org/apache/incubator-druid/jobs/402722329) and