Re: Contributing an extension

2019-01-29 Thread Jonathan Wei
Hi Eyal, Thanks for the contrib, I'll have some time to start reviewing in the next week or two. It seems like a cool feature with interest from users, so I'd lean towards keeping it open for review/merge. Best, Jon On Tue, Jan 29, 2019 at 5:29 PM Eyal Yurman wrote: > Hi, > > This pr is

Contributing an extension

2019-01-29 Thread Eyal Yurman
Hi, This pr is waiting for a few months for review: https://github.com/apache/incubator-druid/pull/6430 https://github.com/apache/incubator-druid/issues/6320 So far only one reviewer (@b-slim) was kind enough to start looking at it. Since this is an contrib extension, it is not really blocking

Re: Contributing an extension

2019-01-29 Thread Gian Merlino
Hi Eyal, I'll take a look too. For some reason I missed this when you first posted it, but it is very interesting work, and looks like it could be part of a path to supporting generic windowed aggregations in Druid SQL. (Moving average, cumulative sum, and so on) On Tue, Jan 29, 2019 at 7:07 PM

Regarding the proposal for Consolidated segment metadata management

2019-01-29 Thread Jihoon Son
Hi all, I wrote a proposal for consolidated segment metadata management a few weeks ago. Since it's also a huge and incompatible change, I would like to get more attention from others. As described in the proposal, Druid currently stores segment metadata in two places: metadata store and deep

Re: Contributing an extension

2019-01-29 Thread Jihoon Son
Sorry for delayed review. I'll take a look once the 0.14.0 release is finished. Jihoon On Tue, Jan 29, 2019 at 3:58 PM Eyal Yurman wrote: > Hi, > > A few months ago I worked on open sourcing an extension we've been using > internally for a couple of years. > >

Contributing an extension

2019-01-29 Thread Eyal Yurman
Hi, A few months ago I worked on open sourcing an extension we've been using internally for a couple of years. https://github.com/apache/incubator-druid/pull/6430 https://github.com/apache/incubator-druid/issues/6320 This has been upvoted by a few community users, so I was happy to put in the

Re: Dev sync this week

2019-01-29 Thread Charles Allen
sorry, yes, that is the information I meant. that Feature Freeze is in its final stages On Tue, Jan 29, 2019 at 12:21 PM David Glasser wrote: > On Tue, Jan 29, 2019 at 10:45 AM Charles Allen > wrote: > >* *0.14 *release is in final stages, any blockers for 0.14 should be > called out to the

Re: Dev sync this week

2019-01-29 Thread David Glasser
On Tue, Jan 29, 2019 at 10:45 AM Charles Allen wrote: >* *0.14 *release is in final stages, any blockers for 0.14 should be called >out to the dev list. Can you clarify this? I don't think a 0.14 branch has been cut yet — things that land on master soon are likely to make it in, right? --dave

Re: The etiquette of pocking people on Github and the policy when people stop responding

2019-01-29 Thread Gian Merlino
> I disagree with Roman's suggestions. If a PR has enough votes, we should > trust the committers approving the PR and move forward. FWIW, I do think it's good to be courteous and give other reviewers a day or two to either follow up on a review or decide to leave the decision to the reviewers

Re: Proposal to shade Guava manually in Druid

2019-01-29 Thread Gian Merlino
Interesting proposal - I commented on the issue. It sounds like a good idea. On Tue, Jan 29, 2019 at 7:22 AM Roman Leventov wrote: > https://github.com/apache/incubator-druid/issues/6942 >

Proposal to shade Guava manually in Druid

2019-01-29 Thread Roman Leventov
https://github.com/apache/incubator-druid/issues/6942