That structure sounds good:
- expanding rejected alternatives to a broader rationale section sounds good
- I like "operational impact" as suggested by Slim and Gian more than the
corresponding KIP terminology
- Future work is a good addition
For test plan, I don't have a very strong opinion on
Thanks Gian.
The suggested template looks good to me.
Jihoon
On Thu, Jan 31, 2019 at 9:27 AM Gian Merlino wrote:
> If it's not clear - I am agreeing with Jihoon and Slim that a separate
> "Rationale" section makes sense in addition to a couple other suggested
> tweaks.
>
> On Wed, Jan 30, 2019
I’ve seen a similar problem in Calcite, which also uses forbiddenApis. It only
seems to occurs in a “bad build”; when you do “mvn clean” the problems
disappear.
My hypothesis is that the code is generated by javac, for example for the
messages from “assert”, or when concatenating string
Good question. I'm not sure. They are at least doing String.format on
_something_ with no default locale.
On Thu, Jan 31, 2019 at 9:36 AM Charles Allen
wrote:
> Is this indicative of latent bugs the generated sources have?
>
> On Thu, Jan 31, 2019 at 8:55 AM Gian Merlino wrote:
>
> > I get
Is this indicative of latent bugs the generated sources have?
On Thu, Jan 31, 2019 at 8:55 AM Gian Merlino wrote:
> I get those sometimes with generated sources -- typically doing a "mvn
> clean" beforehand clears it up. We might be able to add exclusions for the
> generated source directories
If it's not clear - I am agreeing with Jihoon and Slim that a separate
"Rationale" section makes sense in addition to a couple other suggested
tweaks.
On Wed, Jan 30, 2019 at 3:46 PM Gian Merlino wrote:
> I think it'd also be nice to tweak a couple parts of the KIP template
> (Motivation;
I get those sometimes with generated sources -- typically doing a "mvn
clean" beforehand clears it up. We might be able to add exclusions for the
generated source directories in order to avoid the need to do this.
On Thu, Jan 31, 2019 at 5:15 AM Furkan KAMACI
wrote:
> I try to run forbiddenapis
I try to run forbiddenapis plugin at Druid. However I get that errors but
does not know where they actually points:
[INFO] Scanning classes for violations...
[ERROR] Forbidden method invocation:
java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default
locale]
[ERROR] in
