Re: Error on Druid build from source

2019-06-13 Thread Jihoon Son
Hi Sandish, thank you for raising the PR. This test is supposed to finish really quickly. If it doesn't finish in timeout, I suspect something might go wrong with parallel segment loading. If this is the case, we should fix it rather than increasing timeout. I left the same comment in the PR too.

Re: Error on Druid build from source

2019-06-13 Thread Sandish Kumar HN
Gian, Created the pull request here https://github.com/apache/incubator-druid/pull/7890 On Thu, 13 Jun 2019 at 16:07, Gian Merlino wrote: > Please do, Sandish. Seems like a higher timeout would make the test more > robust. > > On Thu, Jun 13, 2019 at 6:57 PM Sandish Kumar HN > wrote: > > > Hi

Re: Error on Druid build from source

2019-06-13 Thread Gian Merlino
Please do, Sandish. Seems like a higher timeout would make the test more robust. On Thu, Jun 13, 2019 at 6:57 PM Sandish Kumar HN wrote: > Hi Jihoon, > > Thanks for all the help found below bugs. > > In SegmentManagerThreadSafetyTest file timeout rule is set to @Test(timeout > = 5000L), but

Re: Error on Druid build from source

2019-06-13 Thread Sandish Kumar HN
Hi Jihoon, Thanks for all the help found below bugs. In SegmentManagerThreadSafetyTest file timeout rule is set to @Test(timeout = 5000L), but tests were not able to finish tests(future been used) within 5000mills, increasing the timeout solved the whole problem, Looks like a bug? Shall I create

Re: Graduation

2019-06-13 Thread Gian Merlino
It is not (it'd have VOTE in the title if it was). But it looks like consensus is that we should do an official vote! I can start one in a bit if there are no objections. On Thu, Jun 13, 2019 at 2:18 PM Fangjin Yang wrote: > Is this thread an official vote? > > On Thu, Jun 13, 2019 at 11:05 AM

Re: Error on Druid build from source

2019-06-13 Thread Jihoon Son
Thanks Sandish, but it doesn't look that this thread dump shows anything related to Druid unit tests. I guess some more useful information is in the full thread dump, but unfortunately, it seems Apache email system doesn't like attached files. Do you see anything related to Druid unit tests in the

Re: Graduation

2019-06-13 Thread Fangjin Yang
Is this thread an official vote? On Thu, Jun 13, 2019 at 11:05 AM Jihoon Son wrote: > +1 > > On Thu, Jun 13, 2019 at 10:10 AM Nishant Bangarwa > wrote: > > > +1 > > > > On Thu, Jun 13, 2019 at 10:33 PM Charles Allen > wrote: > > > > > +1 > > > > > > > > > > > > On Fri, Jun 7, 2019, 9:27 PM

Re: Graduation

2019-06-13 Thread Jihoon Son
+1 On Thu, Jun 13, 2019 at 10:10 AM Nishant Bangarwa wrote: > +1 > > On Thu, Jun 13, 2019 at 10:33 PM Charles Allen wrote: > > > +1 > > > > > > > > On Fri, Jun 7, 2019, 9:27 PM Gian Merlino wrote: > > > > > Hey Druids, > > > > > > Druid has been in the incubator for a while, and we have done

Re: Graduation

2019-06-13 Thread Nishant Bangarwa
+1 On Thu, Jun 13, 2019 at 10:33 PM Charles Allen wrote: > +1 > > > > On Fri, Jun 7, 2019, 9:27 PM Gian Merlino wrote: > > > Hey Druids, > > > > Druid has been in the incubator for a while, and we have done 4 releases > so > > far (0.13.0, 0.14.0, 0.14.1, and 0.14.2) with a 5th on the way.

Re: Graduation

2019-06-13 Thread Charles Allen
+1 On Fri, Jun 7, 2019, 9:27 PM Gian Merlino wrote: > Hey Druids, > > Druid has been in the incubator for a while, and we have done 4 releases so > far (0.13.0, 0.14.0, 0.14.1, and 0.14.2) with a 5th on the way. There has > been some discussion off-list recently about pushing for graduation

Re: Graduation

2019-06-13 Thread Slim Bouguerra
+1 imo thanks for pushing this. On Thu, Jun 13, 2019 at 8:18 AM Abhishek Sharma wrote: > Hi All, > > +1, congrats. > > On Wed, Jun 12, 2019 at 11:01 PM 金嘉怡 wrote: > > > +1 Congratulations! > > > > On 2019/06/08 04:27:01, Gian Merlino wrote: > > > Hey Druids,> > > > > > > Druid has been in