[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201555396 ## File path:

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201555314 ## File path: services/src/main/java/io/druid/cli/CliPeon.java ## @@ -243,7 +242,7 @@ public

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201554378 ## File path: services/src/main/java/io/druid/cli/CliInternalHadoopIndexer.java ## @@ -150,7

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201398587 ## File path: services/src/main/java/io/druid/cli/CliCoordinator.java ## @@ -255,6 +255,6 @@

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201389804 ## File path: server/src/test/java/io/druid/initialization/InitializationTest.java ## @@ -454,8

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module

2018-07-10 Thread GitBox
asdf2014 commented on a change in pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201389385 ## File path: