Re: Contributing an extension

2019-01-29 Thread Jonathan Wei
Hi Eyal, Thanks for the contrib, I'll have some time to start reviewing in the next week or two. It seems like a cool feature with interest from users, so I'd lean towards keeping it open for review/merge. Best, Jon On Tue, Jan 29, 2019 at 5:29 PM Eyal Yurman wrote: > Hi, > > This pr is

Contributing an extension

2019-01-29 Thread Eyal Yurman
Hi, This pr is waiting for a few months for review: https://github.com/apache/incubator-druid/pull/6430 https://github.com/apache/incubator-druid/issues/6320 So far only one reviewer (@b-slim) was kind enough to start looking at it. Since this is an contrib extension, it is not really blocking

Re: Contributing an extension

2019-01-29 Thread Gian Merlino
Hi Eyal, I'll take a look too. For some reason I missed this when you first posted it, but it is very interesting work, and looks like it could be part of a path to supporting generic windowed aggregations in Druid SQL. (Moving average, cumulative sum, and so on) On Tue, Jan 29, 2019 at 7:07 PM

Re: Contributing an extension

2019-01-29 Thread Jihoon Son
Sorry for delayed review. I'll take a look once the 0.14.0 release is finished. Jihoon On Tue, Jan 29, 2019 at 3:58 PM Eyal Yurman wrote: > Hi, > > A few months ago I worked on open sourcing an extension we've been using > internally for a couple of years. > >

Contributing an extension

2019-01-29 Thread Eyal Yurman
Hi, A few months ago I worked on open sourcing an extension we've been using internally for a couple of years. https://github.com/apache/incubator-druid/pull/6430 https://github.com/apache/incubator-druid/issues/6320 This has been upvoted by a few community users, so I was happy to put in the