Re: Towards 0.13 (Apache release)

2018-09-19 Thread Gian Merlino
Hi all, The current list of issues for 0.13.0 is: https://github.com/apache/incubator-druid/milestone/25. In the interests of moving towards 0.13.0 soon, I suggest we should start moving things out to 0.13.1 unless they can be implemented and reviewed within the next week (or, unless they are

Re: Towards 0.13 (Apache release)

2018-09-03 Thread qiumingming . 2018
On 2018/08/29 23:09:41, Gian Merlino wrote: > I just raised https://github.com/apache/incubator-druid/pull/6266. I think > for sanity's sake, I would really appreciate it if we got this one merged > before merging any other PRs. (It will conflict with 100% of other PRs) > > On Wed, Aug 29,

Re: Towards 0.13 (Apache release)

2018-08-31 Thread eyal . yurman
Hi, my only issue that GitHub loses the commit history beyond the rename (i.e.: https://github.com/apache/incubator-druid/blob/master/server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java). Luckily it is viewable locally via "git log --follow" or with using your favorite SCM

Re: Towards 0.13 (Apache release)

2018-08-30 Thread Jihoon Son
It works for me. Thanks Gian. Best, Jihoon On Thu, Aug 30, 2018 at 11:36 AM Charles Allen wrote: > I just merged to one of the PRs I'm working on, and after upping the rename > limit to pretty high it was relatively painless > > On Thu, Aug 30, 2018 at 10:24 AM Slim Bouguerra > wrote: > > >

Re: Towards 0.13 (Apache release)

2018-08-30 Thread Charles Allen
I just merged to one of the PRs I'm working on, and after upping the rename limit to pretty high it was relatively painless On Thu, Aug 30, 2018 at 10:24 AM Slim Bouguerra wrote: > Thanks Gian worked for me! > > > On Aug 30, 2018, at 10:06 AM, Gian Merlino wrote: > > > > That PR is merged now!

Re: Towards 0.13 (Apache release)

2018-08-30 Thread Slim Bouguerra
Thanks Gian worked for me! > On Aug 30, 2018, at 10:06 AM, Gian Merlino wrote: > > That PR is merged now! If anyone here still has outstanding PRs that are > now in conflict with master, try running this before merging master, it > really helps git out. > > git config --local

Re: Towards 0.13 (Apache release)

2018-08-30 Thread Gian Merlino
That PR is merged now! If anyone here still has outstanding PRs that are now in conflict with master, try running this before merging master, it really helps git out. git config --local merge.renameLimit 5000 My experience was that even a patch with a few dozen changed files merged pretty

Re: Towards 0.13 (Apache release)

2018-08-29 Thread Gian Merlino
I just raised https://github.com/apache/incubator-druid/pull/6266. I think for sanity's sake, I would really appreciate it if we got this one merged before merging any other PRs. (It will conflict with 100% of other PRs) On Wed, Aug 29, 2018 at 9:34 AM Gian Merlino wrote: > Hi everyone, > > As