[GitHub] [druid] didip commented on a diff in pull request #12339: Make AWS WebIdentityToken actually working and usable from inside EKS.

2022-04-03 Thread GitBox
didip commented on code in PR #12339: URL: https://github.com/apache/druid/pull/12339#discussion_r841368133 ## extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSourceConfig.java: ## @@ -90,6 +91,24 @@ public boolean isCredentialsConfigured()

[GitHub] [druid] cryptoe commented on a diff in pull request #12339: Make AWS WebIdentityToken actually working and usable from inside EKS.

2022-04-03 Thread GitBox
cryptoe commented on code in PR #12339: URL: https://github.com/apache/druid/pull/12339#discussion_r841373219 ## extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSourceConfig.java: ## @@ -90,6 +91,24 @@ public boolean isCredentialsConfigured()

[GitHub] [druid] cryptoe commented on a diff in pull request #12339: Make AWS WebIdentityToken actually working and usable from inside EKS.

2022-04-03 Thread GitBox
cryptoe commented on code in PR #12339: URL: https://github.com/apache/druid/pull/12339#discussion_r841373558 ## cloud/aws-common/pom.xml: ## @@ -46,6 +46,10 @@ com.amazonaws aws-java-sdk-s3 + Review Comment: Which lib folder are y

[GitHub] [druid] cryptoe commented on a diff in pull request #12339: Make AWS WebIdentityToken actually working and usable from inside EKS.

2022-04-03 Thread GitBox
cryptoe commented on code in PR #12339: URL: https://github.com/apache/druid/pull/12339#discussion_r841385835 ## extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSource.java: ## @@ -166,15 +175,21 @@ private void applyAssumeRole( AWSCreden

[GitHub] MTShannon commented on issue #2788: Jackson 2.4.6 incompatible with HDP 2.4

2018-07-06 Thread GitBox
MTShannon commented on issue #2788: Jackson 2.4.6 incompatible with HDP 2.4 URL: https://github.com/apache/incubator-druid/issues/2788#issuecomment-403099742 @santhoshtangudu How did you stop passing multiple versions? This i

[GitHub] nishantmonu51 opened a new pull request #5958: Part 2 of changes for SQL Compatible Null Handling

2018-07-06 Thread GitBox
nishantmonu51 opened a new pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958 Part 2 of changes for SQL Compatible Null Handling - This PR contains changes to improve handling of null values in druid by treati

[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling

2018-07-06 Thread GitBox
nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-403121757 @leventov : Created a new PR, please review. This is

[GitHub] nishantmonu51 commented on issue #5452: SQL compatible Null Handling Part 2 - Processing Layer and Druid-SQL changes

2018-07-06 Thread GitBox
nishantmonu51 commented on issue #5452: SQL compatible Null Handling Part 2 - Processing Layer and Druid-SQL changes URL: https://github.com/apache/incubator-druid/pull/5452#issuecomment-403121854 Closing in favor of https://github.com/apache/incubator-druid/pull/5958 -

[GitHub] surekhasaharan opened a new pull request #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
surekhasaharan opened a new pull request #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931 Added limit param to `TimeseriesQuery` and support to limit results in `TimeseriesQueryQueryToolChest.mergeResults` and `TimeseriesQueryEngine

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403122325 LGTM, trying to re-run the checks (they lost track of what repo we were on)

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403133666 Saw this in travis, restarting. ```Failed tests: BlockingPoolTest.testConcurrentBatchClose:266 expected:<5> but was:<0>

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403134175 @surekhasaharan The TeamCity error looks legit. It's complaining that this method isn't used anymore: ``` public static Virt

[GitHub] surekhasaharan commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
surekhasaharan commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403140174 @gianm thanks for checking the TeamCity error. This is an au

[GitHub] gianm commented on issue #5941: [Backport] Fix missing task type in task payload API

2018-07-06 Thread GitBox
gianm commented on issue #5941: [Backport] Fix missing task type in task payload API URL: https://github.com/apache/incubator-druid/pull/5941#issuecomment-403142259 Errors in travis: ```Failed tests: BlockingPoolTest.testConcurrentBatchClose:303 BlockingPoolTest.testConcur

[GitHub] jihoonson commented on issue #5941: [Backport] Fix missing task type in task payload API

2018-07-06 Thread GitBox
jihoonson commented on issue #5941: [Backport] Fix missing task type in task payload API URL: https://github.com/apache/incubator-druid/pull/5941#issuecomment-403153636 @gianm it looks that the above failures come from another PR? The failed task in this PR was the below one, and I've fixe

[GitHub] jihoonson opened a new pull request #5959: Increase timeout for BlockingPoolTest

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5959: Increase timeout for BlockingPoolTest URL: https://github.com/apache/incubator-druid/pull/5959 Hope this fixes this Travis failure (https://github.com/apache/incubator-druid/pull/5931#issuecomment-403133666). /cc @gianm @surekhasaharan ---

[GitHub] jihoonson opened a new pull request #5960: add 'stopped' check and handling to HttpLoadQueuePeon load and drop segment methods

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5960: add 'stopped' check and handling to HttpLoadQueuePeon load and drop segment methods URL: https://github.com/apache/incubator-druid/pull/5960 Backport of # to 0.12.2. This is an a

[GitHub] jihoonson opened a new pull request #5961: [Backport] revert lambda conversion to fix occasional jvm error

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5961: [Backport] revert lambda conversion to fix occasional jvm error URL: https://github.com/apache/incubator-druid/pull/5961 Backport of https://github.com/apache/incubator-druid/pull/5591 to 0.12.2. ---

[GitHub] jihoonson opened a new pull request #5962: [Backport] Fix cache bug in stats module

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5962: [Backport] Fix cache bug in stats module URL: https://github.com/apache/incubator-druid/pull/5962 Backport of #5650 to 0.12.2. This is an automated message from the Apache Git Servic

[GitHub] jihoonson opened a new pull request #5963: [Backport] topN: Fix caching of Float dimension values

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5963: [Backport] topN: Fix caching of Float dimension values URL: https://github.com/apache/incubator-druid/pull/5963 Backport of #5653 to 0.12.2. This is an automated message from the Apa

[GitHub] jihoonson opened a new pull request #5964: [Backport] Allow GCS data segment killer to delete if present

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5964: [Backport] Allow GCS data segment killer to delete if present URL: https://github.com/apache/incubator-druid/pull/5964 Backport of #5675 to 0.12.2. This is an automated message from

[GitHub] jihoonson opened a new pull request #5965: [Backport] Fix topN lexicographic sort

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5965: [Backport] Fix topN lexicographic sort URL: https://github.com/apache/incubator-druid/pull/5965 Backport of #5815 to 0.12.2. This is an automated message from the Apache Git Service.

[GitHub] gianm closed pull request #5959: Increase timeout for BlockingPoolTest

2018-07-06 Thread GitBox
gianm closed pull request #5959: Increase timeout for BlockingPoolTest URL: https://github.com/apache/incubator-druid/pull/5959 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403171386 Got one of these too. ``` testBySegmentResultsWithAllFiltersWithExtractionFns[config=v2ParallelCombine, runner=rtIndex](io.dr

[GitHub] jihoonson commented on issue #5850: Fix Zip Slip vulnerability

2018-07-06 Thread GitBox
jihoonson commented on issue #5850: Fix Zip Slip vulnerability URL: https://github.com/apache/incubator-druid/pull/5850#issuecomment-403171377 Changed the milestone to 0.13.0 because https://github.com/apache/incubator-druid/pull/5421 is only in 0.13. --

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403171434 @surekhasaharan could you please merge in master again to this branch, so you get the benefit of #5959? Hopefully that should be enough

[GitHub] jihoonson opened a new pull request #5966: [Backport] Immediately send 401 on basic HTTP authentication failure

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5966: [Backport] Immediately send 401 on basic HTTP authentication failure URL: https://github.com/apache/incubator-druid/pull/5966 Backport of #5856 to 0.12.2. This is an automated messag

[GitHub] jihoonson opened a new pull request #5967: [Backport] Fix mismatch in revoked task locks between memory and metastore after sync from storage

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5967: [Backport] Fix mismatch in revoked task locks between memory and metastore after sync from storage URL: https://github.com/apache/incubator-druid/pull/5967 Backport of #5858 to 0.12.2. --

[GitHub] jihoonson opened a new pull request #5968: [Backport] HdfsDataSegmentPusher: Close tmpIndexFile before copying it.

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5968: [Backport] HdfsDataSegmentPusher: Close tmpIndexFile before copying it. URL: https://github.com/apache/incubator-druid/pull/5968 Backport of #5873 to 0.12.2. This is an automated mes

[GitHub] jihoonson opened a new pull request #5969: [Backport] Fix inefficient available segment cache population in SQLMetadataSegmentManager

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5969: [Backport] Fix inefficient available segment cache population in SQLMetadataSegmentManager URL: https://github.com/apache/incubator-druid/pull/5969 Backport of #5878 to 0.12.2. This

[GitHub] jihoonson opened a new pull request #5970: [Backport] Coordinator segment balancer max load queue fix

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5970: [Backport] Coordinator segment balancer max load queue fix URL: https://github.com/apache/incubator-druid/pull/5970 Backport of #5888 to 0.12.2. This is an automated message from the

[GitHub] jihoonson opened a new pull request #5971: [Backport] Fix Kafka Indexing task pause forever if no events in taskDuration

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5971: [Backport] Fix Kafka Indexing task pause forever if no events in taskDuration URL: https://github.com/apache/incubator-druid/pull/5971 Backport of #5899 to 0.12.2. This is an automat

[GitHub] jihoonson opened a new pull request #5972: [Backport] Prevent KafkaSupervisor NPE in generateSequenceName

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5972: [Backport] Prevent KafkaSupervisor NPE in generateSequenceName URL: https://github.com/apache/incubator-druid/pull/5972 Backport of #5902 to 0.12.2. This is an automated message fro

[GitHub] jihoonson opened a new pull request #5973: [Backport] Fix ConcurrentModificationException in IncrementalPublishingKafkaIndexTaskRunner

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5973: [Backport] Fix ConcurrentModificationException in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/5973 Backport of #5907 to 0.12.2. This

[GitHub] jihoonson opened a new pull request #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments URL: https://github.com/apache/incubator-druid/pull/5974 Backport of #5927 to 0.12.2. Thi

[GitHub] jihoonson opened a new pull request #5975: [Backport] Increase timeout for BlockingPoolTest

2018-07-06 Thread GitBox
jihoonson opened a new pull request #5975: [Backport] Increase timeout for BlockingPoolTest URL: https://github.com/apache/incubator-druid/pull/5975 Backport of #5959 to 0.12.2. This is an automated message from the Apache Gi

[GitHub] asdf2014 closed issue #5955: The annotation handler 'io.druid.annotations.SubclassesMustBePublicAnnotationProcessor' could not be found

2018-07-06 Thread GitBox
asdf2014 closed issue #5955: The annotation handler 'io.druid.annotations.SubclassesMustBePublicAnnotationProcessor' could not be found URL: https://github.com/apache/incubator-druid/issues/5955 This is an automated message

[GitHub] asdf2014 commented on issue #5955: The annotation handler 'io.druid.annotations.SubclassesMustBePublicAnnotationProcessor' could not be found

2018-07-06 Thread GitBox
asdf2014 commented on issue #5955: The annotation handler 'io.druid.annotations.SubclassesMustBePublicAnnotationProcessor' could not be found URL: https://github.com/apache/incubator-druid/issues/5955#issuecomment-403180664 I see. Thanks. -

[GitHub] gianm opened a new pull request #5976: Update license headers.

2018-07-06 Thread GitBox
gianm opened a new pull request #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976 For compliance with http://www.apache.org/legal/src-headers.html. This is an automated message from the Ap

[GitHub] gianm commented on issue #5976: Update license headers.

2018-07-06 Thread GitBox
gianm commented on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188239 Most of this diff is updating one set of boilerplate headers to another. Other than that, there are a few files in the extendset package that I want to ca

[GitHub] gianm commented on issue #5976: Update license headers.

2018-07-06 Thread GitBox
gianm commented on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188392 This is the earliest commit I can find for both of those files with no license headers. They both came from another repo that was copied into this one as

[GitHub] fjy commented on issue #5976: Update license headers.

2018-07-06 Thread GitBox
fjy commented on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188514 ConciseSetUtils is from the original ConciseSet library under the Apache license. The license header is missing for the file but it should be the same as th

[GitHub] gianm commented on issue #5976: Update license headers.

2018-07-06 Thread GitBox
gianm commented on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188534 @fjy Do you know if IntList is from the same place? This is an automated message from the

[GitHub] fjy commented on issue #5976: Update license headers.

2018-07-06 Thread GitBox
fjy commented on issue #5976: Update license headers. URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188549 @gianm Yes IntList is from the same place This is an automated message from the Apache Git S

[GitHub] leventov commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling

2018-07-07 Thread GitBox
leventov commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-403210759 @nishantmonu51 as far as I can see you didn't address all comments that I left in the last batch in the previous PR, please

[GitHub] jihoonson opened a new pull request #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests

2018-07-07 Thread GitBox
jihoonson opened a new pull request #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests URL: https://github.com/apache/incubator-druid/pull/5977 Backport of #5451 to 0.12.2. Looks like many travis jobs are failing because of lack of this patch. --

[GitHub] gianm commented on issue #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests

2018-07-07 Thread GitBox
gianm commented on issue #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests URL: https://github.com/apache/incubator-druid/pull/5977#issuecomment-403244694 You might want to backport #5959 too. This patch's tests failed because of that one. I restarted them both so

[GitHub] gianm opened a new pull request #5978: Extend various test timeouts.

2018-07-07 Thread GitBox
gianm opened a new pull request #5978: Extend various test timeouts. URL: https://github.com/apache/incubator-druid/pull/5978 False failures on Travis due to spurious timeout (in turn due to noisy neighbors) is a bigger problem than legitimate failures taking too long to time out. So i

[GitHub] jihoonson commented on issue #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests

2018-07-07 Thread GitBox
jihoonson commented on issue #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests URL: https://github.com/apache/incubator-druid/pull/5977#issuecomment-403248941 Thanks @gianm. This and https://github.com/apache/incubator-druid/pull/5975 needs each other to pass the

[GitHub] leventov commented on issue #5957: Various changes

2018-07-08 Thread GitBox
leventov commented on issue #5957: Various changes URL: https://github.com/apache/incubator-druid/pull/5957#issuecomment-403273302 @nishantmonu51 FYI I've tried to fix #5956 opportunistically in this PR, but a lot of tests started to fail. So I reverted. ---

[GitHub] erankor opened a new issue #5979: Kafka Indexing Service lagging every hour

2018-07-08 Thread GitBox
erankor opened a new issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979 Hi all, We're using the Kafka Indexing Service to ingest data to Druid (using version 0.10.0). Recently we're seeing it lag every hour - exactly at e

[GitHub] asdf2014 commented on a change in pull request #5957: Various changes

2018-07-08 Thread GitBox
asdf2014 commented on a change in pull request #5957: Various changes URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r200843245 ## File path: processing/src/main/java/io/druid/query/aggregation/JavaScriptAggregatorFactory.java ## @@ -353,6 +354,15 @@ p

[GitHub] asdf2014 commented on a change in pull request #5957: Various changes

2018-07-08 Thread GitBox
asdf2014 commented on a change in pull request #5957: Various changes URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r200844064 ## File path: processing/src/test/java/io/druid/collections/bitmap/BitmapBenchmark.java ## @@ -73,7 +73,7 @@ protected stati

[GitHub] asdf2014 commented on a change in pull request #5957: Various changes

2018-07-08 Thread GitBox
asdf2014 commented on a change in pull request #5957: Various changes URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r200844411 ## File path: processing/src/main/java/io/druid/collections/spatial/ImmutableRTree.java ## @@ -75,7 +74,7 @@ public static I

[GitHub] asdf2014 opened a new pull request #5980: Various changes about druid-services module

2018-07-09 Thread GitBox
asdf2014 opened a new pull request #5980: Various changes about druid-services module URL: https://github.com/apache/incubator-druid/pull/5980 Various changes about druid-services module: 1. Fix calling to `toArray()` with pre-sized array argument for better performance; 2. Use l

[GitHub] asdf2014 commented on issue #5957: Various changes

2018-07-09 Thread GitBox
asdf2014 commented on issue #5957: Various changes URL: https://github.com/apache/incubator-druid/pull/5957#issuecomment-403409063 Hi, @leventov . Already created a small PR [#5980](https://github.com/apache/incubator-druid/pull/5980) to supplement the current PR. If u think it's necessary

[GitHub] erankor commented on issue #5979: Kafka Indexing Service lagging every hour

2018-07-09 Thread GitBox
erankor commented on issue #5979: Kafka Indexing Service lagging every hour URL: https://github.com/apache/incubator-druid/issues/5979#issuecomment-403503558 The issue got much worse today :( reached 30-40 min lag during handoff. I tried to stop realtime ingestion completely but it didn't

[GitHub] gianm commented on issue #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests

2018-07-09 Thread GitBox
gianm commented on issue #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests URL: https://github.com/apache/incubator-druid/pull/5977#issuecomment-403529037 This one managed to pass CI after a couple restarts so I'll merge it. Please merge master into #5975 when you

[GitHub] gianm closed pull request #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests

2018-07-09 Thread GitBox
gianm closed pull request #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests URL: https://github.com/apache/incubator-druid/pull/5977 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[GitHub] gianm opened a new issue #5981: Coordinators spinning in balancer

2018-07-09 Thread GitBox
gianm opened a new issue #5981: Coordinators spinning in balancer URL: https://github.com/apache/incubator-druid/issues/5981 When rolling out the 0.12.2 branch to our test clusters, we noticed symptoms that suggest #5927 can hork up coordinators. They report a lot of time spent in these st

[GitHub] nishantmonu51 commented on a change in pull request #5452: SQL compatible Null Handling Part 2 - Processing Layer and Druid-SQL changes

2018-07-09 Thread GitBox
nishantmonu51 commented on a change in pull request #5452: SQL compatible Null Handling Part 2 - Processing Layer and Druid-SQL changes URL: https://github.com/apache/incubator-druid/pull/5452#discussion_r201070586 ## File path: processing/src/main/java/io/druid/query/aggregation/N

[GitHub] nishantmonu51 commented on a change in pull request #5452: SQL compatible Null Handling Part 2 - Processing Layer and Druid-SQL changes

2018-07-09 Thread GitBox
nishantmonu51 commented on a change in pull request #5452: SQL compatible Null Handling Part 2 - Processing Layer and Druid-SQL changes URL: https://github.com/apache/incubator-druid/pull/5452#discussion_r201070565 ## File path: processing/src/main/java/io/druid/query/aggregation/N

[GitHub] nishantmonu51 commented on a change in pull request #5452: SQL compatible Null Handling Part 2 - Processing Layer and Druid-SQL changes

2018-07-09 Thread GitBox
nishantmonu51 commented on a change in pull request #5452: SQL compatible Null Handling Part 2 - Processing Layer and Druid-SQL changes URL: https://github.com/apache/incubator-druid/pull/5452#discussion_r201070513 ## File path: processing/src/main/java/io/druid/query/aggregation/p

[GitHub] sf-mk opened a new issue #5982: "buckets" post aggregation of "approxHistogram" returns exception on Nan histograms

2018-07-09 Thread GitBox
sf-mk opened a new issue #5982: "buckets" post aggregation of "approxHistogram" returns exception on Nan histograms URL: https://github.com/apache/incubator-druid/issues/5982 Following documentation in: http://druid.io/docs/latest/development/extensions-core/approximate-histograms.html

[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling

2018-07-09 Thread GitBox
nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-403543885 @leventov: last batch of comments was re lines more than 120 cols, add line breaks and reformatted code. Also replied t

[GitHub] nishantmonu51 commented on issue #5957: Various changes

2018-07-09 Thread GitBox
nishantmonu51 commented on issue #5957: Various changes URL: https://github.com/apache/incubator-druid/pull/5957#issuecomment-403544988 @leventov : can we finish up the review and merge https://github.com/apache/incubator-druid/pull/5958 before making any more major refactorings ? --

[GitHub] jihoonson commented on issue #5981: Coordinators spinning in balancer

2018-07-09 Thread GitBox
jihoonson commented on issue #5981: Coordinators spinning in balancer URL: https://github.com/apache/incubator-druid/issues/5981#issuecomment-403562729 @gianm, fyi, https://github.com/apache/incubator-druid/pull/5974 (backport of https://github.com/apache/incubator-druid/pull/5927) hasn't

[GitHub] jihoonson closed pull request #5975: [Backport] Increase timeout for BlockingPoolTest

2018-07-09 Thread GitBox
jihoonson closed pull request #5975: [Backport] Increase timeout for BlockingPoolTest URL: https://github.com/apache/incubator-druid/pull/5975 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] jihoonson commented on issue #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests

2018-07-09 Thread GitBox
jihoonson commented on issue #5977: [Backport] Uniformly set Calcite systemProperties for All Unit tests URL: https://github.com/apache/incubator-druid/pull/5977#issuecomment-403563392 Merged #5975. Thanks. This is an automat

[GitHub] drcrallen commented on issue #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments

2018-07-09 Thread GitBox
drcrallen commented on issue #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments URL: https://github.com/apache/incubator-druid/pull/5974#issuecomment-403564663 oh noes, I don't have privileges to restart specific travis tests anymore ---

[GitHub] jihoonson commented on issue #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments

2018-07-09 Thread GitBox
committers have been added to the Apache Druid committers of Github. Did you set your Gitbox account? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] gianm closed pull request #5971: [Backport] Fix Kafka Indexing task pause forever if no events in taskDuration

2018-07-09 Thread GitBox
gianm closed pull request #5971: [Backport] Fix Kafka Indexing task pause forever if no events in taskDuration URL: https://github.com/apache/incubator-druid/pull/5971 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the s

[GitHub] gianm closed pull request #5970: [Backport] Coordinator segment balancer max load queue fix

2018-07-09 Thread GitBox
gianm closed pull request #5970: [Backport] Coordinator segment balancer max load queue fix URL: https://github.com/apache/incubator-druid/pull/5970 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] gianm closed pull request #5972: [Backport] Prevent KafkaSupervisor NPE in generateSequenceName

2018-07-09 Thread GitBox
gianm closed pull request #5972: [Backport] Prevent KafkaSupervisor NPE in generateSequenceName URL: https://github.com/apache/incubator-druid/pull/5972 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[GitHub] gianm closed pull request #5969: [Backport] Fix inefficient available segment cache population in SQLMetadataSegmentManager

2018-07-09 Thread GitBox
gianm closed pull request #5969: [Backport] Fix inefficient available segment cache population in SQLMetadataSegmentManager URL: https://github.com/apache/incubator-druid/pull/5969 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed be

[GitHub] gianm closed pull request #5967: [Backport] Fix mismatch in revoked task locks between memory and metastore after sync from storage

2018-07-09 Thread GitBox
gianm closed pull request #5967: [Backport] Fix mismatch in revoked task locks between memory and metastore after sync from storage URL: https://github.com/apache/incubator-druid/pull/5967 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is disp

[GitHub] gianm closed pull request #5964: [Backport] Allow GCS data segment killer to delete if present

2018-07-09 Thread GitBox
gianm closed pull request #5964: [Backport] Allow GCS data segment killer to delete if present URL: https://github.com/apache/incubator-druid/pull/5964 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] gianm closed pull request #5963: [Backport] topN: Fix caching of Float dimension values

2018-07-09 Thread GitBox
gianm closed pull request #5963: [Backport] topN: Fix caching of Float dimension values URL: https://github.com/apache/incubator-druid/pull/5963 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] gianm closed pull request #5962: [Backport] Fix cache bug in stats module

2018-07-09 Thread GitBox
gianm closed pull request #5962: [Backport] Fix cache bug in stats module URL: https://github.com/apache/incubator-druid/pull/5962 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] gianm closed pull request #5960: [Backport] add 'stopped' check and handling to HttpLoadQueuePeon load and drop segment methods

2018-07-09 Thread GitBox
gianm closed pull request #5960: [Backport] add 'stopped' check and handling to HttpLoadQueuePeon load and drop segment methods URL: https://github.com/apache/incubator-druid/pull/5960 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displaye

[GitHub] gianm closed pull request #5961: [Backport] revert lambda conversion to fix occasional jvm error

2018-07-09 Thread GitBox
gianm closed pull request #5961: [Backport] revert lambda conversion to fix occasional jvm error URL: https://github.com/apache/incubator-druid/pull/5961 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[GitHub] gianm closed pull request #5941: [Backport] Fix missing task type in task payload API

2018-07-09 Thread GitBox
gianm closed pull request #5941: [Backport] Fix missing task type in task payload API URL: https://github.com/apache/incubator-druid/pull/5941 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] gianm commented on issue #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments

2018-07-09 Thread GitBox
gianm commented on issue #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments URL: https://github.com/apache/incubator-druid/pull/5974#issuecomment-403574821 @drcrallen you should be able to if you go through GitBox setup: https

[GitHub] jihoonson commented on issue #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments

2018-07-09 Thread GitBox
jihoonson commented on issue #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments URL: https://github.com/apache/incubator-druid/pull/5974#issuecomment-403575599 I think it would be better to not backport this because it looks not having a hug

[GitHub] gianm closed pull request #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments

2018-07-09 Thread GitBox
gianm closed pull request #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments URL: https://github.com/apache/incubator-druid/pull/5974 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] gianm commented on issue #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments

2018-07-09 Thread GitBox
gianm commented on issue #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments URL: https://github.com/apache/incubator-druid/pull/5974#issuecomment-403586167 @jihoonson, that sounds good, let's move #5927 outside of 0.12.2. ---

[GitHub] gianm commented on issue #5927: Coordinator fix balance to try to move max segments instead of up to max segments

2018-07-09 Thread GitBox
gianm commented on issue #5927: Coordinator fix balance to try to move max segments instead of up to max segments URL: https://github.com/apache/incubator-druid/pull/5927#issuecomment-403586591 Moved out of 0.12.2 due to discussion on #5974 and #5981. --

[GitHub] gianm commented on issue #5981: Coordinators spinning in balancer

2018-07-09 Thread GitBox
gianm commented on issue #5981: Coordinators spinning in balancer URL: https://github.com/apache/incubator-druid/issues/5981#issuecomment-403586774 @jihoonson, got it. I moved all of these issues outside of 0.12.2 in that case. -

[GitHub] gianm commented on issue #5981: Coordinators spinning in balancer

2018-07-09 Thread GitBox
gianm commented on issue #5981: Coordinators spinning in balancer URL: https://github.com/apache/incubator-druid/issues/5981#issuecomment-403586857 This one will have to be fixed before 0.13.0 though since the bug exists in master. -

[GitHub] jihoonson closed pull request #5973: [Backport] Fix ConcurrentModificationException in IncrementalPublishingKafkaIndexTaskRunner

2018-07-09 Thread GitBox
jihoonson closed pull request #5973: [Backport] Fix ConcurrentModificationException in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/5973 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is display

[GitHub] jihoonson opened a new pull request #5983: [Backport] Fix the broken Appenderator contract in KafkaIndexTask

2018-07-09 Thread GitBox
jihoonson opened a new pull request #5983: [Backport] Fix the broken Appenderator contract in KafkaIndexTask URL: https://github.com/apache/incubator-druid/pull/5983 Backport of #5905 to 0.12.2. This is an automated message f

[GitHub] jihoonson opened a new pull request #5984: [Backport] Proper handling of the exceptions from auto persisting in AppenderatorImpl.add()

2018-07-09 Thread GitBox
jihoonson opened a new pull request #5984: [Backport] Proper handling of the exceptions from auto persisting in AppenderatorImpl.add() URL: https://github.com/apache/incubator-druid/pull/5984 Backport of #5932 to 0.12.2. This

[GitHub] jihoonson opened a new issue #5985: NPE in CuratorLoadQueuePeon

2018-07-09 Thread GitBox
jihoonson opened a new issue #5985: NPE in CuratorLoadQueuePeon URL: https://github.com/apache/incubator-druid/issues/5985 Introduced in https://github.com/apache/incubator-druid/pull/5929. ```2018-07-09T20:04:48,973 ERROR [main-EventThread] org.apache.curator.framework.imps.CuratorF

[GitHub] jihoonson commented on issue #5929: More coordinator logging to help give context to load queue peon log messages

2018-07-09 Thread GitBox
jihoonson commented on issue #5929: More coordinator logging to help give context to load queue peon log messages URL: https://github.com/apache/incubator-druid/pull/5929#issuecomment-403607718 Moving this outside of 0.12.2 because of https://github.com/apache/incubator-druid/issues/5985.

[GitHub] jihoonson opened a new pull request #5986: [Backport] Coordinator slight optimization of load rule runner to skip drop if numToDrop is 0

2018-07-09 Thread GitBox
jihoonson opened a new pull request #5986: [Backport] Coordinator slight optimization of load rule runner to skip drop if numToDrop is 0 URL: https://github.com/apache/incubator-druid/pull/5986 Backport of #5928 to 0.12.2. Th

[GitHub] jihoonson closed pull request #5966: [Backport] Immediately send 401 on basic HTTP authentication failure

2018-07-09 Thread GitBox
jihoonson closed pull request #5966: [Backport] Immediately send 401 on basic HTTP authentication failure URL: https://github.com/apache/incubator-druid/pull/5966 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[GitHub] jihoonson closed pull request #5968: [Backport] HdfsDataSegmentPusher: Close tmpIndexFile before copying it.

2018-07-09 Thread GitBox
jihoonson closed pull request #5968: [Backport] HdfsDataSegmentPusher: Close tmpIndexFile before copying it. URL: https://github.com/apache/incubator-druid/pull/5968 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sak

[GitHub] jihoonson closed pull request #5965: [Backport] Fix topN lexicographic sort

2018-07-09 Thread GitBox
jihoonson closed pull request #5965: [Backport] Fix topN lexicographic sort URL: https://github.com/apache/incubator-druid/pull/5965 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[GitHub] clintropolis opened a new pull request #5987: Coordinator fix balancer stuck

2018-07-09 Thread GitBox
clintropolis opened a new pull request #5987: Coordinator fix balancer stuck URL: https://github.com/apache/incubator-druid/pull/5987 This appears to happen when the balancer runs before the metadata manager polls the metadata database, resulting in the `if` statement inside of the `for` l

[GitHub] clintropolis opened a new pull request #5988: Coordinator fix exception caused by additional logging

2018-07-09 Thread GitBox
clintropolis opened a new pull request #5988: Coordinator fix exception caused by additional logging URL: https://github.com/apache/incubator-druid/pull/5988 #5929 added some additional log messages, one of them results in a null pointer exception of the form ``` 2018-07-09T20:0

  1   2   3   4   5   6   7   8   >