Re: [GitHub] iamybj commented on issue #1544: dubbo能否支持netty4?

2018-04-05 Thread Huxing Zhang
Can we block this idiot from leaving a comment? On Fri, Apr 6, 2018 at 1:21 PM, GitBox wrote: > iamybj commented on issue #1544: dubbo能否支持netty4? > URL: > https://github.com/apache/incubator-dubbo/issues/1544#issuecomment-379150649 > > >@zonghaishang

[GitHub] iamybj commented on issue #1544: dubbo能否支持netty4?

2018-04-05 Thread GitBox
iamybj commented on issue #1544: dubbo能否支持netty4? URL: https://github.com/apache/incubator-dubbo/issues/1544#issuecomment-379133346 dubbo还用netty啊,丢人。难道连自己写一个nio的通信层都不会吗?原来dubbo实际就没啥技术含量,就是把人家外国早就有的技术,拿过来封装组合一下而已。 netty只能说还可以,完全算不上说设计的好。

[GitHub] iamybj commented on issue #1012: Wanted: who's using dubbo

2018-04-05 Thread GitBox
iamybj commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379132892 傻逼,都是中国这些小鸡八公司用。大公司和外国没有一个用的。 开源,是把人家开源的东西拿过来用,同时贡献自己的代码。 而不是把人家的东西拿过来改改,说成是自己开发开源的。

[GitHub] codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-378873985 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr=h1) Report > Merging

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179554995 ## File path:

[GitHub] zonghaishang commented on issue #1385: Consumer annotation config actually unnecessary set basePackages for @DubboComponentScan

2018-04-05 Thread GitBox
zonghaishang commented on issue #1385: Consumer annotation config actually unnecessary set basePackages for @DubboComponentScan URL: https://github.com/apache/incubator-dubbo/issues/1385#issuecomment-379024786 @Sunshow consumer side @DubboComponentScan support set path to scan, see

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179503554 ## File path:

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179506773 ## File path:

[GitHub] zonghaishang closed issue #1517: ZookeeperRegistry query map too many times

2018-04-05 Thread GitBox
zonghaishang closed issue #1517: ZookeeperRegistry query map too many times URL: https://github.com/apache/incubator-dubbo/issues/1517 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] zonghaishang commented on issue #1517: ZookeeperRegistry query map too many times

2018-04-05 Thread GitBox
zonghaishang commented on issue #1517: ZookeeperRegistry query map too many times URL: https://github.com/apache/incubator-dubbo/issues/1517#issuecomment-378997330 Temporarily do not optimize this small point and deal with it at some point in the future, close it .

[GitHub] zonghaishang commented on issue #1489: consider changing the groupId to "org.apache.dubbo"

2018-04-05 Thread GitBox
zonghaishang commented on issue #1489: consider changing the groupId to "org.apache.dubbo" URL: https://github.com/apache/incubator-dubbo/issues/1489#issuecomment-378996862 Is there any plan to start doing? Maybe I can finish this job first?

[GitHub] zonghaishang commented on issue #1546: multiple registry centers or one registry center cluster?

2018-04-05 Thread GitBox
zonghaishang commented on issue #1546: multiple registry centers or one registry center cluster? URL: https://github.com/apache/incubator-dubbo/issues/1546#issuecomment-378994678 @deidei It is recommended to use the second scheme. 1. Can use zookeeper high availability

[GitHub] zonghaishang commented on issue #1258: compatible:compatible with dubbox

2018-04-05 Thread GitBox
zonghaishang commented on issue #1258: compatible:compatible with dubbox URL: https://github.com/apache/incubator-dubbo/pull/1258#issuecomment-378991918 @kimmking https://github.com/kimmking/dubbo, website is inaccessible. - @chickenlj I think the dubbox

[GitHub] zonghaishang commented on a change in pull request #1511: Add feature:require Reference service dynamically

2018-04-05 Thread GitBox
zonghaishang commented on a change in pull request #1511: Add feature:require Reference service dynamically URL: https://github.com/apache/incubator-dubbo/pull/1511#discussion_r179516001 ## File path:

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179506773 ## File path:

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179503554 ## File path:

[GitHub] kimmking commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
kimmking commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179500439 ## File path:

[GitHub] ralf0131 commented on issue #1555: replace vars by Constants.

2018-04-05 Thread GitBox
ralf0131 commented on issue #1555: replace vars by Constants. URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-378962045 The CI build is failed, please check it. This is an automated message from the

[GitHub] htynkn commented on issue #1513: [Suggestion] Add checkstyle for CI

2018-04-05 Thread GitBox
htynkn commented on issue #1513: [Suggestion] Add checkstyle for CI URL: https://github.com/apache/incubator-dubbo/issues/1513#issuecomment-378929197 I did a quick try. I only apply one basic rule. According to dubbo

[GitHub] bearDream opened a new pull request #1555: replace vars by Constants.

2018-04-05 Thread GitBox
bearDream opened a new pull request #1555: replace vars by Constants. URL: https://github.com/apache/incubator-dubbo/pull/1555 ## What is the purpose of the change don't direct use String. ## Brief changelog replace string by Constants ## Verifying this change

Re: [GitHub] CLAassistant commented on issue #884: 添加method class缓存

2018-04-05 Thread Wang Xin
Mark, Yes,the CLA assistant had been already removed . but this PR is a old one,it should be the last check result is recorded, and there is no way to refresh it. But I think it's not a big problem Xin Wang lovep...@hotmail.com 在 2018年4月5日,下午4:06,Mark

[GitHub] zonghaishang commented on issue #1552: How can I add a custom param(SPI) when zookeeperRegistry register url on zk

2018-04-05 Thread GitBox
zonghaishang commented on issue #1552: How can I add a custom param(SPI) when zookeeperRegistry register url on zk URL: https://github.com/apache/incubator-dubbo/issues/1552#issuecomment-378882053 you can see https://github.com/apache/incubator-dubbo/pull/1438 for more details.

[GitHub] codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-378873985 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug]

2018-04-05 Thread GitBox
codecov-io commented on issue #1550: [Dubbo-Fix EnableDubbo annotation bug] URL: https://github.com/apache/incubator-dubbo/pull/1550#issuecomment-378873985 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1550?src=pr=h1) Report > Merging

[GitHub] zonghaishang commented on issue #1549: @EnableDubbo annotation throw No bean named 'xxx' available error

2018-04-05 Thread GitBox
zonghaishang commented on issue #1549: @EnableDubbo annotation throw No bean named 'xxx' available error URL: https://github.com/apache/incubator-dubbo/issues/1549#issuecomment-378864530 ServiceAnnotationBeanPostProcessorTest : Using @reference inside the annotation configuration

Re: [GitHub] CLAassistant commented on issue #884: 添加method class缓存

2018-04-05 Thread Mark Thomas
I thought the CLA assistant had been removed. Mark On 05/04/2018 05:17, GitBox wrote: CLAassistant commented on issue #884: 添加method class缓存 URL: https://github.com/apache/incubator-dubbo/pull/884#issuecomment-345502043 [![CLA assistant