Re: A preformance issue And Optimizing RoundRobinLoadBalance

I made a simple review of your pr. 1. Unnecessary code moving. 2. Code style. 3. Using percent to calculate the result of select is unstable.

Re: A preformance issue And Optimizing RoundRobinLoadBalance

Hi lan, I try to submit a new PR to see whether it is useful (And restructure the code of its unit test). https://github.com/apache/incubator-dubbo/pull/2647 best regards, Jason > On Oct 16, 2018, at 16:18, Ian Luo wrote: > > Jason,

Re: A preformance issue And Optimizing RoundRobinLoadBalance

Jason, if you've had a pull request ready, or you are willing to work on it, why not :) Thanks, -Ian. On Tue, Oct 16, 2018 at 3:16 PM Jason Joo wrote: > Hi lan, > > I will update it. > > Should I submit a PR as proposal? > The implementation is just a little "longer" then before and we can't

Re: A preformance issue And Optimizing RoundRobinLoadBalance

Hi lan, I will update it. Should I submit a PR as proposal? The implementation is just a little "longer" then before and we can't have a real performance result in unit test because the mock's poor performance. best regards, Jason > On Oct 16, 2018, at 14:37, Ian Luo wrote: > > other

Re: ask for review on pull request 2640

That's awesome. I'll take a look at it. On Tue, Oct 16, 2018 at 2:43 PM Ian Luo wrote: > Hi folks, > > Recently I made a proposal on issue2570 [1] with the pull request [2]. > Unfortunately the original reporter failed to notice my response. I believe > the change made is the right direction,

ask for review on pull request 2640

Hi folks, Recently I made a proposal on issue2570 [1] with the pull request [2]. Unfortunately the original reporter failed to notice my response. I believe the change made is the right direction, and the pull request has already passed all checks. Is there anyone who's willing to take a look at

Re: Increase the schedule frequency of HeartbeatTask.

sounds great. On Tue, Oct 16, 2018 at 2:20 PM yuhang xiu wrote: > Hi, Ian! > > Not yet, I am starting this work. When I am done, I will send an email > immediately. > > Ian Luo 于2018年10月16日周二 下午2:15写道： > > > good proposal, we should definitely switch to HashWheelTimer to make the > > timer

Re: A preformance issue And Optimizing RoundRobinLoadBalance

I got your point, Jason, Would you mind to update your explanation on https://github.com/apache/incubator-dubbo/issues/2578? It is convenient for other people to revisit this issue later :) Thanks, -Ian. On Tue, Oct 16, 2018 at 2:25 PM Jason Joo wrote: > Hi, lan > > I gave a sample from Nginx®

Re: A preformance issue And Optimizing RoundRobinLoadBalance

Hi, lan I gave a sample from Nginx® Code in JAVA and gained better performance compared to previous one(in that issue reply list). Junlan's point is not to shuffle the addresses list and to select a different node every time as possible, eg: A:B:C = 1:2:3 [A, B, C, B, C, C, A, B, C, B,

Re: Increase the schedule frequency of HeartbeatTask.

Hi, Ian! Not yet, I am starting this work. When I am done, I will send an email immediately. Ian Luo 于2018年10月16日周二 下午2:15写道： > good proposal, we should definitely switch to HashWheelTimer to make the > timer execute in more fair/timely manner. > > Is there any pull request ready for review? >

Re: Refactoring of classes related to model

pls. send out pull request on mailing list when it's ready. On Wed, Oct 10, 2018 at 9:22 PM RQ wrote: > Hi Community, > > I would like to refactor those classes based on supporting HSF which is > used mostly @alibaba innerly and mostly for good design of model reusing. > > The refacttoring will

Re: New module for serialization test

awesome, now we have higher code coverage. Thank you guys :) -Ian. On Mon, Oct 15, 2018 at 11:31 AM yuhang xiu wrote: > Hi, all > After @Yunkun Huang's pr[1], the current UT coverage is correct, please > review pr[2] again. > Thx for @Yunkun Huang and @Xin Wang's help for UT coverage. > > [1]

Re: Increase the schedule frequency of HeartbeatTask.

good proposal, we should definitely switch to HashWheelTimer to make the timer execute in more fair/timely manner. Is there any pull request ready for review? Thanks, -Ian. On Thu, Oct 11, 2018 at 10:41 AM yuhang xiu wrote: > Hi, community > > I recently saw an issue[1] from @chickenlj about

Re: A preformance issue And Optimizing RoundRobinLoadBalance

Hi Junlan, Are you suggesting we should shuffle the result address array? Thanks, -Ian. On Fri, Oct 12, 2018 at 4:24 PM Junlan Shuai wrote: > Hi, > The RoundRobinLoadBalance Algorithm is not smoothing. > For example, assuming that the weight of Server A is five, the weight of > Server > B is

Re: A little thought about the offline meetup

good point and good summary. Let's build community together by initing more topics/discussion in mailing list. Live long and prosper :) -Ian. On Tue, Oct 16, 2018 at 11:04 AM Jerrick Zhu wrote: > Greet. This is "Community Over Code". > > BTW, English followed Chinese is welcome. > > On Tue,