Hi,
On Thu, Mar 21, 2019 at 11:20 AM Ian Luo wrote:
>
> It seems unnecessary since GitHub does this for this. You can open any pull
> request and will notice GitHub has nicely done this for us.
As I stated before:
- Not everyone can see it, only committers can see it. You can try it
by opening
Hi,
> These dependencies are all development time dependencies, which can be
> found in "devDependencies" section of package.json file.
Anyone who compiles the source will get these and be unaware of them, that
seems a little problamatic to me.
> For node-notifier, which is also a dev
Hi,
On Thu, Mar 21, 2019 at 11:29 AM Justin Mclean wrote:
>
> Hi,
>
> Also this in [1] is not a good idea. The date needs to the the date of
> release not the current date.
> " Copyright {{ new
> Date().getFullYear() }} The Apache Software
> Foundation.”
Agree, it should be static number
Hi Justin,
On Thu, Mar 21, 2019 at 11:02 AM Justin Mclean wrote:
>
> Hi,
>
> -1 (binding) as this release seems to includes a GPL (a category X)
> dependancy. [3]
>
> After compiling I also noticed it pulls down material that is under copyright
> and I don’t believe we have permission to
Hi,
Also this in [1] is not a good idea. The date needs to the the date of release
not the current date.
" Copyright {{ new
Date().getFullYear() }} The Apache Software Foundation.”
I believe this has come up before on this list?
Thanks,
Justin
1.
It seems unnecessary since GitHub does this for this. You can open any pull
request and will notice GitHub has nicely done this for us.
Thanks,
-Ian.
On Thu, Mar 21, 2019 at 10:03 AM Huxing Zhang wrote:
> Hi,
>
> I am thinking of applying a label called "first-time-contributor" to
> those who
+1 to release
I checked:
* both source and binary signatures are good
* both have incubating in name
* DISCLAIMER, LICENSE and NOTICE exists
* All UTs can pass on my Mac OSX with JDK 1.8
* I deployed the Admin locally and checked some pages opening them in browser,
work fine.
Jun
> On Mar 19,
Hi,
-1 (binding) as this release seems to includes a GPL (a category X) dependancy.
[3]
After compiling I also noticed it pulls down material that is under copyright
and I don’t believe we have permission to distribute [1][2]
Re copyright of that text:
"In Praise of Idleness and Other Essays
Hi,
+1 (binding)
I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER exits
- LICENSE and NOTICE file
- Source file have ASF headers. There are a few xml files and shell scripts
that are missing ASF headers.
- No unexpected final files in the source release
- Can
Hi,
I am thinking of applying a label called "first-time-contributor" to
those who send pull request first time. The purpose is to better
identify those people and hope the community would act more quickly to
those pull request in order to help them getting merged.
Currently only those who had
+1 to release
I checked:
* both source and binary signatures are good
* both have incubating in name
* DISCLAIMER, LICENSE and NOTICE exists
* all source files no binary
* ASF file header check passed with: mvn clean compile -Drat.skip=false
-Dcheckstyle.skip=false
* All UTs can pass on my Mac
Hi,
On Wed, Mar 20, 2019 at 6:08 PM Mark Thomas wrote:
>
> I recommend that you enforce this socially rather than technically.
>
> There are times when a committer needs to get something committed (CI is
> broken, security fix, correct an obvious bug that is blocking something
> else, etc.) and
[x ] 2019-9-15 (half year later)
I also suggest there should have a rule for end of life time amd include
them in roadmap.
End of life message should earlier share via blog, twitter and email to
user to let them have time to update version.
在 2019年3月19日星期二，victory 写道：
> [x ] 2019-9-15 (half
Hi,
I vote with: +1 release the software
I also checked LICENSE and NOTICE file in the binary distribution with
bin-distribution-check.sh and all look good.
Are release files in correct location? Yes
Do release files have the word incubating in their name? Yes
Are the digital signature
agree. I think this is a very good way to help us standardize the pr merge.
YunKun Huang 于2019年3月20日周三 上午11:41写道：
> Agree, we should have at least one approval before merging
>
> On 2019/03/20 03:00:51, Huxing Zhang wrote:
> > Hi,
> >
> >
> > On Wed, Mar 20, 2019 at 10:55 AM YunKun Huang
>
15 matches
Mail list logo
