Re: [External]Re: Propose to use robot to generate weekly report of Dubbo

2019-01-07 Thread ss
This looks really promising! Looking forward to more updates! On 07/01/2019, 16:52, "赵生宇" wrote: >Hi, > > >For pull request review, actually GitHub provides API to get the review data, >see: >https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request >, so the review

Re: 咨询一个dubbo本地工具是否已经存在

2018-08-28 Thread ss
This is a nice feature! Look forward to your contribution! On 28/08/2018, 13:29, "Huxing Zhang" wrote: >Hi, > >Welcome to Dubbo community! > >Please consider using English first, and with Chinese followed if you >preferred. The Dubbo community is a global community. >On Tue, Aug 28, 2018 at

Re: How to package dubbo.jar correctly?

2018-05-09 Thread ss
cky one, that’s also one of the reasons that we changed the pom structure of dubbo project in 2.6.x. As mentioned above, use 'mvn clean install -DskipTests=true’ directly, and ignore the 'dubbo-maven/pom.xml’, a pom file only works for central maven repository. On 8 May 2018, at 10:44 AM, ss宋顺 &

How to package dubbo.jar correctly?

2018-05-07 Thread ss
Hi there, I have a patch that needs to be applied to our organization first. So I use the normal way - 'mvn clean install -DskipTests=true' to package the dubbo.jar (based on branch 2.5.x). However, the pom file for the generated artifact is

Re: [alibaba/dubbo] [BUG][2.5.10] Implementation-Version is incorrect (#1466)

2018-03-14 Thread ss
Hi Jun, We have integrated dubbo with our tracing system, which will include dubbo version in each rpc call event. The version information is one of the key diagnosis information when some service meets something wrong. So yes, this change does have some side effects. Not on my project but on