Re: Optimize retry in failbackregistry.

2018-11-11 Thread yuhang xiu
Hi, @yiji @beiwei I have watched your review. Very good advice! Thank u for your review. I have fixed and optimized my PR, please continue to deal with it. Ian Luo 于2018年11月10日周六 下午7:25写道: > Yuhang, I also dropped my comments on this pull request. > > Thanks, > -Ian. > > On Sat, Nov 10, 2018

Re: Optimize retry in failbackregistry.

2018-11-10 Thread Ian Luo
Yuhang, I also dropped my comments on this pull request. Thanks, -Ian. On Sat, Nov 10, 2018 at 11:07 AM Zonghai Shang wrote: > Hi, > > Sorry, correct my spelling mistakes `HashWhell`, it should > be`HashedWheelTimer`. > > -yiji > > Zonghai Shang 于2018年11月10日周六 上午11:05写道: > > > Hi, > > > > I

Re: Optimize retry in failbackregistry.

2018-11-09 Thread Zonghai Shang
Hi, Sorry, correct my spelling mistakes `HashWhell`, it should be`HashedWheelTimer`. -yiji Zonghai Shang 于2018年11月10日周六 上午11:05写道: > Hi, > > I think the `HashWhell` feature is very good. I read pr carefully and left > some suggestions, please take a look. > > -yiji > > yuhang xiu

Re: Optimize retry in failbackregistry.

2018-11-08 Thread yuhang xiu
Hi, community I submitted a version of pr[1] to optimize retry, which has now passed CI detection. In the new version, all retries will follow RETRY_PERIOD. All tasks will be done independently, for ex: retry registry operations will not affect retry unregistry.

Optimize retry in failbackregistry.

2018-11-07 Thread yuhang xiu
Hi, community Recently I will begin to optimize the retry process of FailbackRegistry. Currently our retry will start executing when the FailbackRegistry starts. We can completely retry it more regularly. At present, we have five collections that need to be checked regularly. Why not check