Re: Telnet optimization suggest

this pull request gets larger than I expected, in order to solve cycle dependency from unit test in config-api. Pls. review and give me your feedback. Thanks, -Ian. On Wed, Dec 19, 2018 at 3:53 PM 李振 wrote: > Great ! It's better than my pr， I have closed my pr。 > > Ian Luo 于2018年12月19日周三

Re: Telnet optimization suggest

Great ! It's better than my pr， I have closed my pr。 Ian Luo 于2018年12月19日周三 下午1:48写道： > I am working on it. Hopefully I can share my pull request for review soon. > > -Ian. > > On Tue, Dec 18, 2018 at 6:32 PM 李振 wrote: > > > I find that exporter's key(group/interface:version:port , maybe

Re: Telnet optimization suggest

Folks, I submitted pull request 3013 [1] to address the issue 2988 [2]. Can someone take a look and give me your feedback here or on GitHub? Thanks, -Ian. 1. https://github.com/apache/incubator-dubbo/pull/3013 2. https://github.com/apache/incubator-dubbo/issues/2988 On Wed, Dec 19, 2018 at

Re: Telnet optimization suggest

I am working on it. Hopefully I can share my pull request for review soon. -Ian. On Tue, Dec 18, 2018 at 6:32 PM 李振 wrote: > I find that exporter's key(group/interface:version:port , maybe port is > superfluous ) will be the best choice > < >

Re: Telnet optimization suggest

I find that exporter's key(group/interface:version:port , maybe port is superfluous ) will be the best choice . yeling 于2018年12月18日周二 下午6:22写道： > I

Re: Telnet optimization suggest

I think it's a good idea. 李振 于2018年12月18日周二 下午6:13写道： > dubbo>ls > demoA:org.apache.dubbo.demo.DemoService:1.0.0 > demoB:org.apache.dubbo.demo.DemoService:1.0.0 > > How about this.group:interface:version ， this coordinate help us find > the unique exporter like maven。 > > Jason Joo

Re: Telnet optimization suggest

dubbo>ls demoA:org.apache.dubbo.demo.DemoService:1.0.0 demoB:org.apache.dubbo.demo.DemoService:1.0.0 How about this.group:interface:version ， this coordinate help us find the unique exporter like maven。 Jason Joo 于2018年12月18日周二 下午1:55写道： > And is there other situations to deal with?

Re: Telnet optimization suggest

And is there other situations to deal with? group/version/etc... For now there is only different implementations in same application and looks good to deal with. best regards, Jason > On Dec 18, 2018, at 10:33, yeling wrote: > > Ok,I've created an issue. >

Re: Telnet optimization suggest

Ok,I've created an issue. https://github.com/apache/incubator-dubbo/issues/2988 Ian Luo 于2018年12月17日周一 下午11:41写道： > Zhen, > > > > 1. When my interface implements multiple services, and all of them are > > exposed, using the Dubbo parameter group, at this time, under the telnet > > command, I

Re: Telnet optimization suggest

Zhen, > 1. When my interface implements multiple services, and all of them are > exposed, using the Dubbo parameter group, at this time, under the telnet > command, I can not choose the service I want to invoke. I am afraid I fully understand the problem. Could you pls. file an issue on GitHub

Re: Telnet optimization suggest

Hi Zhen, For this particular override issue, I believe it's already been addressed. Would you mind to pull the latest code from the master branch and give it a try? Thanks, -Ian. On Mon, Dec 17, 2018 at 8:52 PM yuhang xiu wrote: > Welcome! > > Do u have some ideas about telnet? > > IMO, this

Re: Telnet optimization suggest

Welcome! Do u have some ideas about telnet? IMO, this way is very good: list: [1] listUser(Integer id) [2] listUser(String name) When we use invoke, we can do like this: invoke 1 params There has a line number or id or sth else with one invokable method. This can make this clear. 李振

Re: Telnet optimization suggest

> > I will try to fix it。

Re: Telnet optimization suggest

Hi, about overloading, here is an issue to track: https://github.com/apache/incubator-dubbo/issues/2766 Regarding the group problem, it is currently impossible to execute a service under a specific group. This is a point that can be optimized. Would u have some ideas? yeling 于2018年12月17日周一