[GitHub] zeng54088 commented on issue #98: how to configure multiple protocols

zeng54088 commented on issue #98: how to configure multiple protocols URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/98#issuecomment-378807284 @SpringBootApplication @EnableDubboConfig(multiple = true) public class DubboProviderDemo { public static

[GitHub] htynkn commented on issue #1509: add unit test for remoting module

htynkn commented on issue #1509: add unit test for remoting module URL: https://github.com/apache/incubator-dubbo/pull/1509#issuecomment-378798551 @lovepoem Done. Thanks :) This is an automated message from the Apache Git

[GitHub] codecov-io commented on issue #1509: add unit test for remoting module

codecov-io commented on issue #1509: add unit test for remoting module URL: https://github.com/apache/incubator-dubbo/pull/1509#issuecomment-376053743 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr=h1) Report > Merging

[GitHub] ralf0131 commented on issue #10: update readme

ralf0131 commented on issue #10: update readme URL: https://github.com/apache/incubator-dubbo-website/pull/10#issuecomment-378544726 Hi, the default branch has been changed to asf-site, please send pull request against asf-site.

[GitHub] xionghuiCoder commented on issue #10: update readme

xionghuiCoder commented on issue #10: update readme URL: https://github.com/apache/incubator-dubbo-website/pull/10#issuecomment-378544184 ok This is an automated message from the Apache Git Service. To respond to the

[GitHub] beiwei30 opened a new pull request #1554: manually merge the work made by pull request #1491 on master branch

beiwei30 opened a new pull request #1554: manually merge the work made by pull request #1491 on master branch URL: https://github.com/apache/incubator-dubbo/pull/1554 ## What is the purpose of the change Update pom for into apache incubator, partial fix for this issue:

[GitHub] codecov-io commented on issue #1554: manually merge the work made by pull request #1491 on master branch

codecov-io commented on issue #1554: manually merge the work made by pull request #1491 on master branch URL: https://github.com/apache/incubator-dubbo/pull/1554#issuecomment-378566031 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1554?src=pr=h1) Report > Merging

[GitHub] nzomkxia commented on issue #10: update readme

nzomkxia commented on issue #10: update readme URL: https://github.com/apache/incubator-dubbo-website/pull/10#issuecomment-378562892 the readme in asf-site branch has already been updated This is an automated message from

[GitHub] lovepoem commented on issue #1387: [dubbo-cache] A method level cache implementation for dubbo.

lovepoem commented on issue #1387: [dubbo-cache] A method level cache implementation for dubbo. URL: https://github.com/apache/incubator-dubbo/pull/1387#issuecomment-378814756 @skykong1981 sky Please Please describe the role of your PR in more detailin “What is the purpose of the

[GitHub] zeng54088 opened a new issue #99: How to Generic reference

zeng54088 opened a new issue #99: How to Generic reference URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/99 DubboConfiguration @Configuration public class DubboConfiguration { @Bean public ReferenceBean referenceBean(){

[GitHub] CLAassistant commented on issue #884: 添加method class缓存

CLAassistant commented on issue #884: 添加method class缓存 URL: https://github.com/apache/incubator-dubbo/pull/884#issuecomment-345502043 [](https://cla-assistant.io/apache/incubator-dubbo?pullRequest=884) Thank you for

[GitHub] lovepoem closed pull request #1509: add unit test for remoting module

lovepoem closed pull request #1509: add unit test for remoting module URL: https://github.com/apache/incubator-dubbo/pull/1509 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] lovepoem commented on issue #1387: [dubbo-cache] A method level cache implementation for dubbo.

lovepoem commented on issue #1387: [dubbo-cache] A method level cache implementation for dubbo. URL: https://github.com/apache/incubator-dubbo/pull/1387#issuecomment-378814756 @skykong1981 sky ， please describe the “What is the purpose of the change” of your PR in more detail 。 It

[GitHub] liketic commented on a change in pull request #1388: Remove unnecessary StringBuilder

liketic commented on a change in pull request #1388: Remove unnecessary StringBuilder URL: https://github.com/apache/incubator-dubbo/pull/1388#discussion_r179162214 ## File path: dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java ## @@

[GitHub] liketic commented on a change in pull request #1378: Simplify string concatenation in log

liketic commented on a change in pull request #1378: Simplify string concatenation in log URL: https://github.com/apache/incubator-dubbo/pull/1378#discussion_r179164620 ## File path:

[GitHub] deif2005 commented on issue #1542: 无法注册至zookeeper

deif2005 commented on issue #1542: 无法注册至zookeeper URL: https://github.com/apache/incubator-dubbo/issues/1542#issuecomment-378495081 问题的原因找到了，由于项目之前在其它模块使用了curator的包，版本号是3.1.0，引用了该模块后导致了无法创建节点的问题，现在使用了2.7.1，现在一切都正常了。谢谢！ This

[GitHub] ralf0131 closed pull request #1551: update readme

ralf0131 closed pull request #1551: update readme URL: https://github.com/apache/incubator-dubbo/pull/1551 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] ralf0131 commented on issue #1551: update readme

ralf0131 commented on issue #1551: update readme URL: https://github.com/apache/incubator-dubbo/pull/1551#issuecomment-378495330 Looks good to me! Thanks for the pull request! This is an automated message from the Apache Git

[GitHub] beiwei30 commented on issue #1388: Remove unnecessary StringBuilder

beiwei30 commented on issue #1388: Remove unnecessary StringBuilder URL: https://github.com/apache/incubator-dubbo/pull/1388#issuecomment-378506087 I agree to use string concat instead of string builder since it will improve code readability. For performance concern, we should trust

[GitHub] diecui1202 commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

diecui1202 commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179059689 ## File path:

[GitHub] beiwei30 commented on issue #1400: Fix typo for remoting module

beiwei30 commented on issue #1400: Fix typo for remoting module URL: https://github.com/apache/incubator-dubbo/pull/1400#issuecomment-378502329 great job, thanks for your contribution. This is an automated message from the

[GitHub] leyou240 opened a new pull request #1553: add missing @Override to classes

leyou240 opened a new pull request #1553: add missing @Override to classes URL: https://github.com/apache/incubator-dubbo/pull/1553 ## What is the purpose of the change add missing @Override to classes ## Brief changelog XX ## Verifying this change

[GitHub] beiwei30 commented on a change in pull request #1388: Remove unnecessary StringBuilder

beiwei30 commented on a change in pull request #1388: Remove unnecessary StringBuilder URL: https://github.com/apache/incubator-dubbo/pull/1388#discussion_r179045903 ## File path: dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java ## @@

[GitHub] diecui1202 commented on issue #1504: [Suggestion] What about migrating from Javassist to Byte Buddy

diecui1202 commented on issue #1504: [Suggestion] What about migrating from Javassist to Byte Buddy URL: https://github.com/apache/incubator-dubbo/issues/1504#issuecomment-378538263 Since the discussion has transmitted to the dev mail list, so this issue can be closed. @chickenlj

[GitHub] beiwei30 commented on a change in pull request #1378: Simplify string concatenation in log

beiwei30 commented on a change in pull request #1378: Simplify string concatenation in log URL: https://github.com/apache/incubator-dubbo/pull/1378#discussion_r179045726 ## File path:

[GitHub] codecov-io commented on issue #1553: add missing @Override to classes

codecov-io commented on issue #1553: add missing @Override to classes URL: https://github.com/apache/incubator-dubbo/pull/1553#issuecomment-378527493 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1553?src=pr=h1) Report > Merging

[GitHub] nzomkxia commented on issue #1509: add unit test for remoting module

nzomkxia commented on issue #1509: add unit test for remoting module URL: https://github.com/apache/incubator-dubbo/pull/1509#issuecomment-378543386 all added tests are passed This is an automated message from the Apache Git

[GitHub] htynkn commented on issue #1544: dubbo能否支持netty4?

htynkn commented on issue #1544: dubbo能否支持netty4? URL: https://github.com/apache/incubator-dubbo/issues/1544#issuecomment-378510446 @yosaku01 https://github.com/apache/incubator-dubbo/tree/master/dubbo-remoting/dubbo-remoting-netty4

[GitHub] beiwei30 closed pull request #1400: Fix typo for remoting module

beiwei30 closed pull request #1400: Fix typo for remoting module URL: https://github.com/apache/incubator-dubbo/pull/1400 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull