Hi,
> Unless we know where that other file come from [1] I would still be -1.
Looks fine for that file. What about the other 3rd party files/files without
headers?I think someone needs to go through the files and check that all files
have the correct headers.
Thanks,
Justin
Hi,
> If it is legally fine (I think it is perfectly allowed)
That is not the case at the ASF, we also have ASF policy and the Apache Way
which override and go beyond what is just legal. This situation in unfortunate
but continue the best you can.
> What we could change in the future is
> we
>
> Looks fine for that file. What about the other 3rd party files/files
> without headers?I think someone needs to go through the files and check
> that all files have the correct headers.
Will go through all files completely before next vote.
-Ian.
On Mon, Mar 23, 2020 at 2:39 PM Justin
Hi,
thanks Justin for the correction.
I cancel the vote for RC1 for some files missing license header.
On Mon, Mar 23, 2020 at 8:51 AM Justin Mclean
wrote:
> Hi,
>
> > We’ve received one -1 binding vote from Justin Mclean for there's some
> > license issue.
>
> To be clear a -1 is not a veto,
Hi,
> Very good question, we are trying to contact the original author for the
> same question.
It may be they come some other company repo going by headers here [1] but I
cannot find the exact file, perhaps it’s an internal repo? It odd these files
have that header.
Thanks,
Justin
1.
Justin,
Sorry for that, those classes were written by me since 2.7.6 because
I make a mistake using the wrong template code with the different headers.
I have refactored those classes with the right license headers.
Kind regards,
Mercy
On Mon, Mar 23, 2020 at 11:58 AM Ian Luo wrote:
>
>
> Sure, I can help to check the Licenses.
I think the same as Ian, it can be verified from the commit history, I can
help to find all the other files with the same issue before starting the
next vote.
On Mon, Mar 23, 2020 at 11:44 AM Ian Luo wrote:
> Justin,
>
> Unless we know where that other file come from [1] I would still be -1.
>
