[GitHub] [dubbo-go] AlexStocks commented on issue #486: merge 1.4 to develop

2020-04-20 Thread GitBox
AlexStocks commented on issue #486: URL: https://github.com/apache/dubbo-go/pull/486#issuecomment-616364496 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [dubbo-go] wongoo opened a new pull request #485: merge v1.4.0 to develop

2020-04-20 Thread GitBox
wongoo opened a new pull request #485: URL: https://github.com/apache/dubbo-go/pull/485 **What this PR does**: merge v1.4.0 to develop This is an automated message from the Apache Git Service. To respond to the

[GitHub] [dubbo-go] wongoo opened a new pull request #486: merge 1.4 to develop

2020-04-20 Thread GitBox
wongoo opened a new pull request #486: URL: https://github.com/apache/dubbo-go/pull/486 **What this PR does**: merge 1.4 to develop This is an automated message from the Apache Git Service. To respond to the

[GitHub] [dubbo-go] wongoo commented on issue #486: merge 1.4 to develop

2020-04-20 Thread GitBox
wongoo commented on issue #486: URL: https://github.com/apache/dubbo-go/pull/486#issuecomment-616341772 > why not change those files whose license header is wrong? because these files already have updated in develop branch

[GitHub] [dubbo-go] wongoo edited a comment on issue #486: merge 1.4 to develop

2020-04-20 Thread GitBox
wongoo edited a comment on issue #486: URL: https://github.com/apache/dubbo-go/pull/486#issuecomment-616341772 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [dubbo-go] AlexStocks commented on issue #486: merge 1.4 to develop

2020-04-20 Thread GitBox
AlexStocks commented on issue #486: URL: https://github.com/apache/dubbo-go/pull/486#issuecomment-616340581 why not change those files whose license header is wrong? This is an automated message from the Apache Git Service.

[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #471: Add: Metadata report base

2020-04-20 Thread GitBox
hxmhlt commented on a change in pull request #471: URL: https://github.com/apache/dubbo-go/pull/471#discussion_r44295 ## File path: metadata/service/inmemory/service.go ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #471: Add: Metadata report base

2020-04-20 Thread GitBox
hxmhlt commented on a change in pull request #471: URL: https://github.com/apache/dubbo-go/pull/471#discussion_r44373 ## File path: metadata/service/inmemory/service.go ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #471: Add: Metadata report base

2020-04-20 Thread GitBox
hxmhlt commented on a change in pull request #471: URL: https://github.com/apache/dubbo-go/pull/471#discussion_r44867 ## File path: common/rpc_service.go ## @@ -133,6 +133,11 @@ func (s *Service) Method() map[string]*MethodType { return s.methods } +// Name will

[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #471: Add: Metadata report base

2020-04-20 Thread GitBox
hxmhlt commented on a change in pull request #471: URL: https://github.com/apache/dubbo-go/pull/471#discussion_r49576 ## File path: common/rpc_service.go ## @@ -133,6 +133,11 @@ func (s *Service) Method() map[string]*MethodType { return s.methods } +// Name will