[GitHub] diecui1202 commented on issue #1387: [dubbo-cache] A method level cache implementation for dubbo.

2018-04-03 Thread GitBox
diecui1202 commented on issue #1387: [dubbo-cache] A method level cache 
implementation for dubbo.
URL: https://github.com/apache/incubator-dubbo/pull/1387#issuecomment-378488226
 
 
   @skykong1981 Are you there? 
   
   Could you please optimize the code in the following ways: 
   
   1. Make sure each added file contains apache license.
   2. Rich the comments for the key Java classes and methods with English, and 
some Chinese comments need to translate into English too.
   3. Rich the purpose of the PR to help us understanding it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #1551: update readme

2018-04-03 Thread GitBox
codecov-io commented on issue #1551: update readme
URL: https://github.com/apache/incubator-dubbo/pull/1551#issuecomment-378480380
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=h1) 
Report
   > Merging 
[#1551](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/c7b0c695e7b5abb6534cecb89c0caf762f0f06b0?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/graphs/tree.svg?token=VnEIkiFQT0=pr=150=650)](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1551  +/-   ##
   ==
   + Coverage   31.59%   31.63%   +0.03% 
   ==
 Files 682  682  
 Lines   3304833048  
 Branches 6597 6597  
   ==
   + Hits1044210454  +12 
   + Misses  2074720736  -11 
   + Partials 1859 1858   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | :arrow_down: |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `38% <0%> (-0.46%)` | :arrow_down: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `75.92% <0%> (+2.77%)` | :arrow_up: |
   | 
[...ba/dubbo/rpc/protocol/hessian/HessianProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1oZXNzaWFuL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2hlc3NpYW4vSGVzc2lhblByb3RvY29sLmphdmE=)
 | `63.07% <0%> (+3.07%)` | :arrow_up: |
   | 
[...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=)
 | `66.25% <0%> (+8.75%)` | :arrow_up: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `88.88% <0%> (+11.11%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=footer).
 Last update 
[c7b0c69...9b1f4da](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] gougouzcm opened a new issue #1552: How can I add a custom param(SPI) when zookeeperRegistry register url on zk

2018-04-03 Thread GitBox
gougouzcm opened a new issue #1552: How can I add a custom param(SPI) when 
zookeeperRegistry register url on zk
URL: https://github.com/apache/incubator-dubbo/issues/1552
 
 
   the similar issue is 
[#1367](https://github.com/apache/incubator-dubbo/issues/1367) but I didn't get 
solution  from it.
   I need to  write a custom router for dubbo AB test( not the group lable  in 
xml  )
   I notice that 
[AbstractDirectory.java](https://github.com/apache/incubator-dubbo/blob/master/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/directory/AbstractDirectory.java)
   In the method 
   
   ```
   
   1. protected void setRouters(List routers) {
   2. // copy list
   3. routers = routers == null ? new ArrayList() : new 
ArrayList(routers);
   4. // append url router
   5. String routerkey = url.getParameter(Constants.ROUTER_KEY);
   6. if (routerkey != null && routerkey.length() > 0) {
   7. RouterFactory routerFactory = 
ExtensionLoader.getExtensionLoader(RouterFactory.class).getExtension(routerkey);
   8. routers.add(routerFactory.getRouter(url));
   9. }
   10. // append mock invoker selector
   11. routers.add(new MockInvokersSelector());
   12. Collections.sort(routers);
   13. this.routers = routers;
   14. }
   
   ```
   
   
It will add some additional router ( I mean not from category routers but 
from from registry url) 。I don't want add a router in dubbo-admin-web for every 
Interface, I want a global setting 
   like filter or balance  lable such as ``   OR  I has some ways to add a param 
=myRouter& in registry url  。
   
   
   
   can anyone help me , thx。
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #1551: update readme

2018-04-03 Thread GitBox
codecov-io commented on issue #1551: update readme
URL: https://github.com/apache/incubator-dubbo/pull/1551#issuecomment-378480380
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=h1) 
Report
   > Merging 
[#1551](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/c7b0c695e7b5abb6534cecb89c0caf762f0f06b0?src=pr=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/graphs/tree.svg?height=150=650=VnEIkiFQT0=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1551  +/-   ##
   ==
   - Coverage   31.59%   31.56%   -0.04% 
   ==
 Files 682  682  
 Lines   3304833048  
 Branches 6597 6597  
   ==
   - Hits1044210430  -12 
   - Misses  2074720758  +11 
   - Partials 1859 1860   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==)
 | `25% <0%> (-5.96%)` | :arrow_down: |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | :arrow_down: |
   | 
[...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==)
 | `67.85% <0%> (-3.58%)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | :arrow_down: |
   | 
[...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh)
 | `77.2% <0%> (-1.48%)` | :arrow_down: |
   | 
[...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EdWJib1Byb3RvY29sLmphdmE=)
 | `60.44% <0%> (-0.89%)` | :arrow_down: |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `38% <0%> (-0.46%)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `56.71% <0%> (+1.49%)` | :arrow_up: |
   | 
[...ba/dubbo/rpc/protocol/hessian/HessianProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1oZXNzaWFuL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2hlc3NpYW4vSGVzc2lhblByb3RvY29sLmphdmE=)
 | `63.07% <0%> (+3.07%)` | :arrow_up: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `83.33% <0%> (+5.55%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=footer).
 Last 

[GitHub] codecov-io commented on issue #1551: update readme

2018-04-03 Thread GitBox
codecov-io commented on issue #1551: update readme
URL: https://github.com/apache/incubator-dubbo/pull/1551#issuecomment-378480380
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=h1) 
Report
   > Merging 
[#1551](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/c7b0c695e7b5abb6534cecb89c0caf762f0f06b0?src=pr=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/graphs/tree.svg?token=VnEIkiFQT0=150=pr=650)](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1551  +/-   ##
   ==
   - Coverage   31.59%   31.56%   -0.04% 
   ==
 Files 682  682  
 Lines   3304833048  
 Branches 6597 6597  
   ==
   - Hits1044210430  -12 
   - Misses  2074720758  +11 
   - Partials 1859 1860   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==)
 | `25% <0%> (-5.96%)` | :arrow_down: |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | :arrow_down: |
   | 
[...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==)
 | `67.85% <0%> (-3.58%)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | :arrow_down: |
   | 
[...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh)
 | `77.2% <0%> (-1.48%)` | :arrow_down: |
   | 
[...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EdWJib1Byb3RvY29sLmphdmE=)
 | `60.44% <0%> (-0.89%)` | :arrow_down: |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `38% <0%> (-0.46%)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `56.71% <0%> (+1.49%)` | :arrow_up: |
   | 
[...ba/dubbo/rpc/protocol/hessian/HessianProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1oZXNzaWFuL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2hlc3NpYW4vSGVzc2lhblByb3RvY29sLmphdmE=)
 | `63.07% <0%> (+3.07%)` | :arrow_up: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1551/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `83.33% <0%> (+5.55%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1551?src=pr=footer).
 Last 

Re: [Draft] Dubbo Incubator Report - April 2018

2018-04-03 Thread Huxing Zhang
Update to incubator wiki:
https://wiki.apache.org/incubator/April2018

On Tue, Apr 3, 2018 at 9:58 AM, Huxing Zhang  wrote:
> Hi,
>
> On Tue, Apr 3, 2018 at 7:11 AM, John D. Ament  wrote:
>> Inline comments...
>>
>> On Mon, Apr 2, 2018 at 1:58 AM Huxing Zhang  wrote:
>>
>>> Hi Community,
>>>
>>> Below is a draft of Dubbo Incubator Report, March 2018. Please feel
>>> free to comment if you have any concern.
>>>
>>> ---
>>> Dubbo
>>>
>>> Dubbo is a high-performance, lightweight, java based RPC framework.
>>>
>>> Dubbo has been incubating since 2018-02-16.
>>>
>>> Three most important issues to address in the move towards graduation:
>>>
>>>   1. First ASF release
>>>   2. IP clearance
>>>   3. Community building
>>>
>>
>> I would replace 2 with "Migrate remaining assets to the ASF"
>
> I am not sure what does the remaining assets mean?
> If we are talking about the remaining projects under dubbo group,
> there was discussion[1] about what to migrate to ASF, and it looks
> like the reason why not moving the remaining projects is that they are
> demo and no one seems to have objection for it.
>
>>
>>
>>>
>>> Any issues that the Incubator PMC (IPMC) or ASF Board wish/need to be
>>> aware of?
>>>
>>> None.
>>>
>>> How has the community developed since the last report?
>>>
>>>  * Complete ICLA for all PPMC
>>>  * SGA has been filed
>>>  * Decisions starts to be made via the community, e.g. continue to use
>>> github issue rather than JIRA
>>>  * Discussed feature donation by external users. e.g. circuit breaker,
>>> xmlrpc
>>>  * Received 1 GSoc student application (Raghu on Protocol Buffer
>>> integration)
>>>  * Currently ~450 mails on the dev@ list
>>>  * 9 new companies reported their using of Dubbo since last report
>>>
>>>
>>> How has the project developed since the last report?
>>>
>>> * Dubbo 2.6.1 & Dubbo 2.5.10 release (prior to code transition, non-ASF
>>> release)
>>> * Move 7 repos (including the core Dubbo repo) to Apache
>>> * Website (dubbo.incubator.apache.org) has been enabled
>>> * Website has been updated to be complied with ASF branding policy
>>> * 37 pull request created, 21 of them are closed
>>> * 80 issues created, 22 of them are closed
>>>
>>
>> This part's a little confusing.  The above mentions we're still discussing
>> github issues vs jira issues, so how were these issues created and closed?
>
> The community has made the decision[2] to use github issues.
>
>>
>>
>>>
>>> How would you assess the podling's maturity?
>>> Please feel free to add your own commentary.
>>>
>>>   [  ] Initial setup
>>>   [ X ] Working towards first release
>>>   [ ] Community building
>>>   [ ] Nearing graduation
>>>   [ ] Other:
>>>
>>
>> I would leave as initial setup, since we're still discussing fundamentals.
>
> I didn't know it can be multi-selected. I will add it.
>
>>
>>
>>>
>>> Date of last release:
>>>
>>> None.
>>>
>>> When were the last committers or PPMC members elected?
>>>
>>> None.
>>>
>>> --
>>> Best Regards!
>>> Huxing
>>>
>
> [1] 
> https://lists.apache.org/thread.html/31725059af6895596649d534c0fe4b648ed0398eba0d9f84bd9b85f2@%3Cdev.dubbo.apache.org%3E
> [2] 
> https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567bba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
>
> --
> Best Regards!
> Huxing

-- 
Best Regards!
Huxing


[GitHub] nzomkxia opened a new pull request #1551: update readme

2018-04-03 Thread GitBox
nzomkxia opened a new pull request #1551: update readme
URL: https://github.com/apache/incubator-dubbo/pull/1551
 
 
   ## What is the purpose of the change
   
   update project info in readme
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #1543: update readme #1488

2018-04-03 Thread GitBox
codecov-io commented on issue #1543: update readme #1488
URL: https://github.com/apache/incubator-dubbo/pull/1543#issuecomment-378157681
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=h1) 
Report
   > Merging 
[#1543](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/9deadadea3b1342345fed77c87a3d24ea026d7e6?src=pr=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/graphs/tree.svg?height=150=650=pr=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #1543  +/-   ##
   =
   + Coverage   31.59%   31.6%   +0.01% 
   =
 Files 682 682  
 Lines   33035   33048  +13 
 Branches 65926597   +5 
   =
   + Hits10437   10445   +8 
   - Misses  20743   20745   +2 
   - Partials 18551858   +3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...om/alibaba/com/caucho/hessian/io/LocaleHandle.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0xvY2FsZUhhbmRsZS5qYXZh)
 | `84.21% <0%> (-15.79%)` | :arrow_down: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `77.77% <0%> (-5.56%)` | :arrow_down: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `73.14% <0%> (-2.78%)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `55.22% <0%> (-1.5%)` | :arrow_down: |
   | 
[...om/alibaba/com/caucho/hessian/io/HessianInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW5JbnB1dC5qYXZh)
 | `13.19% <0%> (+0.17%)` | :arrow_up: |
   | 
[...m/alibaba/com/caucho/hessian/io/HessianOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW5PdXRwdXQuamF2YQ==)
 | `18.7% <0%> (+1.79%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=footer).
 Last update 
[9deadad...0cb65c1](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ralf0131 closed pull request #1543: update readme #1488

2018-04-03 Thread GitBox
ralf0131 closed pull request #1543: update readme #1488
URL: https://github.com/apache/incubator-dubbo/pull/1543
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index de45d64893..e4b20d9445 100644
--- a/README.md
+++ b/README.md
@@ -6,18 +6,18 @@
 ![license](https://img.shields.io/github/license/alibaba/dubbo.svg)
 ![maven](https://img.shields.io/maven-central/v/com.alibaba/dubbo.svg)
 
-Dubbo is a high-performance, java based RPC framework open-sourced by Alibaba. 
Please visit [dubbo.io](http://dubbo.io) for quick start and other information.
+Apache Dubbo (incubating) is a high-performance, java based RPC framework 
open-sourced by Alibaba. Please visit [dubbo official site 
](dubbo.incubator.apache.org) for quick start and other information.
 
-We are now collecting dubbo user info in order to help us to improve dubbo 
better, pls. kindly help us by providing yours on [issue#1012: Wanted: who's 
using dubbo](https://github.com/alibaba/dubbo/issues/1012), thanks :)
+We are now collecting dubbo user info in order to help us to improve dubbo 
better, pls. kindly help us by providing yours on [issue#1012: Wanted: who's 
using dubbo](https://github.com/apache/incubator-dubbo/issues/1012), thanks :)
 
 ## Links
 
-* [Side projects](http://github.com/dubbo)
-* [Dubbo Spring Boot](https://github.com/dubbo/dubbo-spring-boot-project) 
- Spring Boot Project for Dubbo.
-* [Dubbo ops](https://github.com/dubbo/dubbo-ops) - The reference 
implementation for dubbo 
ops(dubbo-admin,dubbo-monitor-simple,dubbo-registry-simple,etc.).
-* [Developer Mailing list](https://github.com/alibaba/dubbo/issues/1393) - Any 
questions or suggestions? 
[Subscribe](https://github.com/alibaba/dubbo/issues/1393) to 
(d...@dubbo.incubator.apache.org) to discuss with us.
+* [Side projects](https://github.com/apache/incubator-dubbo)
+* [Dubbo Spring 
Boot](https://github.com/apache/incubator-dubbo-spring-boot-project) - Spring 
Boot Project for Dubbo.
+* [Dubbo ops](https://github.com/apache/incubator-dubbo-ops) - The 
reference implementation for dubbo 
ops(dubbo-admin,dubbo-monitor-simple,dubbo-registry-simple,etc.).
+* [Developer Mailing 
list](https://github.com/apache/incubator-dubbo/issues/1393) - Any questions or 
suggestions? [Subscribe](https://github.com/apache/incubator-dubbo/issues/1393) 
to (d...@dubbo.incubator.apache.org) to discuss with us.
 * [Gitter channel](https://gitter.im/alibaba/dubbo) - Online chat room with 
Dubbo developers.
-* [Dubbo user manual(English)](http://dubbo.io/books/dubbo-user-book-en/) or 
[Dubbo用户手册(中文)](http://dubbo.io/books/dubbo-user-book/) - Describe how to use 
Dubbo and all features of Dubbo concretely.
-* [Dubbo developer guide(English)](http://dubbo.io/books/dubbo-dev-book-en/) 
or [Dubbo开发手册(中文)](http://dubbo.io/books/dubbo-dev-book/) - Detailly introduce 
the design principal, extension mechanisms, code conventions, version control 
and building project, etc.
-* [Dubbo admin manual(English)](http://dubbo.io/books/dubbo-admin-book-en/) or 
[Dubbo管理手册(中文)](http://dubbo.io/books/dubbo-admin-book/) - Describe how to use 
Dubbo registry and admin-console.
+* [Dubbo user 
manual(English)](http://dubbo.apache.org/books/dubbo-user-book-en/) or 
[Dubbo用户手册(中文)](http://dubbo.apache.org/books/dubbo-user-book/) - Describe how 
to use Dubbo and all features of Dubbo concretely.
+* [Dubbo developer 
guide(English)](http://dubbo.apache.org/books/dubbo-dev-book-en/) or 
[Dubbo开发手册(中文)](http://dubbo.apache.org/books/dubbo-dev-book/) - Detailly 
introduce the design principal, extension mechanisms, code conventions, version 
control and building project, etc.
+* [Dubbo admin 
manual(English)](http://dubbo.apache.org/books/dubbo-admin-book-en/) or 
[Dubbo管理手册(中文)](http://dubbo.apache.org/books/dubbo-admin-book/) - Describe how 
to use Dubbo registry and admin-console.
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ralf0131 commented on issue #1543: update readme #1488

2018-04-03 Thread GitBox
ralf0131 commented on issue #1543: update readme #1488
URL: https://github.com/apache/incubator-dubbo/pull/1543#issuecomment-378472247
 
 
   Look good to me! Thanks for the pull request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] beiwei30 closed pull request #1413: Fix #1411 Java Locale use '_' split language, country, variant.

2018-04-03 Thread GitBox
beiwei30 closed pull request #1413: Fix #1411 Java Locale use '_' split 
language, country, variant.
URL: https://github.com/apache/incubator-dubbo/pull/1413
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/LocaleHandle.java
 
b/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/LocaleHandle.java
index 6018184644..751eee651d 100644
--- 
a/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/LocaleHandle.java
+++ 
b/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/LocaleHandle.java
@@ -54,17 +54,37 @@
  * Handle for a locale object.
  */
 public class LocaleHandle implements java.io.Serializable, HessianHandle {
-private String language;
-private String country;
-private String variant;
+private String value;
 
-public LocaleHandle(String language, String country, String variant) {
-this.language = language;
-this.country = country;
-this.variant = variant;
+public LocaleHandle(String locale) {
+this.value = locale;
 }
 
 private Object readResolve() {
+if (value == null) {
+return null;
+}
+
+if (value.length() == 0) {
+return new Locale("");
+}
+
+int extStart = value.indexOf("_#");
+if (extStart != -1) value = value.substring(0, extStart);
+
+String language = value, country = "", variant = "";
+int pos1 = value.indexOf('_');
+if (pos1 != -1) {
+language = value.substring(0, pos1++);
+
+int pos2 = value.indexOf('_', pos1);
+if (pos2 == -1) {
+country = value.substring(pos1);
+} else {
+country = value.substring(pos1, pos2);
+variant = value.substring(pos2 + 1);
+}
+}
 return new Locale(language, country, variant);
 }
 }
diff --git 
a/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/LocaleSerializer.java
 
b/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/LocaleSerializer.java
index 6555e4a6b5..86f6cb0f3c 100644
--- 
a/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/LocaleSerializer.java
+++ 
b/hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/LocaleSerializer.java
@@ -68,7 +68,7 @@ public void writeObject(Object obj, AbstractHessianOutput out)
 else {
 Locale locale = (Locale) obj;
 
-out.writeObject(new LocaleHandle(locale.getLanguage(), 
locale.getCountry(), locale.getVariant()));
+out.writeObject(new LocaleHandle(locale.toString()));
 }
 }
 }
diff --git 
a/hessian-lite/src/test/java/com/alibaba/com/caucho/hessian/io/LocaleSerializerTest.java
 
b/hessian-lite/src/test/java/com/alibaba/com/caucho/hessian/io/LocaleSerializerTest.java
index 0732e5171e..73cdd3f174 100644
--- 
a/hessian-lite/src/test/java/com/alibaba/com/caucho/hessian/io/LocaleSerializerTest.java
+++ 
b/hessian-lite/src/test/java/com/alibaba/com/caucho/hessian/io/LocaleSerializerTest.java
@@ -1,41 +1,29 @@
 package com.alibaba.com.caucho.hessian.io;
 
-import com.alibaba.com.caucho.hessian.io.base.SerializeTestBase;
-import junit.framework.TestCase;
+import java.io.IOException;
+import java.util.Locale;
+
 import org.junit.Test;
 
-import java.util.Locale;
+import com.alibaba.com.caucho.hessian.io.base.SerializeTestBase;
+
+import junit.framework.TestCase;
 
 public class LocaleSerializerTest extends SerializeTestBase {
+
+/** {@linkplain LocaleSerializer#writeObject(Object, 
AbstractHessianOutput)} */
 @Test
-public void hessian2() throws Exception {
-Locale locale = new Locale("zh");
-Locale result = baseHession2Serialize(locale);
-TestCase.assertEquals(locale, result);
-locale = new Locale("zh", "CN");
-result = baseHession2Serialize(locale);
-TestCase.assertEquals(locale, result);
-locale = new Locale("zh", "CN", "GBK");
-result = baseHession2Serialize(locale);
-TestCase.assertEquals(locale, result);
-locale = new Locale("zh-hant", "CN");
-result = baseHession2Serialize(locale);
-TestCase.assertEquals(locale, result);
+public void locale() throws IOException {
+assertLocale(null);
+assertLocale(new Locale(""));
+assertLocale(new Locale("zh"));
+assertLocale(new Locale("zh", "CN"));
+assertLocale(new Locale("zh-hant", "CN"));
+assertLocale(new Locale("zh-hant", "CN", "GBK"));
 }
 
-@Test
-public void hessian1() throws Exception {
-Locale locale = new Locale("zh");
-Locale result = baseHessionSerialize(locale);
-

[GitHub] zonghaishang commented on issue #1522: 启动时检查依赖,无论我check设为true或者false,它都不检测直接启动成功

2018-04-03 Thread GitBox
zonghaishang commented on issue #1522: 启动时检查依赖,无论我check设为true或者false,它都不检测直接启动成功
URL: 
https://github.com/apache/incubator-dubbo/issues/1522#issuecomment-378464573
 
 
   very sorry for the late reply, I think there are other services already 
started, so 'check' is correct.
   
   You can add breakpoints at the following line of code to determine if 
invoice.isAvailable() should return true.
   
   com.alibaba.dubbo.config.ReferenceConfig#createProxy:
   
   if (c && !invoker.isAvailable()) {
   throw new IllegalStateException("Failed to check the status of the 
service " + interfaceName + ". No provider available for the service " + (group 
== null ? "" : group + "/") + interfaceName + (version == null ? "" : ":" + 
version) + " from the url " + invoker.getUrl() + " to the consumer " + 
NetUtils.getLocalHost() + " use dubbo version " + Version.getVersion());
   }
   
   yiji
   
   在 2018年3月29日,20:42,zeng54088 
> 写道:
   
   @zonghaishang 还是不行啊
   dubbo版本为2.6.0
   项目A依赖于项目B
   
   项目A configuration 如下
   @configuration
   public class DubboConfiguration {
   @bean
   public ApplicationConfig applicationConfig() {
   ApplicationConfig applicationConfig = new ApplicationConfig();
   applicationConfig.setName("provider-test");
   return applicationConfig;
   }
   
   @Bean
   public RegistryConfig registryConfig() {
   RegistryConfig registryConfig = new RegistryConfig();
   registryConfig.setAddress("zookeeper://192.168.93.87:2182");
   registryConfig.setClient("curator");
   return registryConfig;
   }
   
   @Bean
   public ProtocolConfig protocolConfig(){
   ProtocolConfig protocolConfig=new ProtocolConfig();
   protocolConfig.setPort(20881);
   protocolConfig.setName("dubbo");
   return protocolConfig;
   }
   
   
   }
   
   项目B configuration 如下
   @configuration
   public class DubboConfiguration {
   @bean
   public ApplicationConfig applicationConfig() {
   ApplicationConfig applicationConfig = new ApplicationConfig();
   applicationConfig.setName("provider-test1");
   return applicationConfig;
   }
   
   @Bean
   public RegistryConfig registryConfig() {
   RegistryConfig registryConfig = new RegistryConfig();
   registryConfig.setAddress("zookeeper://192.168.93.87:2182");
   registryConfig.setClient("curator");
   return registryConfig;
   }
   
   @Bean
   public ProtocolConfig protocolConfig(){
   ProtocolConfig protocolConfig=new ProtocolConfig();
   protocolConfig.setPort(20880);
   protocolConfig.setName("dubbo");
   return protocolConfig;
   }
   
   
   }
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] foreveryang321 commented on issue #1547: centos7 start.sh启动 报 Ncat: Connection refused

2018-04-03 Thread GitBox
foreveryang321 commented on issue #1547: centos7 start.sh启动 报 Ncat: Connection 
refused
URL: 
https://github.com/apache/incubator-dubbo/issues/1547#issuecomment-378446482
 
 
   
https://github.com/apache/incubator-dubbo/blob/master/dubbo-container/dubbo-container-api/src/main/resources/META-INF/assembly/bin/start.sh


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] YFCoder2 commented on issue #1547: centos7 start.sh启动 报 Ncat: Connection refused

2018-04-03 Thread GitBox
YFCoder2 commented on issue #1547: centos7 start.sh启动 报 Ncat: Connection refused
URL: 
https://github.com/apache/incubator-dubbo/issues/1547#issuecomment-378342839
 
 
   求问 start.sh 脚本您是从哪里获得的 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #1318: fix annotion @DubboComponetScan doesn't work in spring3

2018-04-03 Thread GitBox
codecov-io commented on issue #1318: fix annotion @DubboComponetScan doesn't 
work in spring3
URL: https://github.com/apache/incubator-dubbo/pull/1318#issuecomment-362806860
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1318?src=pr=h1) 
Report
   > Merging 
[#1318](https://codecov.io/gh/apache/incubator-dubbo/pull/1318?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/9deadadea3b1342345fed77c87a3d24ea026d7e6?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1318/graphs/tree.svg?width=650=150=VnEIkiFQT0=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1318?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1318  +/-   ##
   ==
   - Coverage   31.59%   31.58%   -0.01% 
   ==
 Files 682  682  
 Lines   3303533040   +5 
 Branches 6592 6595   +3 
   ==
 Hits1043710437  
   - Misses  2074320746   +3 
   - Partials 1855 1857   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1318?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1318/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQW5ub3RhdGlvbkJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=)
 | `82.48% <50%> (-2.37%)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1318/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1318/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `55.22% <0%> (-1.5%)` | :arrow_down: |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1318/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `38% <0%> (-0.46%)` | :arrow_down: |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1318/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `55.69% <0%> (+3.79%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1318?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1318?src=pr=footer).
 Last update 
[9deadad...06c1aad](https://codecov.io/gh/apache/incubator-dubbo/pull/1318?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] XiaoDongJi opened a new issue #1547: centos7 start.sh启动 报 Ncat: Connection refused

2018-04-03 Thread GitBox
XiaoDongJi opened a new issue #1547: centos7 start.sh启动 报 Ncat: Connection 
refused
URL: https://github.com/apache/incubator-dubbo/issues/1547
 
 
   使用2.5.4打包dubbo-demo-provider-2.5.4-SNAPSHOT,在centos7中start.sh启动报错。
   ./start.sh
   Starting the demo-provider Ncat: Connection refused.
   .Ncat: Connection refused.
   .Ncat: Connection refused.
   .Ncat: Connection refused.
   
   请问是不兼容吗


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tinnkm commented on issue #96: how to compile the dubbo-spring-boot-project-0.2.0?

2018-04-03 Thread GitBox
tinnkm commented on issue #96: how to compile the 
dubbo-spring-boot-project-0.2.0?
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/96#issuecomment-378238082
 
 
   i will try,thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tinnkm closed issue #96: how to compile the dubbo-spring-boot-project-0.2.0?

2018-04-03 Thread GitBox
tinnkm closed issue #96: how to compile the dubbo-spring-boot-project-0.2.0?
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/96
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nzomkxia commented on issue #1543: update readme #1488

2018-04-03 Thread GitBox
nzomkxia commented on issue #1543: update readme #1488
URL: https://github.com/apache/incubator-dubbo/pull/1543#issuecomment-378212215
 
 
   dubbo-spring-boot, dubbo-ops and dubbo-website are also updated


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] deidei opened a new issue #1546: multiple registry centers or one registry center cluster?

2018-04-03 Thread GitBox
deidei opened a new issue #1546: multiple registry centers or one registry 
center cluster?
URL: https://github.com/apache/incubator-dubbo/issues/1546
 
 
   I use zookeeper as my registry center and I have three servers. Now I have 
two choices to deploy zookeeper registry center:
   1. three in standalone mode

   2. one in leader mode, the other two in follower mode

   
   Which one is the best practice?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] 89333367 opened a new issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突

2018-04-03 Thread GitBox
8967 opened a new issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突
URL: https://github.com/apache/incubator-dubbo/issues/1545
 
 
   ```
   18/04/03 18:25:06 ERROR server.Server:  [DUBBO] qos-server can not bind 
localhost:2, dubbo version: 2.6.1, current host: 192.168.12.27
   java.net.BindException: Address already in use
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Net.java:433)
at sun.nio.ch.Net.bind(Net.java:425)
at 
sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
at 
io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:125)
at 
io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:485)
at 
io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1089)
at 
io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:430)
at 
io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:415)
at 
io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:903)
at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:198)
at 
io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:348)
at 
io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:357)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)
at 
io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:111)
at 
io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)
at java.lang.Thread.run(Thread.java:745)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] leyou240 commented on issue #82: The bug of configuration in application.yml

2018-04-03 Thread GitBox
leyou240 commented on issue #82: The bug of configuration in application.yml
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/82#issuecomment-378201334
 
 
   @mercyblitz What about 2.6.x? It will also fix?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nzomkxia opened a new pull request #10: update readme

2018-04-03 Thread GitBox
nzomkxia opened a new pull request #10: update readme
URL: https://github.com/apache/incubator-dubbo-website/pull/10
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: List volume and issue tracking

2018-04-03 Thread Huxing Zhang
Hi,

I am +1 on split the traffic of @dev list.

The issue appears after migrating repo to ASF. I use
"label:asf-dubbo-dev -[github]" to filter out them. :(

On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu  wrote:
> I have the same feeling.
>
> IMO, all the issue emails should be sent to iss...@dubbo.apache.org, all

+1. All issues and the comments should go there.

> the PR emails should be sent to comm...@dubbo.apache.org. How do you think?

-1. commit@ are used when code are committed to repo, I don't think
PRs should go there.
Once a PR is accepted, a message will be sent to commit@

My suggestion is PRs and the comments should go to issues@, or we can
create a new list prs@.

> and who can help to fix this?
>
> And I think we should use github issues, and move all the Jira issues to
> github.
>
> 2018-04-03 16:43 GMT+08:00 Mark Thomas :
>
>> All,
>>
>> I've been away for just over a week and come back to find over 300
>> unread emails on the dev list.
>>
>> A large proportion of these messages are comments on pull requests? Is
>> dev@ the right list for those?
>>
>> Another large proportion appear to be comments on issues? Is dev@ the
>> right list for those?
>>
>> Generally, the recommendation is to split into multiple lists based on
>> audience rather than topic. For some projects it therefore makes sense
>> to have all dev related traffic going to a single list. For others,
>> particularly large projects, it makes sense to split the dev traffic.
>>
>> The project appears to be using GitHub issues and Jira. That is
>> confusing. I'd recommend that you select one issue tracker and stick to it.

There was discussion[1] on the mailing list and the community has
decided to use github issues.
My understanding is that currently JIRA is only used for GSOC ideas
and track existing issues prior to that decision.
I am +0 on migrating the existing JIRA issues to github issues.

>>
>> Finally, the github issues seem to be a mix of bugs and support
>> questions. Is that the way the podling wants to use github issues?

People get used to ask questions by creating an issue before joining ASF.
The PPMC are trying to tell users to use mailing list to ask questions
by leaving message on the issues, so does the website.
But I think it will take some time.

>>
>> I have no view on what the 'right' answers to the above questions are.
>> I'm asking them to get the podling thinking about the issues. What, if
>> anything, to do about any of the above is for the podling to decide.
>>
>>
>> Mark
>>


[1] 
https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567bba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
-- 
Best Regards!
Huxing


[GitHub] ron-shaw opened a new issue #98: how to configure multiple protocols

2018-04-03 Thread GitBox
ron-shaw opened a new issue #98: how to configure multiple protocols
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/98
 
 
   application.properties:
   `
   dubbo.config.multiple=true
   #
   dubbo.protocols[dubbo].id = dubbo
   dubbo.protocols[dubbo].name = dubbo
   dubbo.protocols[dubbo].port = 23456
   dubbo.protocols[dubbo].status = server
   #
   dubbo.protocols[hessian].id = hessian
   dubbo.protocols[hessian].name = hessian
   dubbo.protocols[hessian].port = 12346
   dubbo.protocols[hessian].status = server
   `
   
   it does not work fine.
   what can i do?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] deif2005 commented on issue #1542: 无法注册至zookeeper

2018-04-03 Thread GitBox
deif2005 commented on issue #1542: 无法注册至zookeeper
URL: 
https://github.com/apache/incubator-dubbo/issues/1542#issuecomment-378185351
 
 
   我发现,能脸上zk服务,但是无法注册服务(可以检测到节点,但是不能注册新节点),后来我添加了zk客户端的引用“” 现在出现如下异常提示:Failed to subscribe 
consumer://192.168.1.69/com.alibaba.dubbo.registry.RegistryService?application=dubbodemo-provider=1=curator=1=2.6.1=com.alibaba.dubbo.registry.RegistryService=true=lookup,subscribe,unsubscribe,unregister,register=6064=false=true=true=1=1522746885823=false,
 cause: Failed to invoke the method subscribe in the service 
com.alibaba.dubbo.registry.RegistryService. No provider available for the 
service com.alibaba.dubbo.registry.RegistryService from registry 0.0.0.0:9090 
on the consumer 192.168.1.69 using the dubbo version 2.6.1. Please check if the 
providers have been started and registered.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zeng54088 commented on issue #52: service空指针

2018-04-03 Thread GitBox
zeng54088 commented on issue #52: service空指针
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/52#issuecomment-378184893
 
 
   @luffyke Modified finish


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zeng54088 commented on issue #52: service空指针

2018-04-03 Thread GitBox
zeng54088 commented on issue #52: service空指针
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/52#issuecomment-377936569
 
 
   @luffyke 
我是先启动provider,再启动consumer的。看了zookeeper里面也有dubbo的节点,但是调用方法的时候就是报空指针,大兄弟看看我哪里错了
   异常如下
   
   
   2018-04-02 22:04:49.783  WARN 11652 --- [   main] 
com.alibaba.dubbo.config.AbstractConfig  :  [DUBBO] null, dubbo version: 2.0.1, 
current host: 192.168.93.6
   
   java.lang.reflect.InvocationTargetException: null
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[na:1.8.0_131]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[na:1.8.0_131]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[na:1.8.0_131]
at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_131]
at 
com.alibaba.dubbo.config.AbstractConfig.toString(AbstractConfig.java:473) 
~[dubbo-2.5.10.jar:2.0.1]
at java.lang.String.valueOf(String.java:2994) [na:1.8.0_131]
at java.lang.StringBuilder.append(StringBuilder.java:131) [na:1.8.0_131]
at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.AbstractAnnotationConfigBeanBuilder.build(AbstractAnnotationConfigBeanBuilder.java:75)
 [dubbo-2.5.10.jar:2.0.1]
at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.buildReferenceBean(ReferenceAnnotationBeanPostProcessor.java:345)
 [dubbo-2.5.10.jar:2.0.1]
at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.access$100(ReferenceAnnotationBeanPostProcessor.java:61)
 [dubbo-2.5.10.jar:2.0.1]
at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor$ReferenceFieldElement.inject(ReferenceAnnotationBeanPostProcessor.java:323)
 [dubbo-2.5.10.jar:2.0.1]
at 
org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:88)
 [spring-beans-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.postProcessPropertyValues(ReferenceAnnotationBeanPostProcessor.java:88)
 [dubbo-2.5.10.jar:2.0.1]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1214)
 [spring-beans-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:543)
 [spring-beans-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:482)
 [spring-beans-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306)
 [spring-beans-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
 [spring-beans-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
 [spring-beans-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
 [spring-beans-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:772)
 [spring-beans-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:838)
 [spring-context-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:537)
 [spring-context-4.2.3.RELEASE.jar:4.2.3.RELEASE]
at 
org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:118)
 [spring-boot-1.3.0.RELEASE.jar:1.3.0.RELEASE]
at 
org.springframework.boot.SpringApplication.refresh(SpringApplication.java:752) 
[spring-boot-1.3.0.RELEASE.jar:1.3.0.RELEASE]
at 
org.springframework.boot.SpringApplication.doRun(SpringApplication.java:347) 
[spring-boot-1.3.0.RELEASE.jar:1.3.0.RELEASE]
at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:295) 
[spring-boot-1.3.0.RELEASE.jar:1.3.0.RELEASE]
at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1112) 
[spring-boot-1.3.0.RELEASE.jar:1.3.0.RELEASE]
at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1101) 
[spring-boot-1.3.0.RELEASE.jar:1.3.0.RELEASE]
at 

[GitHub] kimmking commented on issue #1542: 无法注册至zookeeper

2018-04-03 Thread GitBox
kimmking commented on issue #1542: 无法注册至zookeeper
URL: 
https://github.com/apache/incubator-dubbo/issues/1542#issuecomment-378183242
 
 
   Can you submit a test case to reproduce this issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nzomkxia opened a new pull request #21: update readme

2018-04-03 Thread GitBox
nzomkxia opened a new pull request #21: update readme
URL: https://github.com/apache/incubator-dubbo-ops/pull/21
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: List volume and issue tracking

2018-04-03 Thread Yong Zhu
I have the same feeling.

IMO, all the issue emails should be sent to iss...@dubbo.apache.org, all
the PR emails should be sent to comm...@dubbo.apache.org. How do you think?
and who can help to fix this?

And I think we should use github issues, and move all the Jira issues to
github.

2018-04-03 16:43 GMT+08:00 Mark Thomas :

> All,
>
> I've been away for just over a week and come back to find over 300
> unread emails on the dev list.
>
> A large proportion of these messages are comments on pull requests? Is
> dev@ the right list for those?
>
> Another large proportion appear to be comments on issues? Is dev@ the
> right list for those?
>
> Generally, the recommendation is to split into multiple lists based on
> audience rather than topic. For some projects it therefore makes sense
> to have all dev related traffic going to a single list. For others,
> particularly large projects, it makes sense to split the dev traffic.
>
> The project appears to be using GitHub issues and Jira. That is
> confusing. I'd recommend that you select one issue tracker and stick to it.
>
> Finally, the github issues seem to be a mix of bugs and support
> questions. Is that the way the podling wants to use github issues?
>
> I have no view on what the 'right' answers to the above questions are.
> I'm asking them to get the podling thinking about the issues. What, if
> anything, to do about any of the above is for the podling to decide.
>
>
> Mark
>


[GitHub] nzomkxia opened a new pull request #97: update readme

2018-04-03 Thread GitBox
nzomkxia opened a new pull request #97: update readme
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/97
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] diecui1202 commented on issue #1502: kryo's ClassLoader Exception

2018-04-03 Thread GitBox
diecui1202 commented on issue #1502: kryo's ClassLoader Exception
URL: 
https://github.com/apache/incubator-dubbo/issues/1502#issuecomment-378171068
 
 
   @tosilu 
   
   We will be appreciated if you could stick the exception stack trace. Without 
details, we can't repeat the problem. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] techyang commented on issue #1533: 在Dubbo的Filter里面无法拿到隐式传参的参数(I can't get the attachment in Dubbo Filter)?

2018-04-03 Thread GitBox
techyang commented on issue #1533: 在Dubbo的Filter里面无法拿到隐式传参的参数(I can't get the 
attachment in Dubbo Filter)?
URL: 
https://github.com/apache/incubator-dubbo/issues/1533#issuecomment-378165928
 
 
   @CoderDade , which dubbo version do you use? I used dubbo 2.5.8 and I found 
both RpcContext.getContext().getAttachment(key)  and 
invocation.getAttachment(key) methods were not work.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ralf0131 commented on issue #1543: update readme #1488

2018-04-03 Thread GitBox
ralf0131 commented on issue #1543: update readme #1488
URL: https://github.com/apache/incubator-dubbo/pull/1543#issuecomment-378159722
 
 
   Hi, welcome!
   
   Thanks for the pull request.
   
   Please also update the links of the side projects.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #1543: update readme #1488

2018-04-03 Thread GitBox
codecov-io commented on issue #1543: update readme #1488
URL: https://github.com/apache/incubator-dubbo/pull/1543#issuecomment-378157681
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=h1) 
Report
   > Merging 
[#1543](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/9deadadea3b1342345fed77c87a3d24ea026d7e6?src=pr=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/graphs/tree.svg?src=pr=VnEIkiFQT0=650=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1543  +/-   ##
   ==
   - Coverage   31.59%   31.54%   -0.05% 
   ==
 Files 682  682  
 Lines   3303533035  
 Branches 6592 6592  
   ==
   - Hits1043710421  -16 
   - Misses  2074320757  +14 
   - Partials 1855 1857   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==)
 | `25% <0%> (-5.96%)` | :arrow_down: |
   | 
[...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=)
 | `61.25% <0%> (-5%)` | :arrow_down: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `73.14% <0%> (-2.78%)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `55.22% <0%> (-1.5%)` | :arrow_down: |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `38% <0%> (-0.46%)` | :arrow_down: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1543/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `83.33% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=footer).
 Last update 
[9deadad...bac1a90](https://codecov.io/gh/apache/incubator-dubbo/pull/1543?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Delete the two duplicated projects: (dubbo/dubbo and dubbo/dubbo.github.io)?

2018-04-03 Thread Huxing Zhang
Hi,

On Fri, Mar 30, 2018 at 2:31 PM, Huxing Zhang  wrote:
> On Fri, Mar 30, 2018 at 2:26 PM, Justin Mclean  
> wrote:
>> Hi,
>>
>> If dubbo.github.io is redirecting to dubbo.apache.opg then there's no need 
>> to have any of the old content in the 
>> https://github.com/dubbo/dubbo.github.io repo right? We may still need the 
>> repo for the redirect but the content in the repo can be removed?
>

All the files except index.html and README are deleted.

>
>>
>> Perhaps it would be a good idea to add a README point to the new repo?
>
> +1. will update it.

Issue created: https://github.com/dubbo/dubbo.github.io/issues/3

>
>>
>> Thanks,.
>> Justin
>
>
>
> --
> Best Regards!
> Huxing



-- 
Best Regards!
Huxing


[GitHub] CoderDade commented on issue #1533: 在Dubbo的Filter里面无法拿到隐式传参的参数(I can't get the attachment in Dubbo Filter)?

2018-04-03 Thread GitBox
CoderDade commented on issue #1533: 在Dubbo的Filter里面无法拿到隐式传参的参数(I can't get the 
attachment in Dubbo Filter)?
URL: 
https://github.com/apache/incubator-dubbo/issues/1533#issuecomment-378152342
 
 
   @kimmking Well,thanks for @techyang .I found out that the way I got value of 
the attachment was wrong.I used to get attachments by 
`RpcContext.getContext().getAttachment(key)`  in the Filter#invoke, but the 
right way seems to be using `invocation.getAttachment(key)`.And I make it.So it 
seems to be that I make a mistake.Thanks for your kindly support.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nzomkxia opened a new pull request #1543: update readme #1488

2018-04-03 Thread GitBox
nzomkxia opened a new pull request #1543: update readme #1488
URL: https://github.com/apache/incubator-dubbo/pull/1543
 
 
   ## What is the purpose of the change
   
   update readme #1488
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] deif2005 opened a new issue #1542: 无法注册至zookeeper

2018-04-03 Thread GitBox
deif2005 opened a new issue #1542: 无法注册至zookeeper
URL: https://github.com/apache/incubator-dubbo/issues/1542
 
 
   
zookeeper服务经客户端连接,可用,使用Curator端,经java调试,可以访问服务。使用multicast可以正常广播和调用服务,唯独使用spring配置dubbo就是无法注册至zookeeper服务。提示KeeperErrorCode
 = Unimplemented for /dubbo


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #1509: add unit test for remoting module

2018-04-03 Thread GitBox
codecov-io commented on issue #1509: add unit test for remoting module
URL: https://github.com/apache/incubator-dubbo/pull/1509#issuecomment-376053743
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr=h1) 
Report
   > Merging 
[#1509](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/9deadadea3b1342345fed77c87a3d24ea026d7e6?src=pr=desc)
 will **increase** coverage by `0.49%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/graphs/tree.svg?src=pr=650=VnEIkiFQT0=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1509  +/-   ##
   ==
   + Coverage   31.59%   32.09%   +0.49% 
   ==
 Files 682  682  
 Lines   3303533035  
 Branches 6592 6592  
   ==
   + Hits1043710602 +165 
   + Misses  2074320539 -204 
   - Partials 1855 1894  +39
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `73.14% <0%> (-2.78%)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `55.22% <0%> (-1.5%)` | :arrow_down: |
   | 
[...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==)
 | `57.97% <0%> (-1.45%)` | :arrow_down: |
   | 
[...ing/transport/netty4/logging/MessageFormatter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9sb2dnaW5nL01lc3NhZ2VGb3JtYXR0ZXIuamF2YQ==)
 | `14.28% <0%> (+14.28%)` | :arrow_up: |
   | 
[.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNsaWVudEhhbmRsZXIuamF2YQ==)
 | `18.18% <0%> (+18.18%)` | :arrow_up: |
   | 
[...remoting/transport/netty4/logging/NettyHelper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9sb2dnaW5nL05ldHR5SGVscGVyLmphdmE=)
 | `20.75% <0%> (+20.75%)` | :arrow_up: |
   | 
[.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNoYW5uZWwuamF2YQ==)
 | `25% <0%> (+25%)` | :arrow_up: |
   | 
[...o/remoting/transport/netty4/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNvZGVjQWRhcHRlci5qYXZh)
 | `29.72% <0%> (+29.72%)` | :arrow_up: |
   | 
[.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlckhhbmRsZXIuamF2YQ==)
 | `31.7% <0%> (+31.7%)` | :arrow_up: |
   | ... and [4 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] LinGoWei commented on issue #1539: 使用 mock 时,调用生产者异常堆栈无法打印

2018-04-03 Thread GitBox
LinGoWei commented on issue #1539: 使用 mock 时,调用生产者异常堆栈无法打印
URL: 
https://github.com/apache/incubator-dubbo/issues/1539#issuecomment-378105451
 
 
   logger.isWarnEnabled() result is true when log level lower than warn. so it 
is no problem.
   I check dubbo log4j.properites found "log4j.rootLogger=info" 
   it is my mistake in dubbo source between master and Insider branch.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] LinGoWei opened a new issue #1539: 使用 mock 时,调用生产者异常堆栈无法打印

2018-04-03 Thread GitBox
LinGoWei opened a new issue #1539: 使用 mock 时,调用生产者异常堆栈无法打印
URL: https://github.com/apache/incubator-dubbo/issues/1539
 
 
   在使用dubbo mock 时发现调用第三方服务的异常堆栈没打印,导致排查问题难度提高,debug 
发现在调用FailoverClusterInvoker.doInvoke() 
方法后,抛出的异常堆栈信息将会在com/alibaba/dubbo/rpc/cluster/support/wrapper/MockClusterInvoker.java:80
 抛出,并被catch,
   
![image](https://user-images.githubusercontent.com/6905006/38197721-3d7ba2f4-36bc-11e8-9bb1-3ca39e2eadc4.png)
   在判断 logger.isWarnEnabled() 后将会使用 info() 打印堆栈日志。
   日志级别等于或低于 warn 时,isWarnEnabled() 均为 true,所以在日志级别为 info时能正常打印异常堆栈,但warn 
级别下并不打印 info日志。
   但为什么在判断isWarnEnabled() 后却使用 info 方法打印呢?
   thx for @kimmking follow-up


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services