Re: Suggestions collection for release of dubbo v2.6.2

[Justin Mclean]

Hi,

This is the best guide. [1] Please don’t follow what some TLPs have done like 
Apache Spark or Apache Hadoop as they have way far too much information in 
their NOTICE files.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html

Re: Suggestions collection for release of dubbo v2.6.2

[Huxing Zhang]

Justin mentioned an issue with the existing LICENSE and NOTICE
file[1]. I will take a look at it.

You can refer to [2][3] for release process, and RocketMQ has provided
an excellent guide [4].

[1] https://issues.apache.org/jira/browse/DUBBO-7
[2] http://www.apache.org/dev/publishing-maven-artifacts.html
[3] https://incubator.apache.org/guides/releasemanagement.html
[4] https://rocketmq.apache.org/docs/release-manual



On Wed, Apr 25, 2018 at 10:46 AM, jun liu  wrote:
> Here’s a brief report for the progress of v2.6.2
>
> 1. Brief release notes are summarized here[1].
> 2. Milestone seems not totally synched with commits at first, but all synched 
> now. The use of milestone needs to be improved in the next release.
>
> Next, i will create a new branch '2.6.2-release’ for this release, changes to 
> the release candidates (if there’s any) please submit the temporary branch 
> directly, master will keep evolve as normal. We need a thorough check for all 
> release candidates before the creation of the new branch, to avoid 
> unnecessary changes after creation. If you have any other solutions for this 
> kind long-term running release, welcome discussion.
>
> [1]. 
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-e1d19049b2cf34245de8
>  
> 
>
> Best regards,
> Jun
>
>> On 24 Apr 2018, at 11:26 AM, Huxing Zhang  wrote:
>>
>> Hi,
>>
>> On Mon, Apr 23, 2018 at 8:12 PM, Jun Liu  wrote:
>>> Hey community,
>>>
>>> The release of dubbo v2.6.2 is on progress now, and we expect to launch the
>>> official vote for this release this week. The release candidates are
>>> tracked in a milestone[1], and it is also the candidates that need to be
>>> notified to community and confirmed from community before voting.
>>>
>>> From your perspective:
>>> 1. Any issues or features that should not be included but already exists in
>>> milestone, for any reasons, for example, need further test.
>>
>> If we do not have enough time, we can exclude issues with 'priority-low' tag.
>>
>>> 2. Any issues or features that should be supported but not included yet.
>>
>> I think this pull request should be included:
>> https://github.com/apache/incubator-dubbo/pull/1620
>> The exception stack trace in the demo makes user confused, which IMO
>> need to be fixed in the next release.
>>
>>> 3. Other suggestions.
>>> Please reply to this mail directly or file an issue on github.
>>
>>>
>>> [1]. https://github.com/apache/incubator-dubbo/milestone/15
>>>
>>> Best regards,
>>> Jun
>>
>> --
>> Best Regards！
>> Huxing
>



-- 
Best Regards！
Huxing

Re: Suggestions collection for release of dubbo v2.6.2

[jun liu]

Here’s a brief report for the progress of v2.6.2

1. Brief release notes are summarized here[1].
2. Milestone seems not totally synched with commits at first, but all synched 
now. The use of milestone needs to be improved in the next release.

Next, i will create a new branch '2.6.2-release’ for this release, changes to 
the release candidates (if there’s any) please submit the temporary branch 
directly, master will keep evolve as normal. We need a thorough check for all 
release candidates before the creation of the new branch, to avoid unnecessary 
changes after creation. If you have any other solutions for this kind long-term 
running release, welcome discussion.
 
[1]. 
https://github.com/apache/incubator-dubbo/releases/tag/untagged-e1d19049b2cf34245de8
 


Best regards,
Jun

> On 24 Apr 2018, at 11:26 AM, Huxing Zhang  wrote:
> 
> Hi,
> 
> On Mon, Apr 23, 2018 at 8:12 PM, Jun Liu  wrote:
>> Hey community,
>> 
>> The release of dubbo v2.6.2 is on progress now, and we expect to launch the
>> official vote for this release this week. The release candidates are
>> tracked in a milestone[1], and it is also the candidates that need to be
>> notified to community and confirmed from community before voting.
>> 
>> From your perspective:
>> 1. Any issues or features that should not be included but already exists in
>> milestone, for any reasons, for example, need further test.
> 
> If we do not have enough time, we can exclude issues with 'priority-low' tag.
> 
>> 2. Any issues or features that should be supported but not included yet.
> 
> I think this pull request should be included:
> https://github.com/apache/incubator-dubbo/pull/1620
> The exception stack trace in the demo makes user confused, which IMO
> need to be fixed in the next release.
> 
>> 3. Other suggestions.
>> Please reply to this mail directly or file an issue on github.
> 
>> 
>> [1]. https://github.com/apache/incubator-dubbo/milestone/15
>> 
>> Best regards,
>> Jun
> 
> -- 
> Best Regards！
> Huxing

Re: Plan to improve unit test and test coverage

[Wang Xin]

hi，Yunkun
 Yes, the team has been planning to complement unit testing. I think we will 
create a project to increase the test coverage.


Xin Wang
lovep...@hotmail.com



在 2018年4月25日，上午10:08，htynkn@ http://gmail.com> 
hty...@gmail.com> 写道：

hey team,

There is one issue opening 
(https://github.com/apache/incubator-dubbo/issues/1487) related to code 
coverage. But this is no further discuss about this issue. So I send this email 
to mail list.

Current code coverage is 35%, and refer to 
https://codecov.io/gh/apache/incubator-dubbo. There are many thing we can 
improve. so my question is do we have any plan about this stuff? like:

1.unit test standard
2.priority for each module
3.library can be used in unit test

If we already have a plan for this, I suggest create separate issue for each 
module in github issue board and mark as `ideal for contribution` or `for 
beginner`.

Regards,
Yunkun

Plan to improve unit test and test coverage

[htynkn]

hey team,

There is one issue opening 
(https://github.com/apache/incubator-dubbo/issues/1487) related to code 
coverage. But this is no further discuss about this issue. So I send this email 
to mail list.

Current code coverage is 35%, and refer to 
https://codecov.io/gh/apache/incubator-dubbo. There are many thing we can 
improve. so my question is do we have any plan about this stuff? like:

1.unit test standard
2.priority for each module
3.library can be used in unit test

If we already have a plan for this, I suggest create separate issue for each 
module in github issue board and mark as `ideal for contribution` or `for 
beginner`.

Regards,
Yunkun

Podling Report Reminder - May 2018

[johndament]

Dear podling,

This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.

The board meeting is scheduled for Wed, 16 May 2018, 10:30 am PDT.
The report for your podling will form a part of the Incubator PMC
report. The Incubator PMC requires your report to be submitted 2 weeks
before the board meeting, to allow sufficient time for review and
submission (Wed, May 02).

Please submit your report with sufficient time to allow the Incubator
PMC, and subsequently board members to review and digest. Again, the
very latest you should submit your report is 2 weeks prior to the board
meeting.

Candidate names should not be made public before people are actually
elected, so please do not include the names of potential committers or
PPMC members in your report.

Thanks,

The Apache Incubator PMC

Submitting your Report

--

Your report should contain the following:

*   Your project name
*   A brief description of your project, which assumes no knowledge of
the project or necessarily of its field
*   A list of the three most important issues to address in the move
towards graduation.
*   Any issues that the Incubator PMC or ASF Board might wish/need to be
aware of
*   How has the community developed since the last report
*   How has the project developed since the last report.
*   How does the podling rate their own maturity.

This should be appended to the Incubator Wiki page at:

https://wiki.apache.org/incubator/May2018

Note: This is manually populated. You may need to wait a little before
this page is created from a template.

Mentors
---

Mentors should review reports for their project(s) and sign them off on
the Incubator wiki page. Signing off reports shows that you are
following the project - projects that are not signed may raise alarms
for the Incubator PMC.

Incubator PMC

Re: About Keeping dubbo's version to be SNAPSHOT on master branch

[Ian Luo]

+1

Once we get the snapshot URL of apache maven repo, we could configure
travis CI to publish snapshots automatically once the build passes.

On Tue, Apr 24, 2018 at 11:30 AM, Mercy  wrote:

> Hi all,
>
>
> I suggest keeping *SNAPSHOT*  for new Dubbo developement version on
> master branch , is like Spring Projects approach
> . For
> example,  current release version of dubbo is *2.6.1*,  *2.6.2* will be
> next release and its *SNAPSHOT*(*2.6.2-SNAPSHOT) *cound be synchronized
> on master branch , the community developers could learn and use the latest
> code for new features that are traced in *2.6.2 *milestone, they don't
> have to wait next release and might participate in discuss.
>
>
> If you had any idea, let's discuss ! Thank you for your time.
>
>
> Kind regards,
>
> Mercy
>

Re: hessian-lite performance

[Ian Luo]

got it. It's JMH based test bench. We will look into it.

On Tue, Apr 24, 2018 at 1:07 PM, whanice  wrote:

> I use 100K String . and just call readString.  Here is the simple code:
>
> @Benchmark
> public void deserial(BenchmarkState state) throws Exception {
> ByteArrayInputStream bin = new ByteArrayInputStream(state.bytes);
> Hessian2Input input = new Hessian2Input(bin);
> String deserialize = input.readString();
> Assert.assertEquals(state.str, deserialize);
> }
>
> public static void main(String[] args) throws RunnerException {
> Options options = new OptionsBuilder()
> .include(HessianLitePerfTest.class.getSimpleName())
> .include(Hessian4PerfTest.class.getSimpleName())
> .warmupIterations(10)
> .measurementIterations(30)
> .threads(10)
> .mode(Mode.Throughput)
> .timeUnit(TimeUnit.SECONDS)
> .forks(1)
> .build();
>
> new Runner(options).run();
> }
>
>
>
>
>
>
> 2018-04-24 11:10 GMT+08:00 Ian Luo :
>
> > Hessian-lite is tailored from the original hessian in order to keep it
> > lightweight. From your test, it looks hessian 4 performs much much better
> > than hessian-lite and hessian 3. Would you mind to describe how you run
> the
> > test, or even better, share us your test code? Then we will consider to
> > upgrade to hessian 4 and deprecate hessian-lite.
> >
> > Thanks,
> > -Ian.
> >
> >
> > On Mon, Apr 23, 2018 at 8:01 PM, whanice  wrote:
> >
> > > I made a simply performance test in my mac to messure hessian.
> > > the result is
> > >
> > > Benchmark  Mode  Cnt Score Error  Units
> > > Hessian4PerfTest.deserial thrpt   30  4068.415 ± 189.925  ops/s
> > > HessianLitePerfTest.deserial  thrpt   30  1941.054 ±  77.005  ops/s
> > >
> > > We can see hessian4(4.0.37) performs much better than
> hessian-lite(3.2.2)
> > > in deserialization.
> > >
> > > So here comes the question
> > >
> > >- 1. What is the difference between hessian-lite(3.2.2) and
> hessian3?
> > >- 2. Can sync with hessian4?
> > >
> >
>

Re: I have updated issue #1447 "NettyHelper in netty extension populated Logger "InternalLogger" in netty."

[Ian Luo]

Hi Teclxl,

Pls. check my comments on https://github.com/alibaba/dubbo/issues/1447. To
help discuss this issue better, I push one sample code to
https://github.com/beiwei30/netty-dubbo-logging-test, feel free to send me
the revised copy to help us to understand your issue better.

Regards,
-Ian.


On Thu, Mar 15, 2018 at 11:22 AM, 刘 小磊  wrote:

> https://github.com/alibaba/dubbo/issues/1447
>
>
> The following is the new content.
>
> Added content in English. Help with Google Translate
>
> System is TCP server using Netty4, and Dubbo is specified to use Netty4.
> When I add LoggingHandler to ChannelPipeline of my System, The log is not
> expected.
> Like this:
> [image] 11850956/37442060-5a02eabc-283f-11e8-939a-68255f8912b2.png>
>
> I tracked the code and found the Logger is com.alibaba.dubbo.remoting.
> transport.netty4.logging.NettyHelper.DubboLogger instead of
> io.netty.util.internal.logging.Slf4JLogger. DubboLogger added other
> content arount the original log. The NeetyHelper replace the
> InternalLoggerFactory when Dubbo loading, like the code block above shows.
>
> By the way.
>
> My system build by Spring Boot, use default logging framework which is
> Slf4j + Logback.
> Dubbo's logger is not extend default logger, but replace it.
> [image] 11850956/37442386-0585c494-2841-11e8-8f8f-354e7f226726.png>
>
>

Re: GSoC student - Getting started.

[Huxing Zhang]

Congrats Raghu!

We are glad to offer help if needed :)

On Tue, Apr 24, 2018 at 12:57 PM, Ian Luo  wrote:
> congratulations Raghu, looking forward to working together with you soon :)
>
> On Tue, Apr 24, 2018 at 12:04 PM, Raghunandana Jayarama Reddy <
> rjayarama...@cs.stonybrook.edu> wrote:
>
>> Hi Team,
>>
>> My name is Raghu and I have been accepted as a GSoC-2018 student developer
>> for Apache Dubbo project this summer. I will be working on the enhancement
>> "Extending serialization protocols support for Apache Dubbo" with Jun Liu.
>> Thanks to my mentor Jun Liu for the continuous support during the proposal
>> stage and look forward to a lot of learning during the process Jun. Also,
>> I'm
>> very delighted to see the continuous engagement of the community during
>> this incubation phase & releases and I hope to help/contribute in whatever
>> way I can.
>>
>> Here's the link to my proposal-abstract.
>> https://summerofcode.withgoogle.com/projects/#4747840161579008
>>
>> I look forward to learning & taking suggestions, Inputs from you all.
>>
>> Thanks
>> Raghu
>>

-- 
Best Regards！
Huxing