[Discussion] About cancel vote for 2.6.2-RC1 and prepare RC2.

2018-05-21 Thread Jun Liu 
Hello community,

We have asked the apache PMC members to review and vote on the 2.6.2 RC, based 
on the feedbacks, especially those reported by Willem, Sebb, Ian and Justin, we 
are planning to prepare RC2 and start a new round of vote. 

Compared to RC1, RC2 plans to fix the following issues:
- Resolve scheme compatibility problems[1].
- Remove the MD5 hashes in RC1
- Rename the source release file to 'dubbo-incubating-2.6.2-source-release'.
- Polish the Code Conduct,  Contributing Doc, some pom files to remove some out 
of date informations.
- Remove some unrelated log files and empty directories from the source 
release, try to keep source release the same with release tag.
- Temporarily close checkstyle-plugin by default.

The apache vote thread:
https://lists.apache.org/thread.html/96af7381da0fbc1dc0895134abc5f8faf892a72061929489082f5e6a@%3Cgeneral.incubator.apache.org%3E
 


Discussion welcomed.

1. https://github.com/apache/incubator-dubbo/issues/1816 


Best regards,
Jun

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-21 Thread Mark Thomas 
On 21/05/18 07:32, Jun Liu wrote:



> we plan to solve this problem and start a new round of voting.

Where did the community discuss this? I'd expect to see a discussion on
a mailing list before a decision is announced.

Mark

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-21 Thread Jun Liu 
> 1. there is bunch of dubbo-2.6.2-SNAPSHOT  in the pom.xml file, I guess the
> maven release plugin doesn't take all of them.
> .//bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
> .//dependencies-bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
> .//distribution/pom.xml:2.6.2-SNAPSHOT-SNAPSHOT
> .//pom.xml:  dubbo-2.6.2-SNAPSHOT
> 
> 2. I checked the source zip[1], it is not same with github tag one[2].
> There are some log files and empty directories which is not in the git
> repo, I guess it relates to the builder's workspace.
> It could be addressed by generate the source release kit in the
> distribution like we did here[3].

We rely on the release and assembly plugin to finish these works, there may 
have some inappropriate plugin configuration. I will check the problems you 
mentioned and fix them by following your guides.

> 3. I tried to build the source from kit, it looks the check style is
> enabled when since JDK 1.8 and I just got the out of memory error there.
> I found there are comment about this check style issue (it takes lots of
> time and it doesn't work on my box). So I created an issue[4] of it.
> I can build the source by modify the pom to skip the check style check, but
> it kind of hiking , so I had to vote -1 (binding) for it.

During the internal dubbo community vote, Justin, Huxing and Ian also reported 
the checkstyle plugin problem (cost time and resources) when build. Since this 
problem has confused you and maybe others from building the source, we plan to 
solve this problem and start a new round of voting.
 
> 4. I checked the binary kit, it only includes the jars file of dubbo[5], as
> we cannot provide the apache maven release now, it could cause some trouble
> for the user to consume the binary without third party dependencies. Do we
> have any plan for it ?

Besides the apache binary release, we will also publish the convenient maven 
artifacts to the central maven repository, which are not mentioned in this vote 
thread since it’s not a necessary part of the apache release. This way, users 
can consume from the central repository as before. 
In the next release, when the groupid change to “org.apache.dubbo”, we will 
switch from central maven repository to apache maven repository, and will 
include the apache maven staging repo address in the vote. The current binary 
zip, as you point out "only includes the jars file of dubbo[5]”, will be 
removed or replaced with more meaningful bin release, such as samples or quick 
start guides which users can help users start the journey of dubbo quickly.

To conclude, we decide to start a new round of voting regarding the problems 
found during this round. Thanks for the vote.

Best regards,
Jun

> On 21 May 2018, at 10:34 AM, Willem Jiang  wrote:
> 
> Hi,
> 
> I did some check on the source zip and binary zip, the License and Notice
> files looks good. But I also found some issues here.
> As I cannot build the binary without doing some changes on the pom file, I
> had to vote -1 (binding) here.
> 
> Here are the issues that I found:
> 
> 1. there is bunch of dubbo-2.6.2-SNAPSHOT  in the pom.xml file, I guess the
> maven release plugin doesn't take all of them.
> .//bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
> .//dependencies-bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
> .//distribution/pom.xml:2.6.2-SNAPSHOT-SNAPSHOT
> .//pom.xml:  dubbo-2.6.2-SNAPSHOT
> 
> 2. I checked the source zip[1], it is not same with github tag one[2].
> There are some log files and empty directories which is not in the git
> repo, I guess it relates to the builder's workspace.
> It could be addressed by generate the source release kit in the
> distribution like we did here[3].
> BTW, it's quite important that every one can build the kit by following the
> instruction. I didn't found the instruction file from the README.
> 
> 3. I tried to build the source from kit, it looks the check style is
> enabled when since JDK 1.8 and I just got the out of memory error there.
> I found there are comment about this check style issue (it takes lots of
> time and it doesn't work on my box). So I created an issue[4] of it.
> I can build the source by modify the pom to skip the check style check, but
> it kind of hiking , so I had to vote -1 (binding) for it.
> 
> 4. I checked the binary kit, it only includes the jars file of dubbo[5], as
> we cannot provide the apache maven release now, it could cause some trouble
> for the user to consume the binary without third party dependencies. Do we
> have any plan for it ?
> 
> Another tip for the release check is running some applications which is
> build on the top of the framework to make sure all the distribution is good.
> 
> 
> [1]
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/dubbo-incubating-2.6.2-source-release.zip
> [2]https://github.com/apache/incubator-dubbo/archive/dubbo-2.6.2.zip
> [3]
>