Re: dubbo使用中的疑问

2018-11-08 Thread Ian Luo
google translation for yiji's reply: Dubbo default value will be reused to establish a tcp connection, nettyServerBootstrapAcceptor will listen, will use one of the childgroup and this channel to do the binding, other eventloop will only empty training, the bound channel thread will read and

Re: dubbo使用中的疑问

2018-11-08 Thread yuhang xiu
> > > 另外由于method/service均可设置该属性,多个属性会叠加这个问题 > 我对着保持怀疑态度,晚点我会仔细check一下 我也对这个存疑,目前来看method的connections属性对整体的连接数影响我还没有发现。测试了一下发现method设置的connections不会起作用。 Zonghai Shang 于2018年11月9日周五 上午11:16写道: > Hi, > > > 另外由于method/service均可设置该属性,多个属性会叠加这个问题 > > 我对着保持怀疑态度,晚点我会仔细check一下 > > -yiji > > Zonghai

?????? dubbo????????????

2018-11-08 Thread ????????
Generally, it is not recommended to set connections in the provider, so it is easy to connect to the storm when there are too many upstream consumers, so we generally set the connection limit (that is, accepts) in the provider, and the number of connections can be set on the consumer side as

Re: Optimize AbstractConfig toString method

2018-11-08 Thread Ian Luo
I agree with his proposed solution. In fact, in my opinion, this change will improve DEV experience. -Ian. On Fri, Nov 9, 2018 at 5:37 AM yuhang xiu wrote: > Hi, community > > Today @code4wt submitted a pr[1] call to getObject for optimizing the > abstractConfig toString method, which caused

Re: dubbo使用中的疑问

2018-11-08 Thread Ian Luo
+1, total agree with Jason's suggestion. On Fri, Nov 9, 2018 at 5:16 AM Jason Joo wrote: > Hi, > > 设置connection属性要慎重,建议从1起,因为对于connection=N,每个设置了该属性的项目会在连provider时每个provider除已连接的共用连接外均新建N个连接,也就是最终每个consumer是N > * n,对于每个provider则是N * m > > 其中, > n - provider数 > m - 消费数 > >

comments on pull request 2738: epoll support

2018-11-08 Thread Ian Luo
@zonghaishang, I dropped my comments on pull request 2738 [1]. Pls. take a look. Thanks, -Ian. 1. https://github.com/apache/incubator-dubbo/pull/2738

Re: Optimize retry in failbackregistry.

2018-11-08 Thread yuhang xiu
Hi, community I submitted a version of pr[1] to optimize retry, which has now passed CI detection. In the new version, all retries will follow RETRY_PERIOD. All tasks will be done independently, for ex: retry registry operations will not affect retry unregistry.

Re: Bug feedback

2018-11-08 Thread Ian Luo
awesome finding and analysis. I will merge your pull request once it passes CI :) Thanks, -Ian. On Thu, Nov 8, 2018 at 10:01 AM 田 小波 wrote: > I find a potential problem, it will result in ReferenceBean refers service > more than once when debugging or printing ReferenceBean. And make some >

Bug feedback

2018-11-08 Thread 田 小波
I find a potential problem, it will result in ReferenceBean refers service more than once when debugging or printing ReferenceBean. And make some strange error to confuse code reader. I can reappear this problem, and I have submitted a PR

Re: Bug feedback

2018-11-08 Thread Ian Luo
Xiaobo, I filed one issue [1] 2757 to track this. Regards, -Ian. 1. https://github.com/apache/incubator-dubbo/issues/2757 On Thu, Nov 8, 2018 at 10:47 AM Ian Luo wrote: > ps, pls. fix it on branch 2.6.x too. > > On Thu, Nov 8, 2018 at 10:46 AM Ian Luo wrote: > >> awesome finding and

Optimize AbstractConfig toString method

2018-11-08 Thread yuhang xiu
Hi, community Today @code4wt submitted a pr[1] call to getObject for optimizing the abstractConfig toString method, which caused some error messages and unexpected results when debugging. He gave a detailed analysis of the recurring problem and the cause of the problem [2], I personally think