Re: Telnet optimization suggest

2018-12-18 Thread
dubbo>ls
demoA:org.apache.dubbo.demo.DemoService:1.0.0
demoB:org.apache.dubbo.demo.DemoService:1.0.0

How about this.group:interface:version , this coordinate help us find
the unique exporter like maven。

Jason Joo  于2018年12月18日周二 下午1:55写道:

> And is there other situations to deal with? group/version/etc...
>
> For now there is only different implementations in same application and
> looks good to deal with.
>
> best regards,
>
> Jason
>
> > On Dec 18, 2018, at 10:33, yeling  wrote:
> >
> > Ok,I've created an issue.
> > https://github.com/apache/incubator-dubbo/issues/2988
> >
> > Ian Luo  于2018年12月17日周一 下午11:41写道:
> >
> >> Zhen,
> >>
> >>
> >>> 1. When my interface implements multiple services, and all of them are
> >>> exposed, using the Dubbo parameter group, at this time, under the
> telnet
> >>> command, I can not choose the service I want to invoke.
> >>
> >>
> >> I am afraid I fully understand the problem. Could you pls. file an
> issue on
> >> GitHub together with a sample service to reproduce the problem?
> >>
> >> Thanks,
> >> -Ian.
> >>
> >> On Mon, Dec 17, 2018 at 7:52 PM 李振  wrote:
> >>
> >>>>
> >>>> I will try to fix it。
> >>>
> >>
>
>


Re: Telnet optimization suggest

2018-12-18 Thread
I find that  exporter's key(group/interface:version:port  ,  maybe port is
superfluous ) will be the best choice
<http://www.baidu.com/link?url=c86bMSnXTGpprvOUWIFTlGwoUDIYB7Yh3zTtt7wQVT5RIQ3zxk_GstbMRS_KZHC_qsCt__Z14ij_Wu2PEXChkoICk8v0UFxudlWBnw4ppGm>
 .

yeling  于2018年12月18日周二 下午6:22写道:

> I think it's a good idea.
>
> 李振  于2018年12月18日周二 下午6:13写道:
>
> > dubbo>ls
> > demoA:org.apache.dubbo.demo.DemoService:1.0.0
> > demoB:org.apache.dubbo.demo.DemoService:1.0.0
> >
> > How about this.group:interface:version , this coordinate help us find
> > the unique exporter like maven。
> >
> > Jason Joo  于2018年12月18日周二 下午1:55写道:
> >
> > > And is there other situations to deal with? group/version/etc...
> > >
> > > For now there is only different implementations in same application and
> > > looks good to deal with.
> > >
> > > best regards,
> > >
> > > Jason
> > >
> > > > On Dec 18, 2018, at 10:33, yeling  wrote:
> > > >
> > > > Ok,I've created an issue.
> > > > https://github.com/apache/incubator-dubbo/issues/2988
> > > >
> > > > Ian Luo  于2018年12月17日周一 下午11:41写道:
> > > >
> > > >> Zhen,
> > > >>
> > > >>
> > > >>> 1. When my interface implements multiple services, and all of them
> > are
> > > >>> exposed, using the Dubbo parameter group, at this time, under the
> > > telnet
> > > >>> command, I can not choose the service I want to invoke.
> > > >>
> > > >>
> > > >> I am afraid I fully understand the problem. Could you pls. file an
> > > issue on
> > > >> GitHub together with a sample service to reproduce the problem?
> > > >>
> > > >> Thanks,
> > > >> -Ian.
> > > >>
> > > >> On Mon, Dec 17, 2018 at 7:52 PM 李振  wrote:
> > > >>
> > > >>>>
> > > >>>> I will try to fix it。
> > > >>>
> > > >>
> > >
> > >
> >
>


Re: Telnet optimization suggest

2018-12-17 Thread
>
> I will try to fix it。


Re: [ANN] New PPMC member: Yuhang Xiu

2018-12-20 Thread
Congratulations !

Xin Wang  于2018年12月20日周四 下午4:37写道:

> Hi Community,
>
> On behalf of the Dubbo PPMC, I am pleased to announce that Yuhang Xiu[1]
> has been voted in as a new Dubbo PPMC member.
>
> Please join me to say congratulations to him!
>
> [1] https://github.com/carryxyh
> --
> Best Regards!
>
> Xin Wang
>


Re: New contributors for community

2018-12-07 Thread
You forget me .I want to contribute to the community too.
You can assign some issues to me .

yuhang xiu  于2018年12月7日周五 下午4:49写道:

> 社区的各位大家好。
>
> 前几天,我发送了一封邮件,关于我会分发一些issue给一些对dubbo有兴趣的新人,让他们参与到dubbo中,从而更好的建设整个社区。
>
> 在早些时候,我分发了四个issue给四个新人,他们分别是下面四个PR的作者:
> https://github.com/apache/incubator-dubbo/pull/2831
> https://github.com/apache/incubator-dubbo/pull/2893
> https://github.com/apache/incubator-dubbo/pull/2822
> https://github.com/apache/incubator-dubbo/pull/2848
>
> 其中有两个的pr已经被merge,另外两个还在等待review和处理。
>
> 他们四位来自同一个公司,现在我很高兴向大家介绍其中的三位:@huaifeng @zhuzi @yeling。
>
> 以后我们的所有讨论都会从线下的IM移动到邮件列表。这是他们第一次来到这里,@huaifeng @zhuzi @yeling 你们愿意介绍一下自己么?
>
> 顺便说一句,还有一位新人的手头还有一些紧急的工作,所以还没有订阅我们的邮件列表。@huaifeng @zhuzi @yeling
> 你们愿意帮助他们订阅邮件列表并且把他们带到这里来么?
>
>
> 
>
> Hello everyone in the community.
>
> A few days ago, I sent an email about I will distribute some issues to
> newcomers who are interested in dubbo and let them participate in dubbo to
> better build the entire community.
>
> Earlier, I circulated a four issue to the four newcomers, they are PR
> author of the following four:
> Https://github.com/apache/incubator-dubbo/pull/2831
> Https://github.com/apache/incubator-dubbo/pull/2893
> Https://github.com/apache/incubator-dubbo/pull/2822
> Https://github.com/apache/incubator-dubbo/pull/2848
>
> Two of the prs have been merged, and the other two are still waiting for
> review and processing.
>
> The four of them are from the same company, and now I am very happy to
> introduce three of them: @huaifeng @zhuzi @yeling.
>
> All of our discussions in the future will move from the offline IM to the
> mailing list. This is the first time they both came here, @huaifeng @zhuzi
> @yeling Are you willing to introduce yourself?
>
> By the way, there is a newcomer who has some urgent work on hand, so I
> haven't subscribed to our mailing list yet. @huaifeng @zhuzi @yeling Are
> you willing to help them subscribe to the mailing list and bring them here?
>


Re: New contributors for community

2018-12-07 Thread
I has just talked to you in wechat yesterday . 


yuhang xiu  于2018年12月7日周五 下午5:07写道:

> they are my friends. I didn't know you before, so there is no way to
> contact you.
>
> But welcome to dubbo. Next time I will distribute the issue directly on the
> mailing list. You can participate in the discussion directly here.
>
> 李振  于2018年12月7日周五 下午4:55写道:
>
> > You forget me .I want to contribute to the community too.
> > You can assign some issues to me .
> >
> > yuhang xiu  于2018年12月7日周五 下午4:49写道:
> >
> > > 社区的各位大家好。
> > >
> > > 前几天,我发送了一封邮件,关于我会分发一些issue给一些对dubbo有兴趣的新人,让他们参与到dubbo中,从而更好的建设整个社区。
> > >
> > > 在早些时候,我分发了四个issue给四个新人,他们分别是下面四个PR的作者:
> > > https://github.com/apache/incubator-dubbo/pull/2831
> > > https://github.com/apache/incubator-dubbo/pull/2893
> > > https://github.com/apache/incubator-dubbo/pull/2822
> > > https://github.com/apache/incubator-dubbo/pull/2848
> > >
> > > 其中有两个的pr已经被merge,另外两个还在等待review和处理。
> > >
> > > 他们四位来自同一个公司,现在我很高兴向大家介绍其中的三位:@huaifeng @zhuzi @yeling。
> > >
> > > 以后我们的所有讨论都会从线下的IM移动到邮件列表。这是他们第一次来到这里,@huaifeng @zhuzi @yeling
> > 你们愿意介绍一下自己么?
> > >
> > > 顺便说一句,还有一位新人的手头还有一些紧急的工作,所以还没有订阅我们的邮件列表。@huaifeng @zhuzi @yeling
> > > 你们愿意帮助他们订阅邮件列表并且把他们带到这里来么?
> > >
> > >
> > >
> >
> 
> > >
> > > Hello everyone in the community.
> > >
> > > A few days ago, I sent an email about I will distribute some issues to
> > > newcomers who are interested in dubbo and let them participate in dubbo
> > to
> > > better build the entire community.
> > >
> > > Earlier, I circulated a four issue to the four newcomers, they are PR
> > > author of the following four:
> > > Https://github.com/apache/incubator-dubbo/pull/2831
> > > Https://github.com/apache/incubator-dubbo/pull/2893
> > > Https://github.com/apache/incubator-dubbo/pull/2822
> > > Https://github.com/apache/incubator-dubbo/pull/2848
> > >
> > > Two of the prs have been merged, and the other two are still waiting
> for
> > > review and processing.
> > >
> > > The four of them are from the same company, and now I am very happy to
> > > introduce three of them: @huaifeng @zhuzi @yeling.
> > >
> > > All of our discussions in the future will move from the offline IM to
> the
> > > mailing list. This is the first time they both came here, @huaifeng
> > @zhuzi
> > > @yeling Are you willing to introduce yourself?
> > >
> > > By the way, there is a newcomer who has some urgent work on hand, so I
> > > haven't subscribed to our mailing list yet. @huaifeng @zhuzi @yeling
> Are
> > > you willing to help them subscribe to the mailing list and bring them
> > here?
> > >
> >
>


Re: [PR-2803]: Fix telnet can not find method with enum type

2018-12-10 Thread
@Ian Luo

我感觉你建议的改法可能有些问题,我的方案只是性能不好,但是我认为telnet 用途主要是debug ,可以不太关注性能。

 I feel that your proposed modification may have some problems. My solution
is just poor performance, but I think telnet is mainly used for debugging,
and can pay less attention to performance.

Ian Luo  于2018年12月10日周一 下午4:58写道:

> @LiZhenNet,
>
> I left my review comments on PR2803 [1], pls. take a look when you notice
> this email.
>
> Thanks,
> -Ian.
>
> 1. https://github.com/apache/incubator-dubbo/pull/2803
>


Re: Telnet optimization suggest

2018-12-18 Thread
Great ! It's  better than my pr, I have closed my pr。

Ian Luo  于2018年12月19日周三 下午1:48写道:

> I am working on it. Hopefully I can share my pull request for review soon.
>
> -Ian.
>
> On Tue, Dec 18, 2018 at 6:32 PM 李振  wrote:
>
> > I find that  exporter's key(group/interface:version:port  ,  maybe port
> is
> > superfluous ) will be the best choice
> > <
> >
> http://www.baidu.com/link?url=c86bMSnXTGpprvOUWIFTlGwoUDIYB7Yh3zTtt7wQVT5RIQ3zxk_GstbMRS_KZHC_qsCt__Z14ij_Wu2PEXChkoICk8v0UFxudlWBnw4ppGm
> > >
> >  .
> >
> > yeling  于2018年12月18日周二 下午6:22写道:
> >
> > > I think it's a good idea.
> > >
> > > 李振  于2018年12月18日周二 下午6:13写道:
> > >
> > > > dubbo>ls
> > > > demoA:org.apache.dubbo.demo.DemoService:1.0.0
> > > > demoB:org.apache.dubbo.demo.DemoService:1.0.0
> > > >
> > > > How about this.group:interface:version , this coordinate help us
> > find
> > > > the unique exporter like maven。
> > > >
> > > > Jason Joo  于2018年12月18日周二 下午1:55写道:
> > > >
> > > > > And is there other situations to deal with? group/version/etc...
> > > > >
> > > > > For now there is only different implementations in same application
> > and
> > > > > looks good to deal with.
> > > > >
> > > > > best regards,
> > > > >
> > > > > Jason
> > > > >
> > > > > > On Dec 18, 2018, at 10:33, yeling  wrote:
> > > > > >
> > > > > > Ok,I've created an issue.
> > > > > > https://github.com/apache/incubator-dubbo/issues/2988
> > > > > >
> > > > > > Ian Luo  于2018年12月17日周一 下午11:41写道:
> > > > > >
> > > > > >> Zhen,
> > > > > >>
> > > > > >>
> > > > > >>> 1. When my interface implements multiple services, and all of
> > them
> > > > are
> > > > > >>> exposed, using the Dubbo parameter group, at this time, under
> the
> > > > > telnet
> > > > > >>> command, I can not choose the service I want to invoke.
> > > > > >>
> > > > > >>
> > > > > >> I am afraid I fully understand the problem. Could you pls. file
> an
> > > > > issue on
> > > > > >> GitHub together with a sample service to reproduce the problem?
> > > > > >>
> > > > > >> Thanks,
> > > > > >> -Ian.
> > > > > >>
> > > > > >> On Mon, Dec 17, 2018 at 7:52 PM 李振 
> wrote:
> > > > > >>
> > > > > >>>>
> > > > > >>>> I will try to fix it。
> > > > > >>>
> > > > > >>
> > > > >
> > > > >
> > > >
> > >
> >
>