Re: [Discussion] About cancel vote for 2.6.2-RC1 and prepare RC2.

[Wang Xin]

+1 ， support  to start the RC2
Xin Wang
lovep...@hotmail.com



在 2018年5月22日，下午5:24，Huxing Zhang > 
写道：

+1 Looks good to me,  let's do RC2.

On Tue, May 22, 2018 at 11:04 AM, Jun Liu 
> wrote:
Hello community,

We have asked the apache PMC members to review and vote on the 2.6.2 RC, based 
on the feedbacks, especially those reported by Willem, Sebb, Ian and Justin, we 
are planning to prepare RC2 and start a new round of vote.

Compared to RC1, RC2 plans to fix the following issues:
- Resolve scheme compatibility problems[1].
- Remove the MD5 hashes in RC1
- Rename the source release file to 'dubbo-incubating-2.6.2-source-release'.
- Polish the Code Conduct,  Contributing Doc, some pom files to remove some out 
of date informations.
- Remove some unrelated log files and empty directories from the source 
release, try to keep source release the same with release tag.
- Temporarily close checkstyle-plugin by default.

The apache vote thread:
https://lists.apache.org/thread.html/96af7381da0fbc1dc0895134abc5f8faf892a72061929489082f5e6a@%3Cgeneral.incubator.apache.org%3E
 


Discussion welcomed.

1. https://github.com/apache/incubator-dubbo/issues/1816 


Best regards,
Jun



--
Best Regards！
Huxing

Re: [VOTE] Accept the "Dubbox documentation" donation

[Wang Xin]

+1

Xin Wang
lovep...@hotmail.com



在 2018年5月17日，下午1:55，Huxing Zhang > 
写道：

Hi All,

Recently Dangdang has donated there documentation for dubbox[1], and a
software grant have been filed.

As suggested by Justin, we need to follow the ASF ip clearance process.

Therefore I am calling a vote:

[ ] +1 Accept the Dubbox documentation into Dubbo
[ ] -1 Do not accept the Dubbox documentation into Dubbo

[1] https://github.com/apache/incubator-dubbo-docs/pull/14

--
Best Regards！
Huxing

Re: Moving hessian-lite from Dubbo codebase to eco-system

[Wang Xin]

Agree +1> Now we are considering that moving it to Dubbo eco-system, which 
is https://github/dubbo.

The hessian-lit sub module is a serialize component of the same level as 
Thrift, and should be placed outside the core system.

Xin Wang
lovep...@hotmail.com



在 2018年5月14日，下午2:42，shang zonghai 
> 写道：

1. Can you just use their released version?

Internal version has fixed a lot of bugs, there is an incompatibility risk when 
using the release version in the short term. Before using the release version, 
we need to submit the repaired feature to owner / maintainers of hessian-lit.

yiji


在 2018年5月11日，16:02，Justin Mclean 
> 写道：

Hi,

Now we are considering that moving it to Dubbo eco-system, which is
https://github/dubbo.

How do you think about this?

I don’t know the history here so the answer to these questions may be obvious 
to someone eon the project. What do the owner / maintainers of hessian-lite 
think about that? Is there any need to fork their version? Can you just use 
their released version?

Thanks,
Justin

Re: How to package dubbo.jar correctly?

[Wang Xin]

Hi，Jun,
I have recorded this question：“ What's the difference between version 2.6.x and 
version 2.5.x ?”  in FAQ page
https://github.com/apache/incubator-dubbo/wiki/FAQ

You can add more details in it.

Xin Wang
lovep...@hotmail.com



在 2018年5月10日，上午8:07，Jun Liu > 写道：

Hi song,

However,  the pom file in official released artifact is 
https://github.com/apache/incubator-dubbo/blob/2.5.x/dubbo-maven/pom.xml
These 2 pom files are quite different, especially in the dependency scope part.

You can package to generate an all-in-one dubbo jar, and the only difference 
lay in the pom.xml file, right? I think you have used the right way packing 
dubbo, take a closer look, the transitive dependencies passed by these two pom 
files are the same. So you will use the pom.xml different from the official 
one, and it makes no difference for end users.

So I wonder what is the normal release process for dubbo.jar? Is there some 
configuration or step I missed?

The release process to central repository for 2.5.x or above is a tricky one, 
that’s also one of the reasons that we changed the pom structure of dubbo 
project in 2.6.x. As mentioned above, use 'mvn clean install -DskipTests=true’ 
directly, and ignore the 'dubbo-maven/pom.xml’, a pom file only works for 
central maven repository.

On 8 May 2018, at 10:44 AM, ss宋顺 > 
wrote:

Hi there,

I have a patch that needs 
to be applied to our organization first.
So I use the normal way - 'mvn clean install -DskipTests=true' to package the 
dubbo.jar (based on branch 2.5.x).
However, the pom file for the generated artifact is different from the one in 
the official released artifact.
Specifically, the pom file in my generated artifact is 
https://github.com/apache/incubator-dubbo/blob/2.5.x/dubbo/pom.xml
However,  the pom file in official released artifact is 
https://github.com/apache/incubator-dubbo/blob/2.5.x/dubbo-maven/pom.xml
These 2 pom files are quite different, especially in the dependency scope part.

So I wonder what is the normal release process for dubbo.jar? Is there some 
configuration or step I missed?
Looking forward to your guidance!

Thanks!
Jason

The issues of [Enhance the test coverage] project are here waiting for you

[Wang Xin]

Hi,all
  In order to enhance the test coverage, now the project is started: 
https://github.com/apache/incubator-dubbo/projects/1,
you can also see the related issues in the other entrance page: 
https://github.com/apache/incubator-dubbo/issues/1702
  The test coverage guide is 
here:https://github.com/apache/incubator-dubbo/wiki/Test-coverage-guide

  Welcome everyone to join in，you can comment on the issue that you're 
interest with.

Xin Wang
lovep...@hotmail.com

Re: Plan to improve unit test and test coverage

[Wang Xin]

hi，Yunkun
 Yes, the team has been planning to complement unit testing. I think we will 
create a project to increase the test coverage.


Xin Wang
lovep...@hotmail.com



在 2018年4月25日，上午10:08，htynkn@  
hty...@gmail.com> 写道：

hey team,

There is one issue opening 
(https://github.com/apache/incubator-dubbo/issues/1487) related to code 
coverage. But this is no further discuss about this issue. So I send this email 
to mail list.

Current code coverage is 35%, and refer to 
https://codecov.io/gh/apache/incubator-dubbo. There are many thing we can 
improve. so my question is do we have any plan about this stuff? like:

1.unit test standard
2.priority for each module
3.library can be used in unit test

If we already have a plan for this, I suggest create separate issue for each 
module in github issue board and mark as `ideal for contribution` or `for 
beginner`.

Regards,
Yunkun

Re: List volume and issue tracking

[Wang Xin]

+1，It’s good.
dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc



Xin Wang
lovep...@hotmail.com



在 2018年4月8日，下午2:40，Yong Zhu > 
写道：

2018-04-08 14:36 GMT+08:00 Huxing Zhang 
>:

+1

This breakdown looks good to me.


+1, It sounds good.



On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein 
> wrote:
Many projects choose this pattern:

dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc

All GitHub activity is required to be delivered to an ASF mailing list.
It
is up to the (P)PMC to choose which/how. But they cannot be sent to
/dev/null. The above pattern generally provides the right breakdown for
what information people what to monitor.

Cheers,
Greg Stein
Infrastructure Administrator, ASF


On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo 
> wrote:

I think this can be solved by distinguishing github notifications from
regular dev@dubbo.apache.org traffic.  For github 
notifications,
including issue and pull request, the update message should only go to
the
interested parties who are involved in this particular topic, but @dev
should never be the audience.

I guess @dev mail list is configured in 'Settings -> Integrations &
Services -> Email' for 
github.com/apache/inclubator-dubbo* 
projects. I
am
not sure who I should contact therefore I am here cc-ing
us...@infra.apache.org.

I suggest to remove @dev mail list from github subscription list.

Thanks,
-Ian.



On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang 
> wrote:

Hi,

I am +1 on split the traffic of @dev list.

The issue appears after migrating repo to ASF. I use
"label:asf-dubbo-dev -[github]" to filter out them. :(

On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu 
> wrote:
I have the same feeling.

IMO, all the issue emails should be sent to 
iss...@dubbo.apache.org,
all

+1. All issues and the comments should go there.

the PR emails should be sent to 
comm...@dubbo.apache.org. How do you
think?

-1. commit@ are used when code are committed to repo, I don't think
PRs should go there.
Once a PR is accepted, a message will be sent to commit@

My suggestion is PRs and the comments should go to issues@, or we can
create a new list prs@.

and who can help to fix this?

And I think we should use github issues, and move all the Jira
issues to
github.

2018-04-03 16:43 GMT+08:00 Mark Thomas 
>:

All,

I've been away for just over a week and come back to find over 300
unread emails on the dev list.

A large proportion of these messages are comments on pull requests?
Is
dev@ the right list for those?

Another large proportion appear to be comments on issues? Is dev@
the
right list for those?

Generally, the recommendation is to split into multiple lists based
on
audience rather than topic. For some projects it therefore makes
sense
to have all dev related traffic going to a single list. For others,
particularly large projects, it makes sense to split the dev
traffic.

The project appears to be using GitHub issues and Jira. That is
confusing. I'd recommend that you select one issue tracker and stick
to it.

There was discussion[1] on the mailing list and the community has
decided to use github issues.
My understanding is that currently JIRA is only used for GSOC ideas
and track existing issues prior to that decision.
I am +0 on migrating the existing JIRA issues to github issues.


Finally, the github issues seem to be a mix of bugs and support
questions. Is that the way the podling wants to use github issues?

People get used to ask questions by creating an issue before joining
ASF.
The PPMC are trying to tell users to use mailing list to ask questions
by leaving message on the issues, so does the website.
But I think it will take some time.


I have no view on what the 'right' answers to the above questions
are.
I'm asking them to get the podling thinking about the issues. What,
if
anything, to do about any of the above is for the podling to decide.


Mark



[1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b
ba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
--
Best Regards！
Huxing






--
Best Regards！
Huxing

Re: [GitHub] CLAassistant commented on issue #884: 添加method class缓存

[Wang Xin]

Mark,
Yes,the CLA assistant had been already removed .   but this PR is a old 
one,it should be the last check result is recorded, and there is no way to 
refresh it. But I think it's not a big problem

Xin Wang
lovep...@hotmail.com



在 2018年4月5日，下午4:06，Mark Thomas > 写道：

I thought the CLA assistant had been removed.

Mark


On 05/04/2018 05:17, GitBox wrote:
CLAassistant commented on issue #884: 添加method class缓存
URL: https://github.com/apache/incubator-dubbo/pull/884#issuecomment-345502043
   [![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/apache/incubator-dubbo?pullRequest=884)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you sign our [Contributor License 
Agreement](https://cla-assistant.io/apache/incubator-dubbo?pullRequest=884) 
before we can accept your contribution.**qi** seems not to be a 
GitHub user. You need a GitHub account to be able to sign the CLA. If you have 
already a GitHub account, please [add the email address used for this commit to 
your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/apache/incubator-dubbo?pullRequest=884)
 it.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services

Re: Delete the two duplicated projects: (dubbo/dubbo and dubbo/dubbo.github.io)？

[Wang Xin]

The https://github.com/dubbo/dubbo project is deleted, now 
https://github.com/apache/incubator-dubbo is the only  dubbo main project.

Xin Wang
lovep...@hotmail.com<mailto:lovep...@hotmail.com>



在 2018年3月27日，下午10:02，Huxing Zhang <hux...@apache.org<mailto:hux...@apache.org>> 
写道：

Hi,

On Tue, Mar 27, 2018 at 9:26 PM, Wang Xin 
<lovep...@hotmail.com<mailto:lovep...@hotmail.com>> wrote:
Hi，all
Now we have two duplicated projects:
https://github.com/dubbo/dubbo  forked from 
https://github.com/apache/incubator-dubbo
https://github.com/dubbo/dubbo.github.io  copied from 
https://github.com/apache/incubator-dubbo-website

I think : if we delete  https://github.com/dubbo/dubbo, we can focus on  
https://github.com/apache/incubator-dubbo

+1.

One thing that need to be mentioned is that check if we can redirect
from dubbo/dubbo to apache/incubator-dubbo.
I am not sure if it is possible, since dubbo/dubbo is forked from
apache/incubator-dubbo.
Even if it isn't possible, I still think it can be deleted given that
it has only 13 stars and 10 watches.


 https://github.com/dubbo/dubbo.github.io   is a 
duplicate，although it is still useful now.

+1

It is a temporary repo during dubbo.io<http://dubbo.io> repo transition.
I've checked that dubbo.io<http://dubbo.io> now redirects to 
dubbo.apache.org<http://dubbo.apache.org>.

~ curl dubbo.io<http://dubbo.io>


 
   
   http://dubbo.apache.org; />
   DUBBO
   
   window.location.href="<a  rel="nofollow" href="http://dubbo.apache.org&quot">http://dubbo.apache.org&quot</a>;;
   
 
 
   http://dubbo.apache.org;>http://dubbo.apache.org
 


Once we confirm that dubbo/dubbo.github.io<http://dubbo.github.io> is not being 
used, we can remove it.




  What do you think about?


Xin Wang
lovep...@hotmail.com<mailto:lovep...@hotmail.com><mailto:lovep...@hotmail.com>






--
Best Regards！
Huxing

Re: The new release version v2.5.10 has missed a feature, how can we avoid it?

[Wang Xin]

https://github.com/alibaba/dubbo/milestone/13 -->v2.6.1
https://github.com/alibaba/dubbo/milestone/16 -->v2.5.11
Now the two milestones contains this patch, I think v2.6.1 will be published 
soon.

Xin Wang
lovep...@hotmail.com<mailto:lovep...@hotmail.com>



在 2018年3月14日，下午8:45，kext gmail <luff...@gmail.com<mailto:luff...@gmail.com>> 写道：

Hi,

May i know would this PR(https://github.com/alibaba/dubbo/pull/1401 
<https://github.com/alibaba/dubbo/pull/1401>) merged to 2.5.11? and when 
release 2.5.11?
Because this issue introduces many issues in dubbo-spring-boot-starter project.

Best Regards,
Tang Ke

下面是被转发的邮件：

发件人: jun liu <ken.lj...@gmail.com<mailto:ken.lj...@gmail.com>>
主题: 回复： The new release version v2.5.10 has missed a feature, how can we avoid 
it?
日期: 2018年3月14日 GMT+8 09:46:20
收件人: dev@dubbo.apache.org<mailto:dev@dubbo.apache.org>
回复－收件人: dev@dubbo.apache.org<mailto:dev@dubbo.apache.org>

BTW, since you have mentioned the release of v2.5.10, i think there’s no need 
for a separate release announcement on the mailing list.
I’ve create an announcement on github: 
https://github.com/alibaba/dubbo/issues/1465 
<https://github.com/alibaba/dubbo/issues/1465>

On 14 Mar 2018, at 9:36 AM, jun liu 
<ken.lj...@gmail.com<mailto:ken.lj...@gmail.com>> wrote:

How can we avoid it?  I think we can do like this :
   1. When you create a pull request，you should choose a branch  as base branch 
(master or 2.5.x).
   2. If it is a bug branch, should be created  using 2.5.x branch as a basic 
branch, sign a "bug" tag in the issue.
   Else if a new feature, should use master branch as a basic branch,sign a 
"enhancement feature" tag .

For contributors, please make sure all changes on the right base branch, that 
is, only use 2.5.x branch for bugfixes, otherwise use master.

For committers, make sure select the right label and target branch for every 
PR, make sure 2.5.x merge to master as soon as possible。

On 13 Mar 2018, at 4:43 PM, Wang Xin 
<lovep...@hotmail.com<mailto:lovep...@hotmail.com>> wrote:

Hi ，all

  Recently,the v2.5.10 is published. It is from 2.5.x branch.  But a PR 
(https://github.com/alibaba/dubbo/pull/1401)  I created is missed.  Because my 
PR is merged to master branch,but not be merged to 2.5.x

 How can we avoid it?  I think we can do like this :
   1. When you create a pull request，you should choose a branch  as base branch 
(master or 2.5.x).
   2. If it is a bug branch, should be created  using 2.5.x branch as a basic 
branch, sign a "bug" tag in the issue.
   Else if a new feature, should use master branch as a basic branch,sign a 
"enhancement feature" tag .

What do you think about?

Xin Wang
lovep...@hotmail.com<mailto:lovep...@hotmail.com><mailto:lovep...@hotmail.com>

How to add Apache license head to the files of hessian-lite sub project

[Wang Xin]

Hi,all
   Now I’m adding Apache license head to the Dubbo project.  I find that 
,the hessian-lite sub project is totally  copied from hessian project 
(http://hessian.caucho.com/) , it’s package is modified and maintained here.
   The hessian project complies with Apache license 1.1. The license head in 
each file is as the following:
  What should I do with it?

/*
 * Copyright (c) 2001-2004 Caucho Technology, Inc.  All rights reserved.
 *
 * The Apache Software License, Version 1.1
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1. Redistributions of source code must retain the above copyright
 *notice, this list of conditions and the following disclaimer.
 *
 * 2. Redistributions in binary form must reproduce the above copyright
 *notice, this list of conditions and the following disclaimer in
 *the documentation and/or other materials provided with the
 *distribution.
 *
 * 3. The end-user documentation included with the redistribution, if
 *any, must include the following acknowlegement:
 *   "This product includes software developed by the
 *Caucho Technology (http://www.caucho.com/)."
 *Alternately, this acknowlegement may appear in the software itself,
 *if and wherever such third-party acknowlegements normally appear.
 *
 * 4. The names "Burlap", "Resin", and "Caucho" must not be used to
 *endorse or promote products derived from this software without prior
 *written permission. For written permission, please contact
 *i...@caucho.com.
 *
 * 5. Products derived from this software may not be called "Resin"
 *nor may "Resin" appear in their names without prior written
 *permission of Caucho Technology.
 *
 * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED.  IN NO EVENT SHALL CAUCHO TECHNOLOGY OR ITS CONTRIBUTORS
 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
 * OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
 * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
 * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
 * OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
 * IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * @author Scott Ferguson
 */


Xin Wang
lovep...@hotmail.com

Re: What's the relationship between 2.5.x and 2.6.x?

[Wang Xin]

As Jun’s plan：2.5.x is a bug fix branch,and 2.6.x is a new feature branch.
The detail is here:
https://github.com/alibaba/dubbo/issues/1208

Xin Wang
lovep...@hotmail.com



在 2018年3月11日，上午10:51，kext gmail > 
写道：

Hi,

As i know, 2.6.x which is merged dubbox contributed by dangdang with REST 
feature(reference release log for more: 
https://github.com/alibaba/dubbo/releases/tag/dubbo-2.6.0 
).

And 2.5.x would be the normal release for dubbo.

Pls correct me if there is any wrong.

Best Regards,
Tang Ke

在 2018年3月8日，18:35，? ?? > 写道：




leyou...@live.cn

Re: [DISCUSS] JIRA or Github issues

[Wang Xin]

+1 to support github issue

Xin Wang
lovep...@hotmail.com



在 2018年3月7日，下午4:55，Ian Luo > 写道：

+1 to stick to github issue (if Apache’s policy on this area is flexible)

-Ian.


On 7 Mar 2018, at 4:38 PM, Von Gosling 
> wrote:


Very glad to see our early discussion in the incubator stage, I totally agree 
and prefer the issues as Dubbo issue tacking infra.

One hint, if we choose the issues, we must be cautious with the label choose 
for effective group or classification management(just as components feature on 
jira) work :-)

Best Regards,
Von Gosling

在 2018年3月7日，16:27，Adrian Cole 
> 写道：

non-binding opinion from an integrator:

dubbo is an RPC layer, so it has a lot of integrators on top. It has a
history in github as well, and people are used to doing issues. I
would suggest maintaining github issues as ecosystem-related change
that is in github is far easier to track this way. For example, I've
made many issues in different dubbo repositories, and cross linked to
zipkin seamlessly. I like that it is easy.