Re: Requirements for upgrading the netty4 version

2018-07-04 Thread Ian Luo
I think we should not only upgrade netty4 to its latest release, but also switch it to the default transporter option. I filed one issue to track, and I am on it :) Regards, -Ian. On Thu, Jul 5, 2018 at 8:48 AM Yunkun Huang wrote: > I think it's a good thing to upgrade netty dependency to the

Re: Requirements for upgrading the netty4 version

2018-07-04 Thread Yunkun Huang
I think it's a good thing to upgrade netty dependency to the latest version. (maybe not just for netty, we may need a plan to keep all third-party dependencies updated) we may also go through changelogs to double check if there is another necessary change we need make. Regards, Yunkun On

Re: Requirements for upgrading the netty4 version

2018-07-04 Thread Xin Wang
+1 A complete test is required Yong Zhu 于2018年7月4日周三 下午6:01写道: > +1 > > Make sure the compatibility. > > On Wed, Jul 4, 2018 at 5:58 PM yuhang xiu wrote: > > > agree. > > > > 2018-07-04 17:56 GMT+08:00 Zonghai Shang : > > > > > Hi Dubbers! > > > > > > Because the `dubbo-rpc-http2` and `etcd3`

Re: Requirements for upgrading the netty4 version

2018-07-04 Thread Yong Zhu
+1 Make sure the compatibility. On Wed, Jul 4, 2018 at 5:58 PM yuhang xiu wrote: > agree. > > 2018-07-04 17:56 GMT+08:00 Zonghai Shang : > > > Hi Dubbers! > > > > Because the `dubbo-rpc-http2` and `etcd3` registry modules have been > > scheduled into the development plan, but will rely on the

Re: Requirements for upgrading the netty4 version

2018-07-04 Thread yuhang xiu
agree. 2018-07-04 17:56 GMT+08:00 Zonghai Shang : > Hi Dubbers! > > Because the `dubbo-rpc-http2` and `etcd3` registry modules have been > scheduled into the development plan, but will rely on the > `netty-http2-codec` feature provided by netty (not supported by netty > version 4.0.35). It is

Requirements for upgrading the netty4 version

2018-07-04 Thread Zonghai Shang
Hi Dubbers! Because the `dubbo-rpc-http2` and `etcd3` registry modules have been scheduled into the development plan, but will rely on the `netty-http2-codec` feature provided by netty (not supported by netty version 4.0.35). It is recommended to upgrade to the 4.1.25-final version and perform a