Github user mizeng closed the pull request at:
https://github.com/apache/incubator-eagle/pull/352
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mizeng commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74903923
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java
---
@@
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74900271
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java
---
@@
Github user mizeng commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899429
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
---
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899312
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/router/publishments.json
---
@@ -0,0 +1,23 @@
+[
+{
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899163
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
Github user mizeng commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899209
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java
---
@@
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74898917
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java
---
@@
GitHub user mizeng opened a pull request:
https://github.com/apache/incubator-eagle/pull/352
EAGLE-462: Alert Dudup
1. same metric generate alert should be deduped
2. user can define tags which is considered by dedup. by default will only
consider about policyId and