Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/556#discussion_r84639463
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertKafkaPublisher.java
---
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/556#discussion_r84639212
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertKafkaPublisher.java
---
GitHub user garrettlish opened a pull request:
https://github.com/apache/incubator-eagle/pull/556
EAGLE-670: make kafka publisher configurable and default is async
Kafka send alert in sync would limit the throughput. Make this
configurable, and use async by default
You can merge
