[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings

2016-11-14 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/647 @koone As the PR changed too many files, please it may take a few days for reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings

2016-11-14 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/647 @koone thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings

2016-11-14 Thread koone
Github user koone commented on the issue: https://github.com/apache/incubator-eagle/pull/647 @haoch the last commit is already roolback the code format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings

2016-11-14 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/647 Could you please rollback the code format of files under `org.apache.eagle.query.antlr.generated` too? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings

2016-11-13 Thread koone
Github user koone commented on the issue: https://github.com/apache/incubator-eagle/pull/647 revert eagle-antlr and exclude Classes under ` org.apache.eagle.query.antlr.generated` from checstyle @haoch could you please check again --- If your project is set up for it, you can

[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings

2016-11-13 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/647 Classes under `org.apache.eagle.query.antlr.generated` is automatically generated by `antlr`, so suggest to exclude it from checkstyle and keep the original code. --- If your project is set