[GitHub] incubator-eagle pull request #412: This is for code review only: EAGLE-432 A...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-eagle/pull/412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-eagle pull request #412: This is for code review only: EAGLE-432 A...

2016-09-07 Thread DadanielZ
Github user DadanielZ commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/412#discussion_r77945175 --- Diff: eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/impl/ApplicationManagementServiceImpl.java --- @@

[GitHub] incubator-eagle pull request #412: This is for code review only: EAGLE-432 A...

2016-09-07 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/412#discussion_r77814146 --- Diff: eagle-server/src/main/java/org/apache/eagle/server/ServerApplication.java --- @@ -69,5 +78,11 @@ public void run(ServerConfig configuration,

[GitHub] incubator-eagle pull request #412: This is for code review only: EAGLE-432 A...

2016-09-07 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/412#discussion_r77813561 --- Diff: eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/impl/ApplicationManagementServiceImpl.java --- @@ -112,14

[GitHub] incubator-eagle pull request #412: This is for code review only: EAGLE-432 A...

2016-09-07 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/412#discussion_r77813044 --- Diff: eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/resource/ApplicationResource.java --- @@ -18,24 +18,55 @@

[GitHub] incubator-eagle pull request #412: This is for code review only: EAGLE-432 A...

2016-09-07 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/412#discussion_r77812110 --- Diff: eagle-core/eagle-app/eagle-app-base/pom.xml --- @@ -102,5 +102,9 @@ junit compile +