[GitHub] incubator-eagle pull request #492: EAGLE-609: Fix nullPointerException in De...

2016-10-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/492


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request #492: EAGLE-609: Fix nullPointerException in De...

2016-10-11 Thread haoch
Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/492#discussion_r82824325
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert-app/src/main/resources/META-INF/providers/org.apache.eagle.alert.app.AlertUnitTopologyAppProvider.xml
 ---
@@ -25,6 +25,12 @@
 

 
+topology.name
+topology.name
+alertUnitTopology_1
--- End diff --

I think we should not keep current implementation only supporting 
hard-coded "alertUnitTopology_1", and  coordinator should be able to easily fix 
it to use actual topology name accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---