+1 binding
Checked:
- The release file is in the right location
- Signature and hash are correct.
- Version is correct in package.json
- Can build from source.
- LICENSE and NOTICE file exist
- NOTICE year correct
Thanks
*Ovilia*
On Tue, Feb 2, 2021 at 7:00 PM Ville Brofeldt
wrote:
Hi all,
Thanks for this release candidate; I can confirm that all chart types based on
ECharts in master branch of Apache Superset work on 5.0.2rc1, and the fix
introduced in #14108 (pie chart rendering bug) is particularly welcomed and
working as expected.
+1 (not binding)
Ville
> On 1.
+1!
On Mon, Feb 1, 2021 at 5:51 PM Zhongxiang Wang wrote:
> +1 (binding)
>
> Checked as follows,
>
> - The release files are in the correct location.
> - The digital signature and hashes are correct.
> - LICENSE, and NOTICE files exist and the text of each of them is correct.
> - NOTICE year is
+1 (binding)
Checked as follows,
- The release files are in the correct location.
- The digital signature and hashes are correct.
- LICENSE, and NOTICE files exist and the text of each of them is correct.
- NOTICE year is correct.
- Can build successfully from the source and the build
+1 binding
Checked:
- The release file is in the right location
- Signature and hash are correct.
- Version is correct in package.json
- Can build from source.
- Can run example with built file.
- LICENSE and NOTICE file exist
- NOTICE year correct
On Mon, Feb 1, 2021 at 10:00 PM SHUANG
