[jira] [Commented] (EDGENT-179) console: oplet coloring gradients "too close"
[ https://issues.apache.org/jira/browse/EDGENT-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524187#comment-15524187 ] Queenie Ma commented on EDGENT-179: --- I think that's a good idea, and I'll work on implementing it. Thank you for your input! > console: oplet coloring gradients "too close" > - > > Key: EDGENT-179 > URL: https://issues.apache.org/jira/browse/EDGENT-179 > Project: Edgent > Issue Type: Bug > Components: Console >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Minor > Attachments: EDGENT-179_oplet_colors.png, Screen Shot 2016-09-19 at > 2.22.00 PM.png > > > The oplet color generator ends up yielding two light purple-ish colors for > two different kinds of (adjacent) oplets and one can't tell them apart. One > is a Sink the other is a subtype of Peek - a StreamScope. > I was seeing this in a ParallelBalancedRecipe app of mine. I can provide it > if really necessary to repro/improve this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-179) console: oplet coloring gradients "too close"
[
https://issues.apache.org/jira/browse/EDGENT-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507280#comment-15507280
]
Queenie Ma commented on EDGENT-179:
---
Currently, the oplet colors are hard-coded by oplet kind ({{invocation.kind}})
in {{graph.js}}. The issue wih the "ParallelBalancedRecipe" sample is that the
Peek oplet's kind ({{org.apache.edgent.oplet.functional.Peek}}) was not defined
in {{graph.js}}, so its color was generated randomly and was chosen to be the
same color as the Union oplet. To fix this bug, we need to assign a new color
to this Peek oplet.
However, I suspect that other oplet kinds may have been missed when hard-coding
these colors. Is there a way to get a list of all possible kinds without
manually looking at each of the classes?
In the future, if an oplet kind has not been assigned a color (e.g., because it
was missed or because it is new), I think it would be a good idea to perhaps
hard-code a set of unused colors and pick one of them to assign to the oplet
kind. This way, there will be no overlap.
> console: oplet coloring gradients "too close"
> -
>
> Key: EDGENT-179
> URL: https://issues.apache.org/jira/browse/EDGENT-179
> Project: Edgent
> Issue Type: Bug
> Components: Console
>Reporter: Dale LaBossiere
>Priority: Minor
> Attachments: EDGENT-179_oplet_colors.png, Screen Shot 2016-09-19 at
> 2.22.00 PM.png
>
>
> The oplet color generator ends up yielding two light purple-ish colors for
> two different kinds of (adjacent) oplets and one can't tell them apart. One
> is a Sink the other is a subtype of Peek - a StreamScope.
> I was seeing this in a ParallelBalancedRecipe app of mine. I can provide it
> if really necessary to repro/improve this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (EDGENT-179) console: oplet coloring gradients "too close"
[ https://issues.apache.org/jira/browse/EDGENT-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504264#comment-15504264 ] Dale LaBossiere commented on EDGENT-179: The general problem still seems to exist. Since this jira was created, the console's handling Streamscope oplet was changed to make it like development provider injected metrics oplets - both small grey squares as see in your png. So Streamscope won't ever be a problem :-) When I try that "ParallelBalancedRecipe" sample now, it now shows the Peek and Union oplets as a blue color that's indistuinguishable to me. In the png I'll attach, the blue oplets with the 22 and 25 in them (they're really oplets 11 and 7 but that's a separate issue) are Peek oplets. The blue oplet with the 26 in it (really oplet 12) is a Union oplet. And you can see in the oplet legend that they look to be the same color. > console: oplet coloring gradients "too close" > - > > Key: EDGENT-179 > URL: https://issues.apache.org/jira/browse/EDGENT-179 > Project: Edgent > Issue Type: Bug > Components: Console >Reporter: Dale LaBossiere >Priority: Minor > Attachments: EDGENT-179_oplet_colors.png, Screen Shot 2016-09-19 at > 2.22.00 PM.png > > > The oplet color generator ends up yielding two light purple-ish colors for > two different kinds of (adjacent) oplets and one can't tell them apart. One > is a Sink the other is a subtype of Peek - a StreamScope. > I was seeing this in a ParallelBalancedRecipe app of mine. I can provide it > if really necessary to repro/improve this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-179) console: oplet coloring gradients "too close"
[
https://issues.apache.org/jira/browse/EDGENT-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504099#comment-15504099
]
Queenie Ma commented on EDGENT-179:
---
It looks like this may have been fixed in [PR
#116|https://github.com/apache/incubator-edgent/pull/116/commits/18c2480560544aa56cb904e0e5f351fbf956fcb7]
as the colors are not too similar anymore. StreamScope oplets are
{color:#c7c7c7}#c7c7c7{color} (light grey), and Sink oplets are
{color:#c5b0d5}#c5b0d5{color} (light purple). See screenshot.
[~dlaboss], is this okay to close?
> console: oplet coloring gradients "too close"
> -
>
> Key: EDGENT-179
> URL: https://issues.apache.org/jira/browse/EDGENT-179
> Project: Edgent
> Issue Type: Bug
> Components: Console
>Reporter: Dale LaBossiere
>Priority: Minor
> Attachments: EDGENT-179_oplet_colors.png
>
>
> The oplet color generator ends up yielding two light purple-ish colors for
> two different kinds of (adjacent) oplets and one can't tell them apart. One
> is a Sink the other is a subtype of Peek - a StreamScope.
> I was seeing this in a ParallelBalancedRecipe app of mine. I can provide it
> if really necessary to repro/improve this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
