Re: Review Request 41464: FALCON-1645 : Database export

2015-12-18 Thread Balu Vellanki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41464/#review111243 --- Ship it! Ship It! - Balu Vellanki On Dec. 18, 2015, 7:11 p.m.,

Re: Review Request 41464: FALCON-1645 : Database export

2015-12-18 Thread Venkatesan Ramachandran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41464/ --- (Updated Dec. 18, 2015, 7:11 p.m.) Review request for Falcon. Repository:

Re: Review Request 41464: FALCON-1645 : Database export

2015-12-18 Thread Ying Zheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41464/#review111285 --- Ship it! Ship It! - Ying Zheng On Dec. 18, 2015, 7:11 p.m.,

Re: Review Request 41464: FALCON-1645 : Database export

2015-12-17 Thread Balu Vellanki
> On Dec. 17, 2015, 2:17 a.m., Ying Zheng wrote: > > common/src/test/resources/config/feed/feed-export-0.1.xml, line 55 > > > > > > According to my understanding, the element "Locations" can be removed > > since you

Re: Review Request 41464: FALCON-1645 : Database export

2015-12-17 Thread Ying Zheng
> On Dec. 17, 2015, 2:17 a.m., Ying Zheng wrote: > > common/src/test/resources/config/feed/feed-export-0.1.xml, line 55 > > > > > > According to my understanding, the element "Locations" can be removed > > since you

Review Request 41464: FALCON-1645 : Database export

2015-12-16 Thread Venkatesan Ramachandran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41464/ --- Review request for Falcon. Repository: falcon-git Description ---

Re: Review Request 41464: FALCON-1645 : Database export

2015-12-16 Thread Balu Vellanki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41464/#review110762 --- There are checkstyle violations and one minor nit. The rest of the

Re: Review Request 41464: FALCON-1645 : Database export

2015-12-16 Thread Balu Vellanki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41464/#review110753 ---