[jira] [Updated] (FALCON-2232) Check for null feeds in getFeeds() in ExtensionBean

2016-12-29 Thread Pracheer Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pracheer Agarwal updated FALCON-2232: - Description: When we are returning feeds for an extension job, it is being returned as

[jira] [Updated] (FALCON-2232) Check for null feeds in getFeeds() in ExtensionBean

2016-12-29 Thread Pracheer Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pracheer Agarwal updated FALCON-2232: - Summary: Check for null feeds in getFeeds() in ExtensionBean (was: Check for null feeds

[jira] [Created] (FALCON-2232) Check for null feeds in ExtensionBean

2016-12-29 Thread Pracheer Agarwal (JIRA)
Pracheer Agarwal created FALCON-2232: Summary: Check for null feeds in ExtensionBean Key: FALCON-2232 URL: https://issues.apache.org/jira/browse/FALCON-2232 Project: Falcon Issue Type:

Re: Squashing commits before git push

2016-12-29 Thread Praveen Adlakha
I misread it. +1 for this. On Thu, Dec 29, 2016 at 5:22 PM, Praveen Adlakha wrote: > I believe we should be doing a rebase rather than pull and making a merge > commit. > > As far as 1 commit per pull request is concerned we should allow multiple > commits as for

Re: Squashing commits before git push

2016-12-29 Thread Pracheer Agarwal
+1 On Thu, Dec 29, 2016 at 4:53 PM, Sandeep Samudrala wrote: > Makes sense. > > On Thu, Dec 29, 2016 at 3:55 PM, Pallavi Rao > wrote: > > > While creating a PR, we tend to push the local commits as is when we do a > > git push into the forked repo.

Re: Squashing commits before git push

2016-12-29 Thread Sandeep Samudrala
Makes sense. On Thu, Dec 29, 2016 at 3:55 PM, Pallavi Rao wrote: > While creating a PR, we tend to push the local commits as is when we do a > git push into the forked repo. These local commits include lot of merge > commits, and intermediate commits. This makes it hard

Squashing commits before git push

2016-12-29 Thread Pallavi Rao
While creating a PR, we tend to push the local commits as is when we do a git push into the forked repo. These local commits include lot of merge commits, and intermediate commits. This makes it hard to review, when some changes have been requested (as the reviewer has to either look at changes