Re: [HEADS UP] Resolver optimizations

Yeah, I agree this is a valid concern. From a performance point of view, we'd have to gather a few different big test cases, but the previous changes lead to a factor 3 improvements. In this very specific case (the BigResolutionTest), the improvement for depth-first was an additional factory of

[jira] [Commented] (FELIX-4938) Throw an exception when service use count overflow

[ https://issues.apache.org/jira/browse/FELIX-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602694#comment-14602694 ] Alexandre Cartapanis commented on FELIX-4938: - Great !! For AtomicLong, i had

Re: [HEADS UP] Resolver optimizations

On 6/26/15 10:15 , David Bosschaert wrote: Looks like a great piece of work, Guillaume. I left some minor thoughts in a few places on github. One potential concern is that the change to depth-first search will produce different results than the previous approach. I wouldn't worry too much

[jira] [Created] (FELIX-4942) Optimise the resolver

Guillaume Nodet created FELIX-4942: -- Summary: Optimise the resolver Key: FELIX-4942 URL: https://issues.apache.org/jira/browse/FELIX-4942 Project: Felix Issue Type: New Feature

[jira] [Closed] (FELIX-4938) Throw an exception when service use count overflow

[ https://issues.apache.org/jira/browse/FELIX-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Cartapanis closed FELIX-4938. --- Good correction Throw an exception when service use count overflow

Re: [HEADS UP] Resolver optimizations

Hi Guillaume, What a work you did !! It looks really great ! I cloned your repo to test and take a deeper look. Thanks ! Regards JB On 06/26/2015 03:06 PM, Guillaume Nodet wrote: I've spent the last two weeks working on optimising the resolver. The results are available in the following

[jira] [Resolved] (FELIX-4938) Throw an exception when service use count overflow

[ https://issues.apache.org/jira/browse/FELIX-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert resolved FELIX-4938. - Resolution: Fixed Thanks! I have applied your patch. I modified it a little bit: * I also

[jira] [Assigned] (FELIX-4926) Investigate rewriting the resolver algorithm to use loops instead of recursion

[ https://issues.apache.org/jira/browse/FELIX-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned FELIX-4926: -- Assignee: Guillaume Nodet Investigate rewriting the resolver algorithm to use loops

[jira] [Commented] (FELIX-4871) The felix framework logger can't be used with reflection anymore

[ https://issues.apache.org/jira/browse/FELIX-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602808#comment-14602808 ] Guillaume Nodet commented on FELIX-4871: The logger needs to inherit the felix

[jira] [Commented] (FELIX-4942) Optimise the resolver

[ https://issues.apache.org/jira/browse/FELIX-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602814#comment-14602814 ] Guillaume Nodet commented on FELIX-4942: See

[HEADS UP] Resolver optimizations

I've spent the last two weeks working on optimising the resolver. The results are available in the following github fork https://github.com/gnodet/felix/commits/FELIX-4942 The commits are split so that they can be reviewed more easily. Most of them do not really change the algorithm in any

[jira] [Commented] (FELIX-4938) Throw an exception when service use count overflow

[ https://issues.apache.org/jira/browse/FELIX-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602690#comment-14602690 ] ASF GitHub Bot commented on FELIX-4938: --- Github user acartapanis closed the pull

[GitHub] felix pull request: Fix for bug #4938

Github user acartapanis closed the pull request at: https://github.com/apache/felix/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is