Re: [DISCUSS] First release of health check modules annotation, api, core, generalchecks and webconsoleplugin

2019-01-25 Thread Christian Schneider
+1 for a @RequireFelixHealthCheck annotation. I think we then also need an annotation for requiring the health check web console plugin, or do you see a way to automate this when web console is present. I just also checked where we could put the annotations. We have the bundles API and

Re: [VOTE] Release Apache Felix Gogo JLine 1.1.4

2019-01-25 Thread Francois Papon
+1 (non-binding) Thanks! Regards, François Papon fpa...@apache.org Le 25/01/2019 à 16:55, Jean-Baptiste Onofré a écrit : > Hi all, > > We solved 3 issues in this release (release notes): > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310100=12344851 > > Staging

Re: [DISCUSS] First release of health check modules annotation, api, core, generalchecks and webconsoleplugin

2019-01-25 Thread Raymond Auge
So, I wasn't suggesting to make an explicit requirement needed for this, but rather a convenience annotation similar to @RequireJaxrsWhiteboard [1] which is an annotation that I can use if I want to assert that the deployment will calculate that I want a JAXRS whiteboard dpeloyed. :) This is a

Re: Add my key to https://dist.apache.org/repos/dist/release/felix/KEYS

2019-01-25 Thread Karl Pauls
Done. regards, Karl On Fri, Jan 25, 2019 at 11:16 PM Georg Henzler wrote: > > Looks like the attachment didn't come through, so see [3] for the > contents of toadd.key > > On 2019-01-25 23:06, Georg Henzler wrote: > > Hi PMC-members, > > > > could someone please add my key to list [1] as

[jira] [Resolved] (FELIX-6026) SCR command problems

2019-01-25 Thread Thomas Watson (JIRA)
[ https://issues.apache.org/jira/browse/FELIX-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Watson resolved FELIX-6026. -- Resolution: Fixed Fix Version/s: scr-2.1.16 Will be fixed in 2.1.16 release. > SCR

[jira] [Commented] (FELIX-6026) SCR command problems

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FELIX-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752750#comment-16752750 ] ASF GitHub Bot commented on FELIX-6026: --- Github user tjwatson closed the pull request at:

[GitHub] felix pull request #172: FELIX-6026 - Fix ScrInfo service issues

2019-01-25 Thread tjwatson
Github user tjwatson closed the pull request at: https://github.com/apache/felix/pull/172 ---

[GitHub] felix pull request #172: FELIX-6026 - Fix ScrInfo service issues

2019-01-25 Thread tjwatson
GitHub user tjwatson opened a pull request: https://github.com/apache/felix/pull/172 FELIX-6026 - Fix ScrInfo service issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/tjwatson/felix FELIX-6026 Alternatively you can review

[jira] [Commented] (FELIX-6026) SCR command problems

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FELIX-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752745#comment-16752745 ] ASF GitHub Bot commented on FELIX-6026: --- GitHub user tjwatson opened a pull request:

Re: Add my key to https://dist.apache.org/repos/dist/release/felix/KEYS

2019-01-25 Thread Georg Henzler
Looks like the attachment didn't come through, so see [3] for the contents of toadd.key On 2019-01-25 23:06, Georg Henzler wrote: Hi PMC-members, could someone please add my key to list [1] as described in the release docu [2]? See attached file toadd.key. Thanks! Georg [1]

Add my key to https://dist.apache.org/repos/dist/release/felix/KEYS

2019-01-25 Thread Georg Henzler
Hi PMC-members, could someone please add my key to list [1] as described in the release docu [2]? See attached file toadd.key. Thanks! Georg [1] https://dist.apache.org/repos/dist/release/felix/KEYS [2]

Re: Showing commits on JIRA issues

2019-01-25 Thread Richard S. Hall
I do see that a commit did appear on the sidebar of issue FELIX-6035 under "Development". Unforunately, I am unable to view it because it wants me to authenticate FishEye and that appears to be impossible for me to do. Ah, the good ol' days, when I could just click on the commit in the

Re: [DISCUSS] First release of health check modules annotation, api, core, generalchecks and webconsoleplugin

2019-01-25 Thread Georg Henzler
Having thought a bit more about this, for most bundles implementing a health check it is more of an optional extension. This means bundle-XYZ primarily will provide the functionality XYZ with an optional health check testing state around functionality XYZ in action. Usually you would even make

[jira] [Commented] (FELIX-6038) Need gogo command, runtime, and shell to support java 7

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FELIX-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752690#comment-16752690 ] ASF GitHub Bot commented on FELIX-6038: --- GitHub user sebratton opened a pull request:

[GitHub] felix pull request #171: pull back in Java 7 support for gogo runtime,shell ...

2019-01-25 Thread sebratton
GitHub user sebratton opened a pull request: https://github.com/apache/felix/pull/171 pull back in Java 7 support for gogo runtime,shell and console This is for jira FELIX-6038 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FELIX-6025) Create ScriptedHealthCheck

2019-01-25 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/FELIX-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752689#comment-16752689 ] Georg Henzler commented on FELIX-6025: -- Slightly refactored for reusability from Sling in

[jira] [Commented] (FELIX-6037) Commons FileUpload 1.4 + Apache Felix Bundle WebConsole

2019-01-25 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/FELIX-6037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752379#comment-16752379 ] Carsten Ziegeler commented on FELIX-6037: - This sounds like a bug in commons fileupload; they

Re: Showing commits on JIRA issues

2019-01-25 Thread Jean-Baptiste Onofré
Hi Richard, good question, it's possible to be related to a change made by INFRA. It's worth to create a Jira at INFRA IMHO. Regards JB On 25/01/2019 15:35, Richard S. Hall wrote: > Hey everyone, > > Back in the old days we used to be able to see associated commits on a > JIRA issue if we

[jira] [Resolved] (FELIX-6036) Race condition prevents optional/greedy ref setter method from being called

2019-01-25 Thread Thomas Watson (JIRA)
[ https://issues.apache.org/jira/browse/FELIX-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Watson resolved FELIX-6036. -- Resolution: Fixed Fix Version/s: scr-2.1.16 Will be fixed in next release of SCR >

[GitHub] felix pull request #170: FELIX-6036 - avoid stashing stale RefPair objects i...

2019-01-25 Thread tjwatson
Github user tjwatson closed the pull request at: https://github.com/apache/felix/pull/170 ---

[jira] [Commented] (FELIX-6036) Race condition prevents optional/greedy ref setter method from being called

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FELIX-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752315#comment-16752315 ] ASF GitHub Bot commented on FELIX-6036: --- Github user tjwatson closed the pull request at:

Showing commits on JIRA issues

2019-01-25 Thread Richard S. Hall
Hey everyone, Back in the old days we used to be able to see associated commits on a JIRA issue if we included the JIRA issue number in the commit message. I recently wanted to check on the diff of a commit for one of Karl's commits on FELIX-6035 where he did reference the issue number in the

Re: [VOTE] Release Apache Felix Gogo JLine 1.1.4

2019-01-25 Thread David Bosschaert
+1 David On Fri, 25 Jan 2019 at 12:55, Jean-Baptiste Onofré wrote: > Hi all, > > We solved 3 issues in this release (release notes): > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310100=12344851 > > Staging repository: >

Re: [VOTE] Release Apache Felix Gogo JLine 1.1.4

2019-01-25 Thread Christian Schneider
+1 Christian Am Fr., 25. Jan. 2019 um 13:55 Uhr schrieb Jean-Baptiste Onofré < j...@nanthrax.net>: > Hi all, > > We solved 3 issues in this release (release notes): > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310100=12344851 > > Staging repository: >

[VOTE] Release Apache Felix Gogo JLine 1.1.4

2019-01-25 Thread Jean-Baptiste Onofré
Hi all, We solved 3 issues in this release (release notes): https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310100=12344851 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1278/ Please vote to approve this release: [ ] +1 Approve the

[jira] [Updated] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline

2019-01-25 Thread JIRA
[ https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated FELIX-6034: Fix Version/s: (was: gogo.jline-1.1.3) > Gogo JLine requirement doesn't allow

[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752188#comment-16752188 ] ASF GitHub Bot commented on FELIX-6034: --- Github user jbonofre closed the pull request at:

[GitHub] felix pull request #169: [FELIX-6034] Remove Requirement from Gogo JLine

2019-01-25 Thread jbonofre
Github user jbonofre closed the pull request at: https://github.com/apache/felix/pull/169 ---

[jira] [Resolved] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline

2019-01-25 Thread JIRA
[ https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved FELIX-6034. - Resolution: Not A Problem > Gogo JLine requirement doesn't allow to embed