[GitHub] [felix-dev] glimmerveen commented on a change in pull request #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
glimmerveen commented on a change in pull request #19: URL: https://github.com/apache/felix-dev/pull/19#discussion_r412465731 ## File path: scr/src/main/java/org/apache/felix/scr/impl/manager/DependencyManager.java ## @@ -2283,8 +2283,8 @@ else if (

[GitHub] [felix-dev] djencks commented on a change in pull request #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
djencks commented on a change in pull request #19: URL: https://github.com/apache/felix-dev/pull/19#discussion_r412465282 ## File path: scr/src/main/java/org/apache/felix/scr/impl/BundleComponentActivator.java ## @@ -98,133 +98,82 @@ private static class ListenerInfo

[GitHub] [felix-dev] glimmerveen commented on a change in pull request #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
glimmerveen commented on a change in pull request #19: URL: https://github.com/apache/felix-dev/pull/19#discussion_r412444967 ## File path: scr/src/main/java/org/apache/felix/scr/impl/BundleComponentActivator.java ## @@ -98,133 +98,82 @@ private static class

[GitHub] [felix-dev] djencks commented on issue #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
djencks commented on issue #19: URL: https://github.com/apache/felix-dev/pull/19#issuecomment-617384334 Trying to remember the distant past…. I think that the problem this whole thing was designed to solve was that it’s possible to have several references to the same service, even

[GitHub] [felix-dev] glimmerveen commented on a change in pull request #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
glimmerveen commented on a change in pull request #19: URL: https://github.com/apache/felix-dev/pull/19#discussion_r412444967 ## File path: scr/src/main/java/org/apache/felix/scr/impl/BundleComponentActivator.java ## @@ -98,133 +98,82 @@ private static class

[GitHub] [felix-dev] tjwatson commented on a change in pull request #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
tjwatson commented on a change in pull request #19: URL: https://github.com/apache/felix-dev/pull/19#discussion_r412440777 ## File path: scr/src/main/java/org/apache/felix/scr/impl/BundleComponentActivator.java ## @@ -98,133 +98,82 @@ private static class ListenerInfo

[GitHub] [felix-dev] glimmerveen commented on issue #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
glimmerveen commented on issue #19: URL: https://github.com/apache/felix-dev/pull/19#issuecomment-617373529 > I have some requested changes. I also would like to see some tests that verify that the listener hooks now have the expected information. Thanks for your feedback, I will

[GitHub] [felix-dev] glimmerveen commented on a change in pull request #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
glimmerveen commented on a change in pull request #19: URL: https://github.com/apache/felix-dev/pull/19#discussion_r412434960 ## File path: scr/src/main/java/org/apache/felix/scr/impl/BundleComponentActivator.java ## @@ -98,133 +98,82 @@ private static class

[GitHub] [felix-dev] glimmerveen commented on a change in pull request #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
glimmerveen commented on a change in pull request #19: URL: https://github.com/apache/felix-dev/pull/19#discussion_r412428375 ## File path: scr/src/main/java/org/apache/felix/scr/impl/BundleComponentActivator.java ## @@ -98,133 +98,82 @@ private static class

[GitHub] [felix-dev] tjwatson commented on a change in pull request #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
tjwatson commented on a change in pull request #19: URL: https://github.com/apache/felix-dev/pull/19#discussion_r412404198 ## File path: scr/src/main/java/org/apache/felix/scr/impl/BundleComponentActivator.java ## @@ -98,133 +98,82 @@ private static class ListenerInfo

Re: Proposal to contribute OSGi application metrics bundles

2020-04-21 Thread Karl Pauls
Hi Robert, it sounds like a reasonable generic solution to me - lets see what others think but just to make sure: I assume you'd be willing to maintain it, right? regards, Karl On Tue, Apr 21, 2020 at 2:25 PM Robert Munteanu wrote: > > Hi, > > I have been working on collecting startup metrics

Re: Proposal to contribute OSGi application metrics bundles

2020-04-21 Thread Jean-Baptiste Onofre
Hi, Healthcheck can be a place. Karaf Decanter can be another option as well. Regards JB > Le 21 avr. 2020 à 14:25, Robert Munteanu a écrit : > > Hi, > > I have been working on collecting startup metrics for OSGi > applications. I am interested in finding potentials for optimising >

[jira] [Created] (FELIX-6265) Replacement of Quartz Scheduler with lightweight cron scheduler

2020-04-21 Thread Amit Mondal (Jira)
Amit Mondal created FELIX-6265: -- Summary: Replacement of Quartz Scheduler with lightweight cron scheduler Key: FELIX-6265 URL: https://issues.apache.org/jira/browse/FELIX-6265 Project: Felix

Proposal to contribute OSGi application metrics bundles

2020-04-21 Thread Robert Munteanu
Hi, I have been working on collecting startup metrics for OSGi applications. I am interested in finding potentials for optimising startup time, so created a set of bundles that record: - total startup time - bundles that are slow to start - OSGi services that are restarted during startup I

Re: [healthcheck] Equivalent of SystemReady service?

2020-04-21 Thread Robert Munteanu
Hello Georg, Thanks for the implementation, looks good! I took it for a spin and for my scenario it works as expected. In addition to that. I have some notes that you may find useful. 1. api build fails due to the baselining check - org.apache.felix.hc.api.execution: Version increase required;

[GitHub] [felix-dev] glimmerveen commented on issue #16: [FELIX-6058] Re-added Bundle-Activator to gogo.jline bundle

2020-04-21 Thread GitBox
glimmerveen commented on issue #16: URL: https://github.com/apache/felix-dev/pull/16#issuecomment-617116932 @jbonofre could you have a look at this PR? I believe it would both allow the current repackaging in Karaf and allow the bundle to be used as is, thus increasing the usability of

[jira] [Commented] (FELIX-6161) SCR: Method of resolving references limits Service ListenerHook implementations

2020-04-21 Thread Arnoud Glimmerveen (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088578#comment-17088578 ] Arnoud Glimmerveen commented on FELIX-6161: --- [~cziegeler] I have applied the patch to the

[GitHub] [felix-dev] glimmerveen opened a new pull request #19: [FELIX-6161] Replace local filtering of references in favour of relying on filtered ServiceListener callbacks

2020-04-21 Thread GitBox
glimmerveen opened a new pull request #19: URL: https://github.com/apache/felix-dev/pull/19 This PR contains the patch already attached to PISTE-6161, but now applied on the current state of the felix-dev repository. This

[jira] [Commented] (FELIX-6161) SCR: Method of resolving references limits Service ListenerHook implementations

2020-04-21 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088537#comment-17088537 ] Carsten Ziegeler commented on FELIX-6161: - [~arnoud] As we have moved to git, could you maybe

[jira] [Commented] (FELIX-6203) Make bundleplugin pom.proterties reproducible

2020-04-21 Thread Veselin (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088381#comment-17088381 ] Veselin commented on FELIX-6203: It's the one linked above in "Issue links" [GitHub Pull Request

[jira] [Commented] (FELIX-6203) Make bundleplugin pom.proterties reproducible

2020-04-21 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088377#comment-17088377 ] Guillaume Nodet commented on FELIX-6203: [~markov] I can't find any PR > Make bundleplugin

[jira] [Commented] (FELIX-6203) Make bundleplugin pom.proterties reproducible

2020-04-21 Thread Veselin (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088357#comment-17088357 ] Veselin commented on FELIX-6203: I'm not sure if I have to write this here since there is no reaction on