Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2571272464 @laeubi Fixed in https://github.com/apache/felix-dev/commit/f572bd8131df53e1fd39e9655afe6c7758541cc1. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2570520017 @laeubi i was searching for something like that indeed. I will look into this later, as i agree that would scale better when we add more projects. -- This is an automated message fr

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2570377483 @paulrutter with this action you can define several filters, this can then be used to skip some jobs: https://github.com/dorny/paths-filter I think that's probably easier to h

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2569526218 We might look into https://resources.github.com/learn/pathways/automation/intermediate/create-reusable-workflows-in-github-actions/ to reduce duplicate lines in the CI files. -- Th

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

cziegeler commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2569451357 Great, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2569432880 @cziegeler Fixed in https://github.com/apache/felix-dev/commit/f0e5cc3f01411a4f93c4b6941020f2c97e54c8f4. There are now separate github action files per subproject. Maybe not i

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2569395293 That's a good point; let me see if we can split that up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

cziegeler commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2569393207 @paulrutter Thats nice! However :) I think we should have separate actions per path. Otherwise we build all configured modules, even if only one has changed. The SCR (and also configad

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2569244243 @laeubi i added Felix HTTP to actions now, see https://github.com/apache/felix-dev/commit/86e5a30b163fd5124ae088e58f68d77085647fb0. I had to disable one specific IT, as i couldn'

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2569038451 Yes, that could work. Although one might pull in a lot of additional work to get things to run properly (i noticed that earlier when running the integration tests for HTTP). -- This

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2569035701 > We would need to start adding more subprojects to it though to be useful. My idea would be to everytime one touches a subproject one enables the ci build for that as well. -- Th

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2568949420 Closing as Github actions is already active. We would need to start adding more subprojects to it though to be useful. -- This is an automated message from the Apache Git Service.

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter closed pull request #320: Idea to add CI pipeline with github actions URL: https://github.com/apache/felix-dev/pull/320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

stbischof commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2116177334 GitHub actions are active here. You can use them. Had a discussion with the Apache Infrastruktur team. But will only be executed after pr is merged. Please read also the P

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602732083 ## http/samples/whiteboard/pom.xml: ## @@ -96,7 +96,7 @@ org.apache.felix org.apache.felix.http.jetty12 -1.0.5-SNAPSH

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602727993 ## http/samples/whiteboard/pom.xml: ## @@ -96,7 +96,7 @@ org.apache.felix org.apache.felix.http.jetty12 -1.0.5-SNAPSH

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602727993 ## http/samples/whiteboard/pom.xml: ## @@ -96,7 +96,7 @@ org.apache.felix org.apache.felix.http.jetty12 -1.0.5-SNAPSH

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602726523 ## http/samples/whiteboard/pom.xml: ## @@ -96,7 +96,7 @@ org.apache.felix org.apache.felix.http.jetty12 -1.0.5-SNAPSHOT +

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602725528 ## http/pom.xml: ## @@ -42,7 +42,7 @@ base bridge inventoryprinter -itest + Review Comment: Is this still required now `-Ds

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2114207491 I meant that i couldn't get the integration tests to run in Github Actions. Hence the `-DskipUTs`. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2114205962 Okay then i misread "somehow those don't run correctly in GitHub actions" sorry for that, I think we should get in the minimal working thing and then build on top of that. -- This is an

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2114181705 Yes, i already did that. See https://github.com/blueconic/felix-dev/actions/runs/9107381646. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2114178014 As Github Actions seem not activate here, you need to test them in "your" fork, go to the settings, enable Actions and then create a PR against your own fork to test them. -- This is an

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2114124800 I reverted the unneeded changes in my pr and disabled running the integration tests for the http module, somehow those don't run correctly in GitHub actions. Needs more work still.

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2114084048 I already added the TCKs to Equinox so it should be possible, it just seems at the moment actions are not enabled for this repository at all. I'll try to provide one PR with a minima

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

stbischof commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2114039020 Also great if we can add the OSGi tck to this test. @laeubi could you give Support? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2112648709 When i find the time, i will try to investigate https://github.com/apache/felix-dev/pull/320#issuecomment-2106880844, and remove the root pom. -- This is an automated message from t

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1601717151 ## .github/workflows/build.yml: ## @@ -0,0 +1,32 @@ +# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflo

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1601715097 ## .github/workflows/build.yml: ## @@ -0,0 +1,32 @@ +# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow ex

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1601713788 ## .github/workflows/build.yml: ## @@ -0,0 +1,32 @@ +# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow ex

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2112633870 Dependent projects will still be build by their pom like today, but adding a root pom just to run the build from the root does not seems useful here. -- This is an automated message from

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2112623760 I personally like the idea of building all modules, as there might be dependencies between them which you would otherwise not notice when you use different jobs per module. Yes, a buil

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

laeubi commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2112613227 @paulrutter what do you think instead of using an aggregator pom (that seems otherwise unused) just using different Jobs, then these can run independently / in parallel. -- This is an a

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

tjwatson commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2112604656 I would like to have PR validation with github actions. Also see #301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2111631571 Ok, thank you. Before diving into this further, i will await a response from the maintainers if this is something that they would like to have going forward. -- This is an automate

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

enapps-enorman commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2111312116 > @enapps-enorman do you have an idea why the integration test doesn't work in GitHub actions? It cannot find the variables set in the pom.xml for the bundle filename. @paul

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2106880844 @enapps-enorman do you have an idea why the integration test doesn't work in GitHub actions? It cannot find the variables set in the pom.xml for the bundle filename. -- This is an

[PR] Idea to add CI pipeline with github actions [felix-dev]

paulrutter opened a new pull request, #320: URL: https://github.com/apache/felix-dev/pull/320 This unfinished PR shows the idea of using github actions on every PR to the master branch. It would build all projects in the root pom.xml and executes the same unit tests. Only the http