Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

With the 0.1.0 release we now have the chance to look into the API without too much hurry. So lets check if we would like to have bigger changes but we should not hold off a stable release for too long. I think aiming for a stable release in 1-2 weeks should be realistic. About the release versio

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

Hi Georg. I don't want to get into a flaming debate about versioning. I've seen on the internet what happens. > So to me it really boils down to not counting down when moving forward for people upgrading the health checks - it would feel awkward if you had 1.0.2 and then you use 1.0.0 again It m

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

I'm taking the hat of the many developers out there in the world that use the API (the ones we cannot talk to and that do not read this mailing list) - 2.0.0 it is to not confuse them. See my response from this morning [1] Also the Sling API has been stable for long (Bertrand has done a gre

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

Hi, (Unfortunately I haven't had a chance to look over it properly) I'd just like to say I agree with Christian and Ray - a 2.0.0 initial release is not only weird, but confusing. Why? I support doing 0.X.0 releases until the api is proven to be stable and then release *1.0.0*. Why 2.0.0? - Andr

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

Hi Bertrand, Testing that on snapshots is not optimal IMO as those are potentially moving targets. Let's do it like this then: I'll push a release 0.1.0 today (with another short [VOTE] today that I would ask you to quickly vote +1 for) and I'll leave this vote and [1] open until Christian a

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

On Thu, Jan 31, 2019 at 5:37 PM Christian Schneider wrote: > ...How about releasing 0.1.0 now and release a 2.0.0 in two weeks? > It would give people time to test the new project and still allow us to do > incompatible changes I'm also strongly in favor of that, especially as these modules m

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

Hi Ray, so I did mention the "2.x.x " approach in the initial ticket and it hasn't change since then [1]. But I know it's hard to always keep track of all JIRA comments. but I feel this is not a great approach to take. So to me it really boils down to not counting down when moving forward

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

I think the version 2.0.0 is weird when this is a new project in the org.apache.felix namespace. It doesn't matter that it previously had a higher version in some other namespace. I really recommend just making this either a 0.1.0 or 1.0.0 release. I will not vito the release or anything if it co

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

Honestly I should have looked into the code a lot earlier but did not find the time to do so. I did not expect that you would propose a major version. So this put me into quite a hurry to review the code now :-( I now went through most of it and I agree that the API looks quite good the way it is.

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

I think testing can be done easily with the current SNAPSHOT (or the artifacts from the staging repository if it needed to be a non-SNAPSHOT dependency). Also I have done pretty intensive testing during the last month (with both Felix HCs and "legacy checks" that are currently implemented again

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

How about releasing 0.1.0 now and release a 2.0.0 in two weeks? It would give people time to test the new project and still allow us to do incompatible changes. A release of 2.0.0 right now will fixate the API. If we then do a (incompatible) change we have to create a 3.0.0 version which will conf

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

Hi Christian, I think the API [1] is proven and in use since 2013 (I would guess > 2000 checks to exist out in the wild in code bases of various projects). The Felix API was carefully adjusted with your feedback (e.g. the removal of state DEBUG, FELIX-6016) to make the migration path really e

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

+1 from myself as well @Karl: Thanks for giving me the JIRA permissions, I added all versions and assigned them to the tickets. -Georg On 2019-01-31 13:58, Karl Pauls wrote: +1 Sorry it took me so long to get to it. I increased your permissions for JIRA - can you see if you can do the rele

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

I think we should not yet release a stable version. Instead I propose to release a 0.1.0. WDYT? Christian Am Mo., 28. Jan. 2019 um 09:44 Uhr schrieb Georg Henzler : > Hi all, > > We solved 11 issues in this release: > > https://issues.apache.org/jira/issues/?jql=issuekey%20in%20(FELIX-6024%2CFE

Re: [VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

+1 Sorry it took me so long to get to it. I increased your permissions for JIRA - can you see if you can do the releases yourself now? regards, Karl On Mon, Jan 28, 2019 at 9:44 AM Georg Henzler wrote: > > Hi all, > > We solved 11 issues in this release: > https://issues.apache.org/jira/issues

[VOTE] Initial release Felix Health Check Annotations 2.0.0, Health Check API 2.0.0, Health Check Core 2.0.0, Health Check General Checks 2.0.0, Health Check Webconsole Plugin 2.0.0

Hi all, We solved 11 issues in this release: https://issues.apache.org/jira/issues/?jql=issuekey%20in%20(FELIX-6024%2CFELIX-6025%2CFELIX-6017%2CFELIX-6018%2CFELIX-6016%2CFELIX-6012%2CFELIX-6011%2CFELIX-6010%2CFELIX-6005%2CFELIX-6004%2CFELIX-5952) (@PMC: Could you please create the versions for th