[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-23 Thread Amit Mondal (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540913#comment-17540913 ] Amit Mondal commented on FELIX-6529: [~karlpauls] The duplicate strings I encountered earlier were

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-23 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540889#comment-17540889 ] Karl Pauls commented on FELIX-6529: --- [~amitmondal], I might be wrong, but I don't see these being

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-23 Thread Amit Mondal (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540869#comment-17540869 ] Amit Mondal commented on FELIX-6529: [~karlpauls] I have just tested and analyzed the Framework

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-19 Thread Amit Mondal (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539843#comment-17539843 ] Amit Mondal commented on FELIX-6529: [~karlpauls] Thanks a lot for your quick response (y) I didn't

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-19 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539842#comment-17539842 ] Karl Pauls commented on FELIX-6529: --- [~amitmondal]: I think you can just add it to your settings,

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-19 Thread Amit Mondal (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539838#comment-17539838 ] Amit Mondal commented on FELIX-6529: [~karlpauls] I can surely test the snapshot version as well. I

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-19 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539837#comment-17539837 ] Karl Pauls commented on FELIX-6529: --- [~amitmondal] - thanks, I deployed a new 7.1.0-SNAPSHOT for now so

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-19 Thread Amit Mondal (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539828#comment-17539828 ] Amit Mondal commented on FELIX-6529: [~karlpauls] I just noticed your PR and it surely is very

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-18 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538938#comment-17538938 ] Karl Pauls commented on FELIX-6529: --- [~amitmondal], could you try my PR and see if it helps in our

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-17 Thread Johannes Edmeier (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538228#comment-17538228 ] Johannes Edmeier commented on FELIX-6529: - >From my knowledge the String.intern() can be more

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-17 Thread Amit Mondal (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538081#comment-17538081 ] Amit Mondal commented on FELIX-6529: String.intern() is not recommended for Java 6 for the fixed-size

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-17 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538039#comment-17538039 ] Karl Pauls commented on FELIX-6529: --- Right, I had the same question as [~gnodet], shouldn't we just use

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-17 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538036#comment-17538036 ] Guillaume Nodet commented on FELIX-6529: Wouldn't it be easier to just use `String.intern()`

[jira] [Commented] (FELIX-6529) Improve memory usage ManifestParser using String deduplication

2022-05-17 Thread Amit Mondal (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538033#comment-17538033 ] Amit Mondal commented on FELIX-6529: This is a huge improvement. In cases where lots of bundles are