[ https://issues.apache.org/jira/browse/FELIX-5925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konrad Windszus updated FELIX-5925: ----------------------------------- Description: It would be nice to also have a check in https://github.com/apache/felix/tree/trunk/tools/osgicheck-maven-plugin for packages with a dedicated version which do not explicitly state, whether they are provider or consumer type. Although there is a default (ConsumerType) as specified in https://osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html it is reasonable to enforce a conscious decision (i.e. an explicit annotation) for the following reasons: - people tend to forget to think about this for new API/SPI - the default used to be different with the same-named bnd annotation in the past therefore relying on the default is very error prone was: It would be nice to also have a check for packages with a dedicated version which do not explicitly state, whether they are provider or consumer type. Although there is a default (ConsumerType) as specified in https://osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html it is reasonable to enforce a conscious decision (i.e. an explicit annotation) for the following reasons: - people tend to forget to think about this for new API/SPI - the default used to be different with the same-named bnd annotation in the past therefore relying on the default is very error prone > osgicheck-maven-plugin: Add check for packages with versions but without > explicit provider/consumer type information > -------------------------------------------------------------------------------------------------------------------- > > Key: FELIX-5925 > URL: https://issues.apache.org/jira/browse/FELIX-5925 > Project: Felix > Issue Type: Improvement > Components: Utils > Reporter: Konrad Windszus > Priority: Major > Fix For: osgicheck-maven-plugin 1.0.0 > > > It would be nice to also have a check in > https://github.com/apache/felix/tree/trunk/tools/osgicheck-maven-plugin for > packages with a dedicated version which do not explicitly state, whether they > are provider or consumer type. Although there is a default (ConsumerType) as > specified in > https://osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html > it is reasonable to enforce a conscious decision (i.e. an explicit > annotation) for the following reasons: > - people tend to forget to think about this for new API/SPI > - the default used to be different with the same-named bnd annotation in the > past therefore relying on the default is very error prone -- This message was sent by Atlassian JIRA (v7.6.3#76005)