Re: Some ideas for improvements in resolver

2016-05-11 Thread Guillaume Nodet
2016-05-11 15:45 GMT+02:00 Thomas Watson : > I want to keep a copy of the spec source in the project because we will be > using the project to prototype OSGi R7. It helps to keep the source in the > project so we can get the very latest before the final spec is released. > The felix resolver impl

Re: Some ideas for improvements in resolver

2016-05-11 Thread Richard S. Hall
On 5/11/16 10:10 , Christian Schneider wrote: On 11.05.2016 15:52, Jean-Baptiste Onofré wrote: Hi Christian, About 1/, the spec classes will be embedded in the resolver bundle anyway ? It is not about removing the embedding. This is fine. It is more about keeping the spec sources in one place

Re: Some ideas for improvements in resolver

2016-05-11 Thread Thomas Watson
At some point I think the OSGi Alliance may do this but it gets relatively late in the process. Tom On Wed, May 11, 2016 at 9:52 AM, Richard S. Hall wrote: > On 5/11/16 10:10 , Christian Schneider wrote: > >> On 11.05.2016 15:52, Jean-Baptiste Onofré wrote: >> >>> Hi Christian, >>> >>> About 1/

Re: Some ideas for improvements in resolver

2016-05-11 Thread Christian Schneider
On 11.05.2016 15:45, Thomas Watson wrote: I want to keep a copy of the spec source in the project because we will be using the project to prototype OSGi R7. It helps to keep the source in the project so we can get the very latest before the final spec is released. The felix resolver impl is goin

Re: Some ideas for improvements in resolver

2016-05-11 Thread Christian Schneider
On 11.05.2016 15:52, Jean-Baptiste Onofré wrote: Hi Christian, About 1/, the spec classes will be embedded in the resolver bundle anyway ? It is not about removing the embedding. This is fine. It is more about keeping the spec sources in one place. If we host a copy it is difficult to make su

Re: Some ideas for improvements in resolver

2016-05-11 Thread Jean-Baptiste Onofré
Hi Christian, About 1/, the spec classes will be embedded in the resolver bundle anyway ? +1 to upgrade to Java 6. +0 on removing the generic Util class. +0 about ResolveSession and move Blame, PermutationType, etc there. I'm not sure it will actually reduce the "global" weight (just moving c

Re: Some ideas for improvements in resolver

2016-05-11 Thread Thomas Watson
I want to keep a copy of the spec source in the project because we will be using the project to prototype OSGi R7. It helps to keep the source in the project so we can get the very latest before the final spec is released. The felix resolver impl is going to be the RI again so we need the freedom

Some ideas for improvements in resolver

2016-05-11 Thread Christian Schneider
Thomas asked me to look into the current code in resolver after his improvements. I found some spots that could be improved: - We currently have a copy of the resolver spec sources inside the code. I propose to refer to the spec bundle instead and embed the classes from there. This protects a