[GitHub] [felix-dev] amitjoy commented on pull request #192: Updated to use HTTP optionally in HealthCheck

amitjoy commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1406520354 I just added a new commit to update to HTTP whiteboard. There was no runtime issue to use the old pattern of using `HttpService` to register the servlets, but dependency to `HttpService`

[GitHub] [felix-dev] amitjoy commented on pull request #192: Updated to use HTTP optionally in HealthCheck

amitjoy commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1406536455 @ghenzler @cziegeler Could you kindly have a look at it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (FELIX-6565) Make OSGi HTTP Package dependency optional in HealthCheck core bundle

[ https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681343#comment-17681343 ] Amit Mondal commented on FELIX-6565: I just added a new commit to update to HTTP whit

[GitHub] [felix-dev] amitjoy commented on pull request #192: Updated to use HTTP optionally in HealthCheck

amitjoy commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1406537927 @jbonofre Thanks a lot for assigning yourself for the review 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [felix-dev] JochenHiller commented on a diff in pull request #192: Updated to use HTTP optionally in HealthCheck

JochenHiller commented on code in PR #192: URL: https://github.com/apache/felix-dev/pull/192#discussion_r1089011866 ## healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServlet.java: ## @@ -162,7 +164,10 @@ void setDescription(String d) {

[GitHub] [felix-dev] amitjoy commented on a diff in pull request #192: Updated to use HTTP optionally in HealthCheck

amitjoy commented on code in PR #192: URL: https://github.com/apache/felix-dev/pull/192#discussion_r1089029567 ## healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServlet.java: ## @@ -162,7 +164,10 @@ void setDescription(String d) { Re

[GitHub] [felix-dev] amitjoy commented on a diff in pull request #192: Updated to use HTTP optionally in HealthCheck

amitjoy commented on code in PR #192: URL: https://github.com/apache/felix-dev/pull/192#discussion_r1089029908 ## healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServlet.java: ## @@ -215,29 +219,24 @@ protected final void activate(final H

[GitHub] [felix-dev] amitjoy commented on a diff in pull request #192: Updated to use HTTP optionally in HealthCheck

amitjoy commented on code in PR #192: URL: https://github.com/apache/felix-dev/pull/192#discussion_r1089030958 ## healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServlet.java: ## @@ -215,29 +219,24 @@ protected final void activate(final H

[GitHub] [felix-dev] JochenHiller commented on pull request #192: Updated to use HTTP optionally in HealthCheck

JochenHiller commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1406626705 Latest changes from @amitjoy LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (FELIX-6589) update method with constructor injection does not work

Jürgen Albert created FELIX-6589: Summary: update method with constructor injection does not work Key: FELIX-6589 URL: https://issues.apache.org/jira/browse/FELIX-6589 Project: Felix Issue Ty