Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

2024-05-16 Thread via GitHub
paulrutter commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2114207491 I meant that i couldn't get the integration tests to run in Github Actions. Hence the `-DskipUTs`. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

2024-05-16 Thread via GitHub
laeubi commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602725528 ## http/pom.xml: ## @@ -42,7 +42,7 @@ base bridge inventoryprinter -itest + Review Comment: Is this still required now `-Ds

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

2024-05-16 Thread via GitHub
laeubi commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602726523 ## http/samples/whiteboard/pom.xml: ## @@ -96,7 +96,7 @@ org.apache.felix org.apache.felix.http.jetty12 -1.0.5-SNAPSHOT +

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

2024-05-16 Thread via GitHub
paulrutter commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602727993 ## http/samples/whiteboard/pom.xml: ## @@ -96,7 +96,7 @@ org.apache.felix org.apache.felix.http.jetty12 -1.0.5-SNAPSH

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

2024-05-16 Thread via GitHub
paulrutter commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602727993 ## http/samples/whiteboard/pom.xml: ## @@ -96,7 +96,7 @@ org.apache.felix org.apache.felix.http.jetty12 -1.0.5-SNAPSH

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

2024-05-16 Thread via GitHub
paulrutter commented on code in PR #320: URL: https://github.com/apache/felix-dev/pull/320#discussion_r1602732083 ## http/samples/whiteboard/pom.xml: ## @@ -96,7 +96,7 @@ org.apache.felix org.apache.felix.http.jetty12 -1.0.5-SNAPSH

Re: [PR] FELIX-6704: Include config/factory PID in error message [felix-dev]

2024-05-16 Thread via GitHub
kwin commented on PR #317: URL: https://github.com/apache/felix-dev/pull/317#issuecomment-2114297023 @cziegeler or @bosschaert Can you review/merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] FELIX-6704: Include config/factory PID in error message [felix-dev]

2024-05-16 Thread via GitHub
bosschaert merged PR #317: URL: https://github.com/apache/felix-dev/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apach

Re: [PR] Idea to add CI pipeline with github actions [felix-dev]

2024-05-16 Thread via GitHub
stbischof commented on PR #320: URL: https://github.com/apache/felix-dev/pull/320#issuecomment-2116177334 GitHub actions are active here. You can use them. Had a discussion with the Apache Infrastruktur team. But will only be executed after pr is merged. Please read also the P

[PR] Add github verification for SCR [felix-dev]

2024-05-16 Thread via GitHub
laeubi opened a new pull request, #321: URL: https://github.com/apache/felix-dev/pull/321 This adds a github verification workflow for the scr component of felix dev. I created an example PR how it would looks like after the merge here: - https://github.com/laeubi/felix-dev/pull/3